From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id BE24F385700A for ; Tue, 28 Nov 2023 09:47:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE24F385700A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE24F385700A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701164876; cv=none; b=gVMTbCL5MLuN/3Pd6qsGdtJA6xbEQza0epKEkHViwManjXhd9ONXl1AygvrRX7lBZ4FsGgtnUILqNlWIhQClVZBZMAYShMPpuaHC70PgfA/BZ/ymiLY/zbG/UfbZirQ3sms6phiU1mCHfKf9e5QpBHJoM3dZajTeQa7N3gh4hIM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701164876; c=relaxed/simple; bh=KVL8CEV0M9cpUdPVSZPpIL9kF5T4VCA/DbHeukh4OeM=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=UwKb2cn40w+AHg2oNCFTWRcam4PYVUAqJq2SrtmQ2qHoJ3jFaY2TxpwRlbgpqUDQhBUJpxUz7F42D3/AcwN+vhvlchJFs7oZfDkfrjihPu9MYMAfU1Uai2QkBuMhB5UnV89bmolhz3eaNWj6E7eYDldomkf8WIrar9n//J2Po7Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C480B2198B; Tue, 28 Nov 2023 09:47:53 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A9A341343E; Tue, 28 Nov 2023 09:47:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bZmwJ0m3ZWUYZQAAD6G6ig (envelope-from ); Tue, 28 Nov 2023 09:47:53 +0000 Message-ID: <993259bc-b367-452a-a370-50588a5f0be7@suse.de> Date: Tue, 28 Nov 2023 10:47:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] [gdb] Fix segfault in for_each_block, part 2 To: Hannes Domani , "gdb-patches@sourceware.org" References: <20231110080915.18008-1-tdevries@suse.de> <20231110080915.18008-3-tdevries@suse.de> <543290455.2684585.1699604662307@mail.yahoo.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <543290455.2684585.1699604662307@mail.yahoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: +++++ Authentication-Results: smtp-out1.suse.de; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none); spf=softfail (smtp-out1.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tdevries@suse.de) smtp.mailfrom=tdevries@suse.de X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [5.80 / 50.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[yahoo.de]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_SOFTFAIL(4.60)[~all:c]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,sourceware.org:url]; FREEMAIL_TO(0.00)[yahoo.de,sourceware.org]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(2.20)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spam-Score: 5.80 X-Rspamd-Queue-Id: C480B2198B X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/10/23 09:24, Hannes Domani wrote: > Am Freitag, 10. November 2023 um 09:08:11 MEZ hat Tom de Vries Folgendes geschrieben: > >> --- a/gdb/s390-linux-nat.c >> +++ b/gdb/s390-linux-nat.c >> @@ -949,10 +949,12 @@ s390_target_wordsize (void) >>    /* Check for 64-bit inferior process.  This is the case when the host is >>        64-bit, and in addition bit 32 of the PSW mask is set.  */ >> #ifdef __s390x__ >> +  int tid = s390_inferior_tid (); >> +  gdb_assert (tid == 0); > > Did you not mean `tid != 0` here? > I did, thanks for spotting that. I hadn't been able to test on s390x yet, by now I have. Fixed in the v5 version I've pushed ( https://sourceware.org/pipermail/gdb-patches/2023-November/204569.html ). Thanks, - Tom