From: Hannes Domani <ssbssa@yahoo.de>
To: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tom@tromey.com>
Subject: Re: [PING^4] [PATCH] Also compare frame_id_is_next in frapy_richcompare
Date: Sun, 7 Feb 2021 18:17:12 +0000 (UTC) [thread overview]
Message-ID: <998988331.453291.1612721832448@mail.yahoo.com> (raw)
In-Reply-To: <87im74vtxm.fsf@tromey.com>
Am Sonntag, 7. Februar 2021, 15:22:48 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Hannes> Am Samstag, 6. Februar 2021, 23:38:18 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >> >> > > > With this change, that same example returns False.
> >> >> > > >
> >> >> > > > gdb/ChangeLog:
> >> >> > > >
> >> >> > > > 2020-12-18 Hannes Domani <ssbssa@yahoo.de>
> >> >> > > >
> >> >> > > > * python/py-frame.c (frapy_richcompare): Compare frame_id_is_next.
> >>
> >>
> >> This seems reasonable, but is it possible to add a test case for it?
>
> Hannes> I thought about it, but I couldn't figure out how to intentionally create
> Hannes> a corrupt frame.
>
> Yeah, that makes sense. The patch is ok. Thank you.
Pushed, thanks.
Hannes
prev parent reply other threads:[~2021-02-07 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <648862269.5845140.1612016162852.ref@mail.yahoo.com>
2021-01-30 14:16 ` Hannes Domani
2021-02-06 22:38 ` Tom Tromey
2021-02-06 22:41 ` Hannes Domani
2021-02-07 14:22 ` Tom Tromey
2021-02-07 18:17 ` Hannes Domani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=998988331.453291.1612721832448@mail.yahoo.com \
--to=ssbssa@yahoo.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).