Re: [PATCH][gdb/c++] Print destructor the same for gcc and clang

[Keith Seitz <keiths@redhat.com>]

On 9/27/22 03:35, Tom de Vries wrote:
> 
> Fix this by rewriting the code to:
> - always enter the loop
> - handle whether arguments need printing in the loop
> - keep track of how many arguments are printed, and
>    use that after the loop to print void etc.
> such that we have the same for both gcc and clang:
> ...
>      A(void);
>      ~A(void);
> ...
> 
> Note that I consider the discussion of whether we want to print:
> - A(void) / ~A(void), or
> - A() / ~A()
> out-of-scope for this patch.
> 
> Tested on x86_64-linux.
> 
> Any comments?

This all looks okay; thank you for that cleanup. Consistency is welcome.

On the [off-]topic of "void" vs ""... The standard (IIUC) permits the use of
"void" in destructors. If I create a class with a private dtor, e.g., to elicit
a compilation failure, clang++ never outputs the symbol name. GCC, on the other
hand, does, and it outputs "" (no "void", even if I explicitly use "void" in the
dtor).

While I would prefer "", I don't have a compelling argument either way. [It's
trivial to implement with your patch.]

I recommend you approve your patch. :-)

Keith