From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 8DBE8386F016 for ; Thu, 26 Nov 2020 21:49:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8DBE8386F016 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 30CCB1E552; Thu, 26 Nov 2020 16:49:14 -0500 (EST) Subject: Re: [PATCH] gdb: define COFF file offsets with file_ptr From: Simon Marchi To: Jameson Nash , gdb-patches@sourceware.org References: <20201126181121.31219-1-vtjnash@gmail.com> <2bb948a7-e909-8949-7486-2aec0c4a9ecf@simark.ca> Message-ID: <99cc42c3-5429-2b67-8577-54160765a729@simark.ca> Date: Thu, 26 Nov 2020 16:49:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <2bb948a7-e909-8949-7486-2aec0c4a9ecf@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2020 21:49:15 -0000 On 2020-11-26 1:51 p.m., Simon Marchi wrote: > I don't see anything wrong with the patch, except maybe one nit below. > I would like if we could wait a week or so, maybe others who know more > about this will have something to say. I forgot to say: please ping if nothing happened a week from now, because I'll probably don't remember and the thread will be quite far in my inbox. Simon