From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F3D733858C66 for ; Fri, 28 Apr 2023 16:14:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F3D733858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682698451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0IAy5ej85Ed3Zgp12l+yEoeGuvHjuttWHNw60clEn0I=; b=FslXQq8wVZ19j24dbrQGqLZGNlXVwI4EVizbZvqPi3ngiV+JtwraTAC65g13iaoqJVo7w7 WdLOu6SDBjKrwfwxSoa3KOrNUGob7lteo7yMoa27714UMSRo19pfZeqpZcP4P6giEyU7LB 6bqxmIFHT5NmsdYsMryj78w+UUv4muc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-468-9ILwpVaTMH-4b-ohP-jRDA-1; Fri, 28 Apr 2023 12:14:08 -0400 X-MC-Unique: 9ILwpVaTMH-4b-ohP-jRDA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A81043C10ECF; Fri, 28 Apr 2023 16:14:07 +0000 (UTC) Received: from [10.22.9.236] (unknown [10.22.9.236]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66122492C13; Fri, 28 Apr 2023 16:14:07 +0000 (UTC) Message-ID: <9a2f5081-5655-583d-51d2-2209ebb30648@redhat.com> Date: Fri, 28 Apr 2023 09:14:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 0/3] Minor expression cleanups To: Tom Tromey , gdb-patches@sourceware.org References: <20230428-minor-expr-cleanuups-v1-0-0a634e8d5c25@adacore.com> From: Keith Seitz In-Reply-To: <20230428-minor-expr-cleanuups-v1-0-0a634e8d5c25@adacore.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/28/23 09:02, Tom Tromey via Gdb-patches wrote: > While looking at some parser-related changes for DAP, I found a few > things that could be cleaned up independently. > > Regression tested on x86-64 Fedora 36. [Very] Nice cleanups. I've looked over the series, and it LGTM. Keith > --- > Tom Tromey (3): > Remove op_name > Remove evaluate_expression > Remove evaluate_type > > gdb/ada-lang.c | 4 ++-- > gdb/arc-tdep.c | 2 +- > gdb/breakpoint.c | 2 +- > gdb/cli/cli-script.c | 4 ++-- > gdb/darwin-nat-info.c | 2 +- > gdb/dtrace-probe.c | 4 ++-- > gdb/eval.c | 25 ++++--------------------- > gdb/expprint.c | 41 +++++++++++++++++------------------------ > gdb/expression.h | 12 +++++++----- > gdb/gnu-v3-abi.c | 2 +- > gdb/linux-thread-db.c | 2 +- > gdb/mi/mi-main.c | 6 +++--- > gdb/objc-lang.c | 4 +--- > gdb/printcmd.c | 12 ++++++------ > gdb/stack.c | 2 +- > gdb/stap-probe.c | 2 +- > gdb/tracepoint.c | 2 +- > gdb/typeprint.c | 4 ++-- > gdb/value.c | 2 +- > gdb/value.h | 11 ----------- > gdb/varobj.c | 14 +++++++------- > 21 files changed, 62 insertions(+), 97 deletions(-) > --- > base-commit: 1f7f972f59470104734ec705c985ab319eb580db > change-id: 20230428-minor-expr-cleanuups-77d8f8d15594 > > Best regards,