From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22922 invoked by alias); 25 Oct 2016 00:31:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22909 invoked by uid 89); 25 Oct 2016 00:31:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:a52e X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 00:31:23 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A7AD3B707; Tue, 25 Oct 2016 00:31:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9P0VKu1030905; Mon, 24 Oct 2016 20:31:21 -0400 Subject: Re: GDB AIX build broken To: David Edelsohn References: <01ba546d-060d-8591-9c5a-84d4bda2af22@redhat.com> Cc: GDB Patches From: Pedro Alves Message-ID: <9a7ac4b5-2f5c-916c-a52e-c94e64d6f4f0@redhat.com> Date: Tue, 25 Oct 2016 00:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00680.txt.bz2 On 10/25/2016 01:13 AM, David Edelsohn wrote: > On Mon, Oct 24, 2016 at 7:00 PM, Pedro Alves wrote: > >> That's a hint, but it can't be the fix. common-defs.h must be the >> first file included. I suspect that gnulib's inttypes.h >> replacement logic is broken on AIX. > > The gnulib import definitely is the commit that caused the breakage. > > Interestingly, > > gdb/btrace.c uses > > #include > > while > > gdb/common/buffer.c uses > > #include "inttypes.h" I can't imagine there being a real reason for that. > > Also, I'm sorry if my earlier comments came across poorly. Sorry if I misunderstood them. Might have been lost in translation. Thanks, Pedro Alves