From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2050.outbound.protection.outlook.com [40.107.116.50]) by sourceware.org (Postfix) with ESMTPS id A2B3F3858D3C for ; Fri, 22 Dec 2023 16:57:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2B3F3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2B3F3858D3C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.50 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703264264; cv=pass; b=u67ppWVhBKsjKKmov8ZTSlNiWrPKFlwm83xIKr3NUvdFsYattdLOYMdurjZVzdSab0okJfVpHDshKCrKLam0RFS42doyeoiSUuObPmQrbJHp5K/Jee84nOp/7jhUiNpRfpzIm89E+732OwTpb5EJE4xtq3UqA8s5vRRNdCgWRnM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703264264; c=relaxed/simple; bh=hC4V/pFgVcDdkXJxMniO8oE0XGm0WfRerPZzDEtIRA8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=uhE22e5IBzb4tiUh1vzVHaEyFKHeafSeyGkvzjFMv6Gl4cmPtP2PBaMrrRwcbdMaBR1HpaVEGBhP6S1JtQfmsCjh1++14x4s1NzBezZsWdqCD41XjPgVW3BExl32KiM6o8ujthtEGcvFX6j5s3bCx7KdIMqcWY6b+PsdgQZWTQU= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8kglWTWAYDAkdCJu1eyanQfmuo+uIopEZafobyNlbrXGFEz8iatUvE5mHihpzyq4HVj4urnFDSOo21A2iZ8cSP2d2GeEvHXySHS4dBBvgGz9o1ZfFRPWdz36xWPe2IeqIO7TjvO5H3A/zdEaNy4eTrWlV+Q0CtXzQAUQlGiqY+xX9CrQzm7rIUy37Qg95y0Cx+6cY+I2NU/iLtMeY/RjZ4Cy7tGnsDAqXXcFbpPhjuEh/btiqgGPm5tefLSwN1reBqFsuJxBryyKZ6GbryM27+Ae+VlCsZDkoZQJQ74gTcEgSsek2cm48N8ksVJcsSS4bvuGg/0qoZIbOwfSrGFuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1JmG/fCC4jwoNtjUgKBRjKY0w0MsrQuT7wFrmRXi8Os=; b=hzQFJ+0k4R1Sr3Ur2Yop+uxRSgviYtkZ3v+AyrG+UoPX0diL7k5s59WZSF+5uBZ8uh6+YGWJX4Jqt5IsWmQPEA8i6hBBCXBVObgZL2Bi9QtbfOEe9YOKsfjLr9dbhQ+bp6ew5h7hmJFiKHBHzc81Uwh3fmtIwjobxmM1ad7Mht7IbmMsM6eduIAKwHtNZV0EQaDKhVsYE+AT9OnXpti97LImE73CG0gXhQIXN5B5OaSUUYDN7EcCTrfLsdxLXGzDGwPAzZlql2pj/48RFWigkDfgFuhz/52j/DY3MOc+bH/is4zmjZpfzFFgaD78kR2EpjslZRUbtQLMzXjSInJaiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1JmG/fCC4jwoNtjUgKBRjKY0w0MsrQuT7wFrmRXi8Os=; b=l6dvXBG5ggoXcRherS3F2RSiPTZG+B7TBBxpPokMeHaqPTXsyHkVgtU4MsFbKHVn6Mz+v9iobWSEAFlzDM/j3uqocjEOEXPx7nmNOJggyQY6aXdQxa/XT4trxhSX0X3b2LvxBvK5LyMrfUS8zREvzuvRPnTRRu/PhRvrHHtaitnlGsQG6qONr7Jfkfc+5Rc4764UZSYuj9W0nd8iVs4rx3dXmyZfqgolIXhITqX3+ziFs8wq8n5hLQP0DP4X2ZTTWhNqYNuZCF7ukZylPceYzipseoMgyOykyIeyVa97IlxiEd6rlp2xGwU5MiMUredq3lnpUFis++0sAwb1h9FI9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB5844.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:5d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.21; Fri, 22 Dec 2023 16:57:40 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::9378:63a0:1c28:2df7%3]) with mapi id 15.20.7113.019; Fri, 22 Dec 2023 16:57:40 +0000 Message-ID: <9a98a8c9-fa47-412d-89f6-1abee23db1a2@efficios.com> Date: Fri, 22 Dec 2023 11:57:39 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 8/9] gdb: remove VALUE_REGNUM, add value::regnum Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231221191716.257256-1-simon.marchi@efficios.com> <20231221191716.257256-9-simon.marchi@efficios.com> <87bkai18od.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87bkai18od.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0139.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:87::13) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB5844:EE_ X-MS-Office365-Filtering-Correlation-Id: b6d75c3c-2f1a-4fe1-731e-08dc030f1bc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uows9P7qPvOs7Qq0ZduHRGeivK0+JmxrvTqepLFtulTG6Og4Gzm/VVYztrJw2eBbffo9gnnkU+O+LzHUibsZsWnAh87vOehMSEBmzLgUt5WN6hUySTp/zGaKqcubOtKCiuZUKybgyz51lYWa9nkNgdl/2i0i1DqZB1PA9eW+llQ+3deAFKf8tRKk7aGE7zvTvB2nwf+Tb3dJWj+VhnjPfZ5f5R/zVg2R0eoPXrLScQY7Lz3gOcU1m2rze+SL9DgOZ8R+jLBHOzVPaDCmKLzJhqHfijXlnzj5Ab6p6cgoQCw6kwU/COcdJQIxJg3lQHHu6Pcxil0ggCEFCDVdMEjP4T0AXcIhWB6Sb9Kl1ss5VP+PRvfo0IlKtGiKRb/2RgwugkM3NIkdm3wNrrwSqeynu7Vt8v3Mgzy0rA7epvFkFdiY9ohtJX4HoJCd15cbIJ42V9y7JUIu73QZZj8YrNU1qQeOKizd1fCYDGvcJ9v3FijPIY4XXctEZiigRnRw5XpKRWaOtsYF6KFI8GQ3s7JMMOMfqelTa/DUyNRW1+9MoeiThmm+kBIxIYkSKyxHkyCkqyfQBunYqlgXHZ3KvGwgmoU1L/QGnwYNuNwsi8rlDFQzoeTdULjq9PWCsKEezkWZBFP+qA0pH7+szYg1jcNc/Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376002)(39830400003)(396003)(136003)(366004)(346002)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(31686004)(26005)(2616005)(6506007)(6512007)(36756003)(38100700002)(31696002)(66556008)(8936002)(41300700001)(8676002)(66946007)(44832011)(53546011)(5660300002)(6916009)(4326008)(66476007)(2906002)(4744005)(6486002)(478600001)(316002)(4001150100001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDJBWGpQbmRsN2ZmNXBsVjN3dE5ZcDI3SnJwNWJBM2ZpUHh4Y2VlNWxOc1FW?= =?utf-8?B?Wm1KeFh3MjJNUGYzeFNCOFZ2VXlqWjJLNUNVejRSQnNZTXFaZVpJL3ljbzho?= =?utf-8?B?N1cyWnRlaGFYSlphQml4ekVNZVc2VUdIQUZjTE1uMWcwRGRwSUVyeUNlK2cw?= =?utf-8?B?dmJTdlJEZzk3VE1LVFhZYmY3emppSHc0aWVjbDYzKzhUU1lQZnc4NFUvMTJs?= =?utf-8?B?Q3dacU81am93T2lQK2hBRlJEN05SVm1jOEx5Q21WK0pJWVZJYzJnVFBJNW4r?= =?utf-8?B?dlVFTTI2RytOM0l1ZzZaeVZJc1kwazF5d3hzY2NKMnNvZkExUzNYaTlmVlF6?= =?utf-8?B?OGRmOXhIamhpUlYxRU94d0RpRld6a016YWdaUEdqWDZVcFJUTExzUGF5a291?= =?utf-8?B?ZGZzTVVRT1RTTTBQSzhPTEhZU004bEpBT3pDMnNrSFNFNHM5b0lydUVRUEJQ?= =?utf-8?B?NCtsNm15MUNQVjI2alRTcXFKMGdWN1lTQmxXVUhhcC83dTV4Z2Z2NTFzcjJ3?= =?utf-8?B?b05rV1NadzA0ZlpvQ2JjaDdFd2NPaDFqMTIwV05JTDFKcTBVK3dQdWJEZDln?= =?utf-8?B?SEh4Y2xhN3dIak1Zb25ESVZqTTBvckQxcGJNd05tNDRUYWFFWEowd0p5bmRu?= =?utf-8?B?UTMxazg4OHdpNjZuZHp3U2RrYnA3dTlsV2YrcHdmOFlwZGxkWGZNbG1TRjBa?= =?utf-8?B?bkVpNDJud1VzVklkZUFENnpSY2Z4RnNlVTNTZ1F4b3E0cktvbHpiQ0ZnWkNN?= =?utf-8?B?Q3ZtUG04R3BaekVUVUxHeWZMQ0IxZ2VrdG1uT1lpbTJDeXhDdS9yMWlmemNL?= =?utf-8?B?dGQ5alNUelNnbzZVQzE1aWhYUDhBSVVPUU5HcHRkakh5YWlNU29MRUVDbWNm?= =?utf-8?B?b0dwQ092MlF5TkduQ08wcXdIQUh6c0MyM1gvcjdBZ0tpemNlaEhWY3RoR2t5?= =?utf-8?B?aWNRZDlvcWZjL1NjbGR3RFBUa0NtZExyc1dOUkozR3ArM0ZHN0JRRU1wdjJn?= =?utf-8?B?U3U1YStQRStZeHBOYUhsZk9aczJrdlh0Y1V5ckxXN053YkF5ODlqajdlWnVZ?= =?utf-8?B?VlZ0VXRLSDZRUWNUTWJ5Nm9KQXRGazdoUHJpRVpJSjA2aEwzODI0c2FqYUsz?= =?utf-8?B?SXdPL1BhSVBJdlRSTUc0YWsrcU12Z0lrbkJ2WjRPeVVLSFRlOTZrQkdNQys0?= =?utf-8?B?SktuT3I1U2EvRWNPUC90ek81NFdyU0RaRnBSL1NLOEk0ZG1wU2lWVGxiK0du?= =?utf-8?B?N0NhV01kei9mOXVPN1gyaHROWWhVbEFlRGZ6R0dtTW9zWnlVQk9Qd0hlcEVN?= =?utf-8?B?Zy9aSW9oRjNMK2c0K3l0NlkyZ1c1SkJaclFTOXFFRFJWRDJFd2NDMElqMUNj?= =?utf-8?B?K2VpNlVxVVZ2RWt5YTg1Nmw5K0FxZm1YdHpwazFJSTVQR090ekZlanZJZkdz?= =?utf-8?B?ZGtDb2R4NGUwdFp6V3ZYSFFXM2VZUUZYQVJ2Q3lPZ2N3SXVIbmovOS9aZk1n?= =?utf-8?B?ZXJtdnZmREhDaTIxbGZwQzJQOXF0dzQyUEk0dGZsRWZERHZhYzd5QmVVQzlh?= =?utf-8?B?YUNhdU0zdlFUK2dybUl5K1JreVhxNE51a1AyeENZY0sybkRRZ1FwbmRLRmd4?= =?utf-8?B?QTJNUTBrSHhiMnlSUytiQ29qaU5mWVBZNThNcG0xWTZYZmJHQkdMaUE0a2JP?= =?utf-8?B?M2FNSGdldHcyZlF5MW1uOFV0WWxwblpRRDRGSzRocGNQb3dNdkpFTiswUnVB?= =?utf-8?B?RHJmNE5aQkFBNXB0OHozeTNiOG1sc3BsQnNYS2M4dzlOcllBNEdXRzhQblU3?= =?utf-8?B?dk1HNVZ0K29lbCt0WGZoSFJFTHVTcGJTeU1IdVhkVzh2blI3YmN1ejBEVC9x?= =?utf-8?B?amNZMDZyNE9oclQxQ3BUdHVTeFNEb3picWs5Z3BNYm14UUxycUYycWtGQ3Fo?= =?utf-8?B?VUhjSlZHakRxandqREpTdi9xcThYenR5bTJ6WXYzekM3MCtJM3BMRnZ0MmxE?= =?utf-8?B?SnQ4em5CN01LcHpON3MxWDFVUmw5WE1RMUxMRWQ5L3hSbG0rZEQ3WkRVOU9v?= =?utf-8?B?d0YxMHNCZVk1VXFlSzQ3K0dkUzFQSzVXZjV4dFdpcGMyOGYzUkxoL3JORUhF?= =?utf-8?Q?V6VtJSHbO0RInHxrQMhcTBtMx?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6d75c3c-2f1a-4fe1-731e-08dc030f1bc9 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2023 16:57:40.7333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /jARpak2RxcylIvzddn/H9oD85inHu/CP1GuyBbRh3aQY5+xEJs+xYosBEgMRqYx3AhwN9U7/pD0H6lfKBYpaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB5844 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-12-22 11:52, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> +/* See value.h. */ > Simon> + > Simon> +int > Simon> +value::regnum () > Simon> { > Simon> gdb_assert (m_lval == lval_register); > Simon> - return &m_location.reg.regnum; > Simon> + > Simon> + return m_location.reg.regnum; > > I wonder if this could just be inlined in the header. > > Tom Yes, I think it's a good candidate to be in the header, I'll do that. Simon