From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2086.outbound.protection.outlook.com [40.107.22.86]) by sourceware.org (Postfix) with ESMTPS id 4B964384AB7E for ; Fri, 19 Apr 2024 14:32:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B964384AB7E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B964384AB7E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.86 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1713537122; cv=pass; b=QcynbuNRrQjP21rOtCe4RqrA+BdsDOex0l5+C/A7QqUgtABPQ9dp5c9CiaJS3I3psn2VHvQxGWdPmt6KtuIwyHg2aEu0d5sinr+LI3g5VMvdvkBjE3X9IKy9NPnHSwJBNIfCUkmY+d3/hajupqFzGWe3/mlgLoZR391apAPZP9I= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1713537122; c=relaxed/simple; bh=xUgj0vI4+N6ETLk735AwLjf50NR8kn980LOqBW7ohVs=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=uZ859Gnc4JF3SnKeOo5MYpGlYyCglhnpqD6ZwoGa4BICKNbnWcv7qjM50V+iUeaGTVbO9+j+jQ2EPaux/RnNUqUyMxdBJw8T5WSzMxsyOP+q4Y/ymVDV8KvA3jpmDpsBu2DxtfYr0l04lMSyf5wP5dnwNpBfmQlSehFg99oJUMc= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lX0sBlQlxd5M6ApmyHDCUNZ3Y7998wXbEpeCyVIZ5PrmwTr87lNjy5cHXCUbLQDB5zeLCYvACJ/irWSE3g+qIoDhF6uc/IIWrV6oGJDPmDbhTDytt8ZThgvYKQDkEU00dTd69vriNMbOKzeHsBnbl5MRci3C2vicyBzWb+ZlS83EOW0R9Ux1kx95yKBRrQ4EW4uhb8IU4O0DPBu1MvR+L7GgJDrl80NKJoprj5hkxP2hIXs6s/i4qOULACxgbyiHxzqfHwemDZNrVvb9fbCKXqh/ZFCGYSojCiCWiM09/n4p37LIROhA+DL6d7Jfv+FoKIIi0Wx1BbNHoNDG/4cr1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kj/Jd4QSfK383Szb0haHLdi/NRpbpdjIYMdHuNoxPcw=; b=J03uW+EP1ofNA1WHKC3M1GfyeKnrZW8uh4wy3ExMxntssy+7DE2g2e56BpHFuvQR+VBIKqhX/HVG0VluztXzMdkUD/JD0nr6EzzCE+SuMtQUqXqyOSXD6QNzyzt4IIvyhISorfwn5KQPO9yS2065SG/DnEi8rdWZj+WGc7zAKjY/8tJh+8LrErwEaAR2OCWo56QF/iw8NctJ+9PzHDILwdMKWNQewtlNZLiG+K8/1uIUxtFrQ+qDc+KB4sCQ6g/x+dEX7Ck3SGWw6qWHEuoiQ3v/IBp4fYHyPcpjAF98EXFSifmNFgfoSLBoV6F3wl5nEbpxiQsy6W8U/jwzBwOwLg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kj/Jd4QSfK383Szb0haHLdi/NRpbpdjIYMdHuNoxPcw=; b=ap26KFRkjmqcF7rb+92FMchYoNZAr/cGYw1ahZhQPDgIcLGRyDhwyyrnL7fL/61+S52RQujPYULV1lWLDg3VL8vHKiraFjjBoggoN/OM9y4QhXsDpcnVoqQT6W9gIAK4gU4PiZ6BoJE5fnq6ePPNdRJ2vOW4K+J7qJoJc0Y7sK0= Received: from DU2PR04CA0217.eurprd04.prod.outlook.com (2603:10a6:10:2b1::12) by DU0PR08MB9485.eurprd08.prod.outlook.com (2603:10a6:10:42e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.37; Fri, 19 Apr 2024 14:31:55 +0000 Received: from DB1PEPF000509F4.eurprd02.prod.outlook.com (2603:10a6:10:2b1:cafe::9b) by DU2PR04CA0217.outlook.office365.com (2603:10a6:10:2b1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.30 via Frontend Transport; Fri, 19 Apr 2024 14:31:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB1PEPF000509F4.mail.protection.outlook.com (10.167.242.150) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Fri, 19 Apr 2024 14:31:55 +0000 Received: ("Tessian outbound 01a47eb2eb85:v313"); Fri, 19 Apr 2024 14:31:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 88e5351285bc3d48 X-CR-MTA-TID: 64aa7808 Received: from b94f26c172ca.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AF3395D6-1929-4EDF-99C7-5FD08E6A3A5E.1; Fri, 19 Apr 2024 14:31:49 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b94f26c172ca.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 19 Apr 2024 14:31:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fs3l+KvSrXMNAjo9xhg54kzxz/xTIQ7MxbjNJPmWkkQY7PC3M+nlPoC/rCK2PCDBdLk5KuFdaYq0WMD+h7iV+wpHfBSnx+FQGssOZNzGtMPAXeHfRhuziuUAPC0wdDBI+R/qvBK4wDLqwj7O7CUrXOIevfHxG+RB5Ty0+5iDGYUcaSoAxNZc+ehefnZpdkn9TjoonL/JqrZtoECn/xbwfUpr7509VPhHWo2UR+oTSbnx98AY0Ls/0Vg62h5Agc85KJfPk/7nVYpOOFZPsnvuK3bH9S5QOIsHbrYn/hGHLuXXRzMl6rxh7anf0/mBd5pPhMCX6H20nMC6+mpE/N9PYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kj/Jd4QSfK383Szb0haHLdi/NRpbpdjIYMdHuNoxPcw=; b=g5zOPYhWbJY23KDg8BxfdjGv+L6JVT9gZDxUBOEboBAxIJQkzbuAfdr2rIIXmYZLeCgXyCQO8jEFnMfBKO0p4GLfr7+plHFienKNGwO4A8jgTQQR385Ws2TaNtb5G0+QwCYe1utbHrMkQR6/bT5zX0ITar7IM6UI9Ls58fTkmIjudidODuKDyFydKQEJwHgKh/aYObbmzDebfW8HcvTfXxWH3uGsZMb/fg5L4uHQc0XxjjCEAW2qjSMiWxZ3Bp1oSZajP3RmQFMe54K4b091T7gKPVS12tGnD3VkadKDo97poQm2HFjTlYDGXZEdNPhPyR3B5CGccz/a0IaMp+D+FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kj/Jd4QSfK383Szb0haHLdi/NRpbpdjIYMdHuNoxPcw=; b=ap26KFRkjmqcF7rb+92FMchYoNZAr/cGYw1ahZhQPDgIcLGRyDhwyyrnL7fL/61+S52RQujPYULV1lWLDg3VL8vHKiraFjjBoggoN/OM9y4QhXsDpcnVoqQT6W9gIAK4gU4PiZ6BoJE5fnq6ePPNdRJ2vOW4K+J7qJoJc0Y7sK0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM8PR08MB6628.eurprd08.prod.outlook.com (2603:10a6:20b:362::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.43; Fri, 19 Apr 2024 14:31:47 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472%4]) with mapi id 15.20.7472.037; Fri, 19 Apr 2024 14:31:47 +0000 Message-ID: <9aa15f06-97ee-4273-ae03-28c930c5a246@arm.com> Date: Fri, 19 Apr 2024 15:31:39 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 7/8] gdb/testsuite: Add unit tests for qIsAddressTagged packet Content-Language: en-US To: Gustavo Romero , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org, eliz@gnu.org, tom@tromey.com References: <20240418201039.236867-1-gustavo.romero@linaro.org> <20240418201039.236867-8-gustavo.romero@linaro.org> <787f69b7-9aa7-4287-8f8d-1ea571a403c2@arm.com> <4693ce98-b5d5-bf2c-fd09-1ff97fd07092@linaro.org> From: Luis Machado In-Reply-To: <4693ce98-b5d5-bf2c-fd09-1ff97fd07092@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA1PR05CA0022.namprd05.prod.outlook.com (2603:10b6:806:2d2::28) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AM8PR08MB6628:EE_|DB1PEPF000509F4:EE_|DU0PR08MB9485:EE_ X-MS-Office365-Filtering-Correlation-Id: d97f66f6-461c-4d21-a198-08dc607d767e x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: g1Gp6OcouK9w7Hqq+qOYJrUzcpBGKB/2mzSNGNkmhNh2CoMbqa5x0qAbW685B3x7fxMjfS7gQA66NpmNbreX7KxR4+d2vBMSPVVF9f0Vxmc9/xDAnAl7NBiwge3lzBwcuo6eVYJ6s63BhydWIgNa7o20i57jT6EzxwA36DW9za1roFw1MH92U8CztiQaP4AbDTb0GdugCwSQIVvLwW8GKbXE98604JVbdamX7c50Z0RPhsqvu5k4AjYKYM8+Mu+De0kXR3Rmq4MXtRJM5OfP+WFylPfE7lM65SZbOff72A4vPEQtU4LqUjVExixczFnL5IYbUvSqz4/OeiiYNF7IcJiJiJA1TjhZeLgopAlw4rwSrbSJKnbsEkCqhxA3OZm4ZmUA17nfXAyMa0v5s8y6PujU7KaG6tg2WzlWP3f0rr/tLtU1u5yxrAI0QJTQrvuPsA/eCl0z8bvT3JQIP3jCrqWV7Hq7FeQgYIdT+Y8h00L/QEskXO+hYG2CTyVG65GkvKegmWQdAIW+8sJ5uw3lH/Ub/g1qjricqdzSG5hqnW13CDZe9sIcmYaTcK+rBsXz0hpbmdcVLEyPSt8FW+4B3c+rvcpyfoUml7ZZsHVL818iuJMFXkGnY86wTp8Xg2kyz4jVcBkiRlUnJcyFPkWP0jpB05iIZKppZtxv+gcXB00= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6628 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB1PEPF000509F4.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 054ae9bb-366b-4c4c-751f-08dc607d7156 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YDreZexL1dMOsq9HmtZ5sCUv1Pjmw4T2oRTK/7CxiFVIPlu9eFH3kTniBhPoat+oxCNDbEMvVG4m/8kWO8TYN4QwFAMh5DV/ul7o6phgEkywa1mu16XXzfi4of27+CuA71wXqpvRwzYRa6J+qY8+0peN4ODT7hePHlGvdBMvrMDEvWI3Dgq8fPLnt2S9fvt5gpJ0pROm8dYE0AdOYJ7N0LyFYvSkUAZOtGhjHFDXA4j90hNGMTK4eN7RzeHjK4hRP9O+CBw08U87qmML+6EnqUQztNFGhuq8p8xs0bkHJXqtq1aK9K5MVdOGSAaYwc7BBKTDZ2QIQY1OJaOUsetvu+0lpb/QR9kpM3dfYBdkWtP6WSfInlGjmHsfPhPkpSRJBK68zx3imE+8IIHvwG60ofLGoMORXlA6pNmRRuS+74bcSVhAcGKZgd+4nSbm4SDg/LBuCQHzZsCR8YwyR0nSkS54m2QJAfYntfCGDFLqwsRXSYVMARGzxPZ/zQnsOxVbVrjplyEjBtDatgzyC42FgCHB+GVAaRgAXHFClEjgdD+QYmNH+K0OUy9pRNRYy5NjrW1IRlm+V2IcNctP2FuZS81sV9c1NBQ20vLp9BcP+xE+3Ix4jgxO+m8zzAyRrAX/Y2ltIIM4YGBQ52tkkAZwuMVpetfsWJIi1GHV9cdxHd+4lf2yNSbTYBBaT76F8+pRUX5mBZqjljcniRRLSIcMF9TD6tFstPjo0nQ3XytsQKZJKNwjvxX01y35UM7mumbi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(36860700004)(82310400014)(376005)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2024 14:31:55.4800 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d97f66f6-461c-4d21-a198-08dc607d767e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509F4.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9485 X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/19/24 15:00, Gustavo Romero wrote: > Hi Luis, Thiago, Eli, and Tom, > > On 4/19/24 4:53 AM, Luis Machado wrote: >> On 4/18/24 21:10, Gustavo Romero wrote: >>> Add unit tests for testing qIsAddressTagged packet request creation and >>> reply checks. >>> >>> Signed-off-by: Gustavo Romero >>> --- >>>   gdb/remote.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>   1 file changed, 67 insertions(+) >>> >>> diff --git a/gdb/remote.c b/gdb/remote.c >>> index 3d034bb1ef8..cfb54de157d 100644 >>> --- a/gdb/remote.c >>> +++ b/gdb/remote.c >>> @@ -15682,6 +15682,8 @@ test_memory_tagging_functions () >>>     scoped_restore restore_memtag_support_ >>>       = make_scoped_restore (&config->support); >>>   +  struct gdbarch *gdbarch = current_inferior ()->arch (); >>> + >>>     /* Test memory tagging packet support.  */ >>>     config->support = PACKET_SUPPORT_UNKNOWN; >>>     SELF_CHECK (remote.supports_memory_tagging () == false); >>> @@ -15748,6 +15750,71 @@ test_memory_tagging_functions () >>>     create_store_memtags_request (packet, 0xdeadbeef, 255, 1, tags); >>>     SELF_CHECK (memcmp (packet.data (), expected.c_str (), >>>                 expected.length ()) == 0); >>> + >>> +  /* Test creating a qIsAddressTagged request.  */ >>> +  expected = "qIsAddressTagged:deadbeef"; >>> +  create_is_address_tagged_request (gdbarch, packet, 0xdeadbeef); >>> +  SELF_CHECK (strcmp (packet.data (), expected.c_str ()) == 0); >>> + >>> +  /* Test error reply on qIsAddressTagged request.  */ >>> +  reply = "E00"; >>> +  strcpy (packet.data (), reply.c_str ()); >>> +  /* is_tagged must not change, hence it's tested too.  */ >>> +  bool is_tagged = false; >>> +  SELF_CHECK (check_is_address_tagged_reply (&remote, packet, is_tagged) == >>> +          false); >>> +  SELF_CHECK (is_tagged == false); >>> + >>> +  /* Test 'tagged' as reply.  */ >>> +  reply = "01"; >>> +  strcpy (packet.data (), reply.c_str ()); >>> +  /* Because the byte is 01, is_tagged should be set to true.  */ >>> +  is_tagged = false; >>> +  SELF_CHECK (check_is_address_tagged_reply (&remote, packet, is_tagged) == >>> +          true); >>> +  SELF_CHECK (is_tagged == true); >>> + >>> +  /* Test 'not tagged' as reply.  */ >>> +  reply = "00"; >>> +  strcpy (packet.data (), reply.c_str ()); >>> +  /* Because the byte is 00, is_tagged should be set to false.  */ >>> +  is_tagged = true; >>> +  SELF_CHECK (check_is_address_tagged_reply (&remote, packet, is_tagged) == >>> +          true); >>> +  SELF_CHECK (is_tagged == false); >>> + >>> +  /* Test an invalid reply (neither 00 nor 01).  */ >>> +  reply = "04"; >>> +  strcpy (packet.data (), reply.c_str ()); >>> +  /* Because the byte is invalid is_tagged must not change.  */ >>> +  is_tagged = false; >>> +  SELF_CHECK (check_is_address_tagged_reply (&remote, packet, is_tagged) == >>> +          false); >>> +  SELF_CHECK (is_tagged == false); >>> + >>> +  /* Test malformed reply of incorrect length.  */ >>> +  reply = "0104A590001234006"; >>> +  strcpy (packet.data (), reply.c_str ()); >>> +  /* Because this is a malformed reply is_tagged must not change.  */ >>> +  is_tagged = false; >>> +  SELF_CHECK (check_is_address_tagged_reply (&remote, packet, is_tagged) == >>> +          false); >>> +  SELF_CHECK (is_tagged == false); >>> + >>> +  /* Test empty reply.  */ >>> +  reply = ""; >>> +  strcpy (packet.data (), reply.c_str ()); >>> +  /* is_tagged must not change, hence it's tested too.  */ >>> +  is_tagged = true; >>> +  /* On the previous tests, qIsAddressTagged packet was auto detected and set >>> +     as supported.  But an empty reply means the packet is unsupported, so for >>> +     testing the empty reply the support is reset to unknown state, otherwise >>> +     packet_ok will complain.   */ >>> +  remote.m_features.m_protocol_packets[PACKET_qIsAddressTagged].support = >>> +    PACKET_SUPPORT_UNKNOWN; >>> +  SELF_CHECK (check_is_address_tagged_reply (&remote, packet, is_tagged) == >>> +          false); >>> +  SELF_CHECK (is_tagged == true); >>>   } >>>     static void >> >> This is OK. Thanks for the series. >> >> Let us know if you need us to push it for you. >> >> Approved-By: Luis Machado >> Tested-By: Luis Machado > > Thanks a lot for all the reviews! > > Yip, I need somebody to push the patchset. :-) > > > Cheers, > Gustavo Pushed now.