From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: [PATCH] [gdb/cli] Add command: show logging active
Date: Tue, 23 Nov 2021 12:49:34 +0100 [thread overview]
Message-ID: <9ab6df29-2990-704c-ea96-6af09d2e9a1e@suse.de> (raw)
In-Reply-To: <20211123114603.6284-1-tdevries@suse.de>
[was: [pushed] [gdb/cli] Add command: show logging active ]
Sorry, this has not been pushed yet, correcting $subject to request review.
Thanks,
- Tom
On 11/23/21 12:46 PM, Tom de Vries via Gdb-patches wrote:
> Currently, there's no gdb command that shows whether logging is enabled or
> disabled.
>
> There's the show logging command, but output is identical in both cases.
> With logging disabled, we have:
> ...
> (gdb) set logging off
> (gdb) show logging
> logging debugredirect: The logging output mode is off.
> logging file: The current logfile is "gdb.txt".
> logging overwrite: \
> Whether logging overwrites or appends to the log file is off.
> logging redirect: The logging output mode is off.
> ...
> and with logging enabled we have:
> ...
> (gdb) set logging on
> Copying output to gdb.txt.
> Copying debug output to gdb.txt.
> (gdb) show logging
> logging debugredirect: The logging output mode is off.
> logging file: The current logfile is "gdb.txt".
> logging overwrite: \
> Whether logging overwrites or appends to the log file is off.
> logging redirect: The logging output mode is off.
> ...
>
> Add a "show logging active" command, such that we have:
> ...
> (gdb) show logging
> logging active: Logging is disabled.
> logging debugredirect: The logging output mode is off.
> logging file: The current logfile is "gdb.txt".
> logging overwrite: \
> Whether logging overwrites or appends to the log file is off.
> logging redirect: The logging output mode is off.
> ...
>
> Mention the new command in NEWS and docs.
>
> Tested on x86_64-linux.
> ---
> gdb/NEWS | 5 +++++
> gdb/cli/cli-logging.c | 13 +++++++++++++
> gdb/doc/gdb.texinfo | 2 ++
> 3 files changed, 20 insertions(+)
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 9e950d2f80d..253070a2a57 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -32,6 +32,11 @@ maint show internal-warning backtrace
> internal-error, or an internal-warning. This is on by default for
> internal-error and off by default for internal-warning.
>
> +show logging active
> + This command shows whether logging is enabled or disabled. Whether logging
> + is enabled or disabled is controlled by pre-existing command
> + "set logging [on|off]".
> +
> * Python API
>
> ** New function gdb.add_history(), which takes a gdb.Value object
> diff --git a/gdb/cli/cli-logging.c b/gdb/cli/cli-logging.c
> index f0ee09180f9..081afcc4ca2 100644
> --- a/gdb/cli/cli-logging.c
> +++ b/gdb/cli/cli-logging.c
> @@ -163,6 +163,17 @@ set_logging_off (const char *args, int from_tty)
> saved_filename = NULL;
> }
>
> +/* Show the status set by set_logging_on / set_logging_off. */
> +
> +static void
> +show_logging_on_off (const char *args, int from_tty)
> +{
> + if (saved_filename)
> + printf_unfiltered (_("Logging is enabled.\n"));
> + else
> + printf_unfiltered (_("Logging is disabled.\n"));
> +}
> +
> void _initialize_cli_logging ();
> void
> _initialize_cli_logging ()
> @@ -211,4 +222,6 @@ The logfile is used when directing GDB's output."),
> _("Enable logging."), &set_logging_cmdlist);
> add_cmd ("off", class_support, set_logging_off,
> _("Disable logging."), &set_logging_cmdlist);
> + add_cmd ("active", class_support, show_logging_on_off,
> + _("Show whether logging is active."), &show_logging_cmdlist);
> }
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 1b13973cdc5..4bea8f9b3dc 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -1723,6 +1723,8 @@ Set @code{redirect} if you want output to go only to the log file.
> By default, @value{GDBN} debug output will go to both the terminal and the logfile.
> Set @code{debugredirect} if you want debug output to go only to the log file.
> @kindex show logging
> +@item show logging [active|file|overwrite|redirect|debugredirect]
> +Show the current value of the logging setting.
> @item show logging
> Show the current values of the logging settings.
> @end table
>
> base-commit: 0c3e266dc283a45a23185be3bb49e4d33987a892
>
next prev parent reply other threads:[~2021-11-23 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 11:46 [pushed] " Tom de Vries
2021-11-23 11:49 ` Tom de Vries [this message]
2021-11-23 12:30 ` [PATCH] " Lancelot SIX
2021-11-24 10:31 ` Tom de Vries
2021-11-23 13:00 ` Eli Zaretskii
2021-11-24 10:41 ` Tom de Vries
2021-11-24 13:03 ` Eli Zaretskii
2021-11-23 13:30 ` Simon Marchi
2021-11-24 11:06 ` Tom de Vries
2021-11-23 12:49 ` [pushed] " Luis Machado
2021-11-23 12:56 ` Luis Machado
2021-11-24 10:32 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ab6df29-2990-704c-ea96-6af09d2e9a1e@suse.de \
--to=tdevries@suse.de \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).