From: Simon Marchi <simark@simark.ca>
To: Kamil Rytarowski <n54@gmx.com>, gdb-patches@sourceware.org
Cc: tom@tromey.com
Subject: Re: [PATCH v3] Implement "info proc mappings" for NetBSD
Date: Sat, 11 Apr 2020 17:53:46 -0400 [thread overview]
Message-ID: <9abfc854-16fd-247a-f3a6-edd69c03ed5b@simark.ca> (raw)
In-Reply-To: <154c0a3c-b59e-1e9b-504e-27bd7e47b2a6@gmx.com>
On 2020-04-11 5:28 p.m., Kamil Rytarowski wrote:
> On 11.04.2020 23:05, Simon Marchi wrote:
>> On 2020-04-06 5:37 a.m., Kamil Rytarowski wrote:
>>> @@ -39,3 +42,148 @@ nbsd_nat_target::pid_to_exec_file (int pid)
>>> return NULL;
>>> return buf;
>>> }
>>> +
>>> +/* Retrieve all the memory regions in the specified process. */
>>> +
>>> +static gdb::unique_xmalloc_ptr<struct kinfo_vmentry[]>
>>> +nbsd_kinfo_get_vmmap (pid_t pid, size_t *size)
>>> +{
>>> + int mib[5] = {CTL_VM, VM_PROC, VM_PROC_MAP, pid,
>>> + sizeof (struct kinfo_vmentry)};
>>> +
>>> + size_t length = 0;
>>> + if (sysctl (mib, ARRAY_SIZE (mib), NULL, &length, NULL, 0))
>>> + {
>>> + *size = 0;
>>> + return NULL;
>>> + }
>>> +
>>> + /* Prereserve more space. */
>>> + length = length * 5 / 3;
>>
>> Why is this needed?
>>
>
> This length is volatile and can be larger on the 2nd sysctl(3) call. We
> can call this function against a running process that can enlarge its
> usage of address space in this time window.
Ok, then please make the comment explain that. We can see that the expression
increases length, but as a reader I have no idea why.
Simon
next prev parent reply other threads:[~2020-04-11 21:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 17:34 [PATCH] " Kamil Rytarowski
2020-03-19 13:07 ` Kamil Rytarowski
2020-03-20 15:36 ` Tom Tromey
2020-03-20 16:58 ` Kamil Rytarowski
2020-03-20 18:50 ` Tom Tromey
2020-03-20 19:13 ` Kamil Rytarowski
2020-03-25 16:36 ` John Baldwin
2020-03-26 23:24 ` Kamil Rytarowski
2020-03-20 16:58 ` [PATCH v2] " Kamil Rytarowski
2020-04-02 20:09 ` Kamil Rytarowski
2020-04-03 1:12 ` Kamil Rytarowski
2020-04-06 9:37 ` [PATCH v3] " Kamil Rytarowski
2020-04-10 10:20 ` Kamil Rytarowski
2020-04-11 21:05 ` Simon Marchi
2020-04-11 21:28 ` Kamil Rytarowski
2020-04-11 21:53 ` Simon Marchi [this message]
2020-04-11 23:45 ` [PATCH v4] " Kamil Rytarowski
2020-04-11 23:49 ` Simon Marchi
2020-04-12 0:09 ` Kamil Rytarowski
2020-04-12 0:09 ` [PATCH v5] " Kamil Rytarowski
2020-04-12 0:56 ` Simon Marchi
2020-04-12 10:17 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9abfc854-16fd-247a-f3a6-edd69c03ed5b@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).