From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 366073858C31 for ; Wed, 29 Nov 2023 12:09:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 366073858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 366073858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701259750; cv=none; b=JEliTxndA3FyywnbDH7idJhMgKs1DWhLG/QKNRtaUyfOiWzESKI4ms93mdlIli5iYTPx1OtrchgdgqJS9r5ocm/pWKOcbo/OACvUYoQVzxucN6adHb2VjyncAs9XIL29jvZuiZcwDfpfAXEie+5jSRfZUG1CczrLTOKuP3ABYNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701259750; c=relaxed/simple; bh=get9SCvUwZ72jVH1+yLgiLrsx7LA8VwW4kbnW+om8xk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Jg55+mCpJ84tp271FfJmXPxcHmVb9tzOgvdDMP0sN+Gj1b0QESHOfNylupdrMKktB8bMbDSUEk+1bhGQmzq5SnCKSI8dr3/9XM2Qgt/AYDW5IFMwf3CceGSqW2Ci/DXGRZ4/EgN3JAXoHmJKsMs+Yw91T6ppeTLA4c7XQ2fkRLo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701259748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BPCtHlpMcb82yAABVTZtdnZNhBrzZXR/PHQ5QqScX1s=; b=JSoY4+rQunI0lo8FcIHr4E7sPDsV3rVSvuHbS79Ug4W87WIpzg9zOZ6n9WNErL2XdOHoSJ wj+4A4l4oMnAYPb7Qz9G2F3WLWQNNlKeGKU6mUfb13i4lDEh8XQMX8BHq5xITOYNWrQK6Q 9Dc3GHftYZ2cOzwDO0+/bkevHlvhO+8= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-Q0Vw992-MjWL6Sj695zlVA-1; Wed, 29 Nov 2023 07:09:07 -0500 X-MC-Unique: Q0Vw992-MjWL6Sj695zlVA-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c9bda6c6e8so6981831fa.1 for ; Wed, 29 Nov 2023 04:09:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701259746; x=1701864546; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BPCtHlpMcb82yAABVTZtdnZNhBrzZXR/PHQ5QqScX1s=; b=hknInbK4VyLe1Ndiz9cAGjY3OHUDXOToJk4GHp8q0Ef7mEcUaFOPbv0oFfjK5umWLD AAffp5pH6OUIA4tiEUHuRLkTzCt9O8k7lE6GHOQQudsiINxjIxWSVPjAeqjZejwdTolk 7uBCg1rj/8vLCG//tc1Cw7t3ILvBkHdpfGO9s2amCju49+jBeJ7WAwCDP/tUoq9TXCD4 jFmTWG1Au0Fps9rtBiEfKTYhU6IjkMglfUnHEoJPyIwzHBK3vmUIiw6Y/Nv9zWfAp8yi ckJVG/vPMqd2EjHkCmdvMUDi+Bs4IFbmskxicni31HjWl1zNjc5Ulrr7U49Ai9HbjzBS fB9w== X-Gm-Message-State: AOJu0Yy7kr9XBZnCK0QC3Y2j8RTHbEHguAaUY7pCJBiOFCQeX5qN0lYb I6INyiKm6zLj+Lts3q6t1zKyEH4ZgGIctvOuhWETYeG695WgDNZ+Xgt69jxBevGqF+fweSqB+I8 Y/GFTnIEljBZgLkPoB//VGA== X-Received: by 2002:ac2:5d63:0:b0:507:a6e9:fbba with SMTP id h3-20020ac25d63000000b00507a6e9fbbamr10328821lft.63.1701259746191; Wed, 29 Nov 2023 04:09:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEZqybDGEJ5z+PaK4YXltMxzwCFNAlKyS9Ma6b0StVqMcd+hAgiQwaRCdD47/bApTloQcJLsw== X-Received: by 2002:ac2:5d63:0:b0:507:a6e9:fbba with SMTP id h3-20020ac25d63000000b00507a6e9fbbamr10328814lft.63.1701259745807; Wed, 29 Nov 2023 04:09:05 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id b14-20020aa7dc0e000000b00548a258227asm7320898edu.30.2023.11.29.04.09.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Nov 2023 04:09:05 -0800 (PST) Message-ID: <9ac657d6-db77-376d-68fd-592d57e9bbc8@redhat.com> Date: Wed, 29 Nov 2023 13:09:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4 0/2] Improving frame printing with recursive calls To: Luis Machado , Tom Tromey Cc: gdb-patches@sourceware.org References: <20231107124150.116140-2-blarsen@redhat.com> <871qcola1j.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29/11/2023 12:42, Luis Machado wrote: > On 11/20/23 09:54, Guinevere Larsen wrote: >> On 17/11/2023 15:38, Tom Tromey wrote: >>>>>>>> "Guinevere" == Guinevere Larsen writes: >>> Guinevere> This started with the first patch, just fixing PR record/29178. However, >>> Guinevere> Kevin pointed out that I could reuse some of the local variables to make >>> Guinevere> the function as a whole simpler, which I did on patch 2. >>> Guinevere> My changes on v3 introduced a regression in a dwarf2 test. I gave some >>> Guinevere> time for people to comment on Kevin's solution (then forgot about this >>> Guinevere> patch), but since no one disagreed, this new version changes thetest, >>> Guinevere> rather than the code. >>> >>> These look reasonable to me.  Thank you. >>> Approved-By: Tom Tromey >>> >> Thanks, I pushed these! >> > Sorry I'm late to the party, but looks like this regresses reverse debugging. I was just > testing Carl's patches for step/next reverse fixes, and I notice a few new FAIL's that > were not related to the fixes by Carl. > > I don't see a problem with aarch64-linux, but arm-linux seems to be affected. > > It was caught by the Linaro CI here: https://linaro.atlassian.net/browse/GNU-1026 > > Do you have any ideas on what's up? > I have no idea what's up. I'll take a look at it, thanks for bringing it up -- Cheers, Guinevere Larsen She/Her/Hers