From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=zvI1=3S=simark.ca=simark@sourceware.org>
Received: from simark.ca (simark.ca [158.69.221.121])
	by sourceware.org (Postfix) with ESMTPS id 48B4F3857C51
	for <gdb-patches@sourceware.org>; Fri, 18 Nov 2022 15:48:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48B4F3857C51
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca
Received: from [10.0.0.11] (unknown [217.28.27.60])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPSA id 4193C1E0CB;
	Fri, 18 Nov 2022 10:47:58 -0500 (EST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail;
	t=1668786479; bh=cuZUul4GU4oe5npOLbyEcpyH9WuT6+MCSAOV6xkv6Ko=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=lnsEuq43e2XZFXlQbva36fK2BtrcM5oiT9VG1enHGQL1p6ifms46iHjY7fspJqzEt
	 qqiH0+sDgMOEFSc1zcBkaaLTet0bZJ7UjXjLBv0f8FPIf7v3wfatPMWA6LocijuMaf
	 F+kq8E0Jc5EHlIao6zfsRkcWImMdnPPknq9VX8zc=
Message-ID: <9ae34eea-a4aa-1fe9-bf85-16fb1d7a0ba0@simark.ca>
Date: Fri, 18 Nov 2022 10:47:57 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] gdb: fix symtab.c build on 32 bit targets
Content-Language: en-US
To: Tom Tromey <tom@tromey.com>,
 Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>, ro@gcc.gnu.org
References: <20221117183226.1632406-1-simon.marchi@efficios.com>
 <87wn7sqnn4.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <87wn7sqnn4.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>



On 11/18/22 10:37, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> PR 29798 shows a similar error message but on Solaris.
> 
> It should say "PR build/29798" here, so the commit script can pick it
> up.

Fixed.

> 
> Simon> Work around that by using string_printf.  It is a good thing to get rid
> Simon> of the alloca anyway.
> 
> Indeed.  IMO alloca should be poisoned.
> The patch looks good to me.

Thanks, will push.

> 
> Simon> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29798
> 
> ... we should teach that commit script to pick this up.
> I don't know how to access it, though.

I will ask Joel.

Simon