From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2052.outbound.protection.outlook.com [40.107.116.52]) by sourceware.org (Postfix) with ESMTPS id DF6853858C54 for ; Tue, 17 Oct 2023 15:19:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF6853858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DF6853858C54 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.116.52 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697555972; cv=pass; b=oX6bEIbWvTN6tz4mYMizujHJJRS4SX1jCD7SdqjOQgKWfAP6SkHKbnePU2zMfCzn6zwAbRIG39C8dU+H+heGYuPxHiYJgYf8q9pj5H+sRjClJbMD00Q0gIcz6j+EL8B0jcgN/MWEvC5KIMFxCt3z5yQ7X5LnbZYutnPvieyGULY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697555972; c=relaxed/simple; bh=MMyKtFx30XmZDowtkfaA6dVxWcCTlPMPDkATR/ZQhD0=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=hXl+FpiDKqdaRBArwEz7rUsxw46qilmsTwvNBMC1fyZIy6i9ah8zNUh16YWAsFep+qZtC/mUr0bRfKf78OK7YrC4bxgC8gWOMDOiiqs3TSrxRG3kRB7rw5glxo9h4zrr6UO3fTXvdv8+KM2KUe1oJdoYEGUxafSkbip5C025tOs= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ANTx23q7er6TGphWdcK+gj9uSmV38BjlDo8j2D53OW2OZ/vKb8iYCH17D1kdxkrv9qLzLmFAm+17fbMmP7y1XVbRXsdLrq/9ua36MybBFPk2QseihlrNYEXHKVaTIc463yObk/NbzwE4+g77VhkDrC24q2C4GbYinHxJRRIWbNouZnGejVm+Hn0VsGo9u351U+l98HbOKcGsNkVF/d2bAoDlFw8F6RmYyn2gcFneSpLY7Smbg6Zk/okJUei9xuWQFTU3EwHwgKm+dBpb47MHNOgTtz8Jiw2mPuFP72UedXkKLSHbEoDo4xeWdHI4nO9pqAdgFxbdhbgBJPiacVih4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T6o7iB9dMgCXU9L19VX4SM1Zd5JLnnQSuW7CCHsPXgQ=; b=M1Z6uT5+7o92i9ohfRUrXcnAzxONswQi1yV9u1D6+09STnL0ubO31YSxBBR+BdCvGyiBIr6L6+PLVWJeBUZLHcjWaNZsw3apZAJ12xvsms7iKWQwTdRLpka3tFy4sBAjDH1nnDuMZsF7PsMeFgxuJuP2al/dzZ98EUXmDWYBpagatAL0pCggTxqwu+GU2QAHxY5iJanPsQHiLjxco6lNrPLFPWcB1AVsai39FIUMqEL6Zmo5bdSgzPOZWL+YHlBX6PSdjly/rz/Lh7Agdwz51/nG8Oc5AgRnaeOQC4JRzciWIE/8hmFjo8lfMyD7EyMaEpu/0+50ojhIfywj1kAsEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T6o7iB9dMgCXU9L19VX4SM1Zd5JLnnQSuW7CCHsPXgQ=; b=GVA0cdP/z/B23WiTaEvGqaO4+iczKZccI8z9o2ODCPc6MM/a/+RvvRr66+zodue04ycbu0IVU96PfRHsog5CSNKPbuJQ6RsPGK6/hGhr19WtSz9EMwCD7LB4BWzQcJZfowkn6ybDt9GYe5Dkx2fdD/ysHe3O/yLIuMpgMYFqGUvO6Is04mfVMdMerPJT7BhZ189dswrvKUisufXe7owq/vb6T0fq7kbkat70p+hp+pHMARKuSzBG+oLvNekedjFAM72UcHfJQ9srnZqQEbHyKAoCnvYZgRzaa7mLgyRMGdy783Hpzdd/7sbOlHzpWHuaZ7dR6PFXvEt56BorM3K+Rw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB6501.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:70::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 15:19:29 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%7]) with mapi id 15.20.6907.021; Tue, 17 Oct 2023 15:19:28 +0000 Message-ID: <9ae53e4c-e0b1-4875-8dcf-189f304299f1@efficios.com> Date: Tue, 17 Oct 2023 11:19:27 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/24] gdb: add program_space parameter to target_so_ops::clear_solib Content-Language: fr To: Pedro Alves , gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-3-simon.marchi@efficios.com> <2cfcbc4c-4094-42e1-86c4-974ddcc88a28@palves.net> From: Simon Marchi In-Reply-To: <2cfcbc4c-4094-42e1-86c4-974ddcc88a28@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0019.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:85::18) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB6501:EE_ X-MS-Office365-Filtering-Correlation-Id: d3487691-1ddd-4f39-e7c9-08dbcf2474b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SPmX0cryuOed3mF85dUKmQq+dxZUiIoNPwDE+1xHeIGjcQFXKFOM94MWJeCsLvbyv1t1rI2w2SU2BnYzQT+fXvo/5ynSn06igZDwJwAh9Mchr9FSBxiqC6aTrxU8MN/ArO2KQ5d3bILLQ1n8y1MCYzROf5Vmc0UM1XEOSqN/irpADjpqSWpvIOs4cnhxHoERpQUiYEffsnZE3sNcDEkpwKG4zM+BWeBRZY1Z0g2ooQfS8JAMoAr7bjPuRuCiX9gHPL3DyvJqpJoUwUe/rODyxPl/y26DSM3sA/r3NmTeZ19p6bIaGMAI1eAtiEBm2LOxyNJyIpXkPeciLN2Ml/g1yYmV0xHmfuBP5gCibw30BCQLrG6HVJz+VSoxhTBIHeynAMD63cipRsd+XvblDLOzcO+sP15zdgUDwQx2Sgk8Mvy1rqPxhtpsMjuABiXbtAoZpXMU+bqYd6dY/w7Y0X3q+Xvx9I2ZfGvb8YoKCs42iUu4r/0TWRcusWvRl3uGclMfQr9TvlRsIL0eOsPeyawDL4IB0ATpmr+STaIq6O9j/B8QfeGbkgAKDvZs9cwvMMZRERXTEOwCLC4W07zk6F8pXxkTdRnornof20XmZfGIO0BDfqpPzXQ6zu0lQ2UDqW7oqzffDTLweypuKZ8TJPlvYw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(136003)(376002)(366004)(39830400003)(346002)(396003)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(31686004)(66946007)(478600001)(6486002)(66556008)(66476007)(316002)(31696002)(38100700002)(6512007)(26005)(53546011)(2616005)(6506007)(36756003)(41300700001)(4744005)(5660300002)(8936002)(8676002)(44832011)(2906002)(4001150100001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkZNTWdVbWlKUGpaWTdtRVU1cnhvS2t4WnVzSUR2OVI0NnRiak0xdms1ME5o?= =?utf-8?B?aUpWcWl3QVRTcWIzWkp4MVpIek1PYzl2NXNVOEw2bFFDdm9raTQyalkxbVB5?= =?utf-8?B?czBmNVJrWDlpbVcvaEJrTGdrclpzWk5lUjhPRjlLWitZRFU0cHRyQXV1aDYr?= =?utf-8?B?MElRR0J1ejc3R0JYVEh4Y1huY1F3UUZlNlIveDVWUnNPMVVBcHFlMHJPY2RZ?= =?utf-8?B?MjQ0dzZRVy9DWE94bG1BOUg3UGNrZUZ3TzI5UmNqb2djdTJ2YXJ4NGU0dVVk?= =?utf-8?B?QllGbnVKNzFIU1k2WnhkWTd1Z280MDZEbFVSU296YzBFT01abUdXMEgxYkNR?= =?utf-8?B?NE1XRzQzRmFuYjc3WTdMN1ZrbEJRUWpzTmsxWCtsdTBjMFlMSHlXRzdxSzY0?= =?utf-8?B?dFlXYVg2OWlOWGpPVUNHQ251VDFUUlRDMnVZMmRGRjNwaDg1Sy8xdXFzOUJz?= =?utf-8?B?empEOHJkaGlWUHJjTGFvQTRORzBHS2I2YXI5dUhiSEdlTkN5NDl2UTM0ck9G?= =?utf-8?B?L1dRcndHWlpFNnhtWXhEbk5BdEpQRkZsaVR4cWtvUnU1aGdRWGw3RCtQa0R3?= =?utf-8?B?RTFhS25sTC9VVDFBQVBqSzh2MGthcnBqMS91WjRtU3A5STlndkVlTXRtODVE?= =?utf-8?B?cUJQWDRKQXdYSWlKS1pVelpwUW1meWV4MXNod3VCU3hTc05QNjBsZTMrSDhH?= =?utf-8?B?cC9pQ0V1VTFkNFRySWpXdHUrZHNyMUt6SzNVa1RSc2liTUJQMFBPL1NsdFVv?= =?utf-8?B?RlJwY1YzcUc3NWd1NWRnT0lTak1HREx5dzhuM25QTStiRGZGa3BSNGltd2RT?= =?utf-8?B?Zm1jUVIya0R0QmJGREZ4SStITHFyeDUvem9FVkR6QmxUaVpJNEwxWml4VXpD?= =?utf-8?B?cWdKWGR1REhoZXE1Y0kxUThFS3JRWENPU24zeWJPTFBTOXA5U3U3ZmpGNEV5?= =?utf-8?B?cmhCUzRMd1BIQWtKMVpkbkpkZVUrU3Q5RkNJOURjb1UwQ1NXb0xkWjNyMzV0?= =?utf-8?B?Y05sRms5U3N0YmwvY3JxN3VPV0cvd3hrVWlYS3kwN0N3WllYMi9kaENadVBw?= =?utf-8?B?TS9MaVBQK2dGaDJpdm40Tm9RbFQyV2RTM3BBRTBaWTNBWU8ycE5DRmVSUGZG?= =?utf-8?B?Um80SHplVFNrUEVXM1UwMzdSRGNmem1Ham1GL3Y4N09wcENRd1dhbm5qRk1D?= =?utf-8?B?cnJiemFCQWdBcVBScWtncmh5ZTV6THAwdmpkWmxrdEhiTWgvWGZQUmFWYlM0?= =?utf-8?B?NFNXYW52OFpTUU9CL0ZlK2RkdFk3RnRrK21PRkwzRGo0OGhtRlV1aEdBb2xq?= =?utf-8?B?MDBuWCtBbHhEQk9pckM2R2xDNVNjNVkybDUvRmVUYTd2VEVYV2xHcmgyNGQ0?= =?utf-8?B?M3gvUXVTbEZjL0h0RG01MUdmTytJeUZNUlZyeVFwMTZaNEF0YzcwMStWMlIv?= =?utf-8?B?WXdzZmlqVlhrQVEzaUhqWUI4WG5PVFRNeFpienRHZEpwM0ZlZWVwdVR3MWZS?= =?utf-8?B?Rk5DWXNYWVRWMXQya00xYVBlQ1EraXVsLytQWi91NjVnVVNYalAzZGZjMFhK?= =?utf-8?B?RmhsZHU2aHVkczlsRk1CdExyR29jMXRBOUpJWkUxdmdMR1hUZXRkbE9wbGZO?= =?utf-8?B?Mnp0ZU4rQklDQVkzMVQ1V28rSEs0RlY5d3B5RERod0dFV3hyclYrYTlmcFZU?= =?utf-8?B?YjRMMDViWDNDNG9ac1czRjY0TW9CVEhPSVIxaFBOcmhNMjdVMytpSjZvZi9N?= =?utf-8?B?VGFhVVRSRytzd3JmN3FPK3Z2cUV6NWZRbThSTExDNFpMZFh5MjY4UG5FelV4?= =?utf-8?B?NkozM09zWlJhdEs3MG9yT0pxcnZYcGVFMjZvWjVRdDhpMkdaUS9nOG5ZL2FW?= =?utf-8?B?UFhhTnFTYngrS3lmTm5jbHdVT1BablF4M3lOQVNRR0RJd1Y4VGtZR0VPWlJE?= =?utf-8?B?cFBxZU91NXpadCtPbHJwTUdIOWIrUW40NHNSeTJObzZjNDhNcUV4eURPQ1hh?= =?utf-8?B?dW9pT2RTWVlNV3dYZEhwYkFQM29qMS9RN3hISWR3WXRxdllwSkQzVnJqdkpZ?= =?utf-8?B?T01RL1NYVTVwanhsSlJFVjFOUzdheUNDdkMvZUFLQVRaOXZabE9JcTBnaFlh?= =?utf-8?Q?QoLm9EDcP3rxNqqjk1dp2Ecdo?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3487691-1ddd-4f39-e7c9-08dbcf2474b4 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 15:19:28.8540 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nLWsOlo3fFL+Badzf79I7eCo7RZgo2aOxrNO277OixoCs6noOqXAMmcXhqn+Zq0g0dbUJP0fRfB8vNC3YCqC5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB6501 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/17/23 10:57, Pedro Alves wrote: > Just a tiny nit. > > On 2023-10-10 21:39, Simon Marchi wrote: > >> diff --git a/gdb/solib-darwin.c b/gdb/solib-darwin.c >> index 98c81bb3bdaa..4796315c373a 100644 >> --- a/gdb/solib-darwin.c >> +++ b/gdb/solib-darwin.c >> @@ -78,16 +78,14 @@ static const registry::key >> /* Get the current darwin data. If none is found yet, add it now. This > > I guess "current darwin data" -> "darwin data for PSPACE" ? > >> function always returns a valid object. */ >> >> -static struct darwin_info * >> -get_darwin_info (void) >> +static darwin_info * >> +get_darwin_info (program_space *pspace) >> { > > >> --- a/gdb/solib-dsbt.c >> +++ b/gdb/solib-dsbt.c >> @@ -169,16 +169,14 @@ static const registry::key solib_dsbt_pspace_data; >> /* Get the current dsbt data. If none is found yet, add it now. This > > Ditto "current" here. Thanks, fixed both locally. Simon