From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id A3976386549C for ; Thu, 21 Apr 2022 15:05:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3976386549C Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23LELXTQ026364 for ; Thu, 21 Apr 2022 15:05:07 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fhyqeq4dx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 21 Apr 2022 15:05:07 +0000 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 23LEUAHp009843 for ; Thu, 21 Apr 2022 15:05:06 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fhyqeq4dj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Apr 2022 15:05:06 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23LF1Jma027930; Thu, 21 Apr 2022 15:05:05 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma01dal.us.ibm.com with ESMTP id 3ffneb5k3r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Apr 2022 15:05:05 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23LF54ue34275754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Apr 2022 15:05:04 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A9F9678072; Thu, 21 Apr 2022 15:05:04 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1982E78069; Thu, 21 Apr 2022 15:05:04 +0000 (GMT) Received: from lexx (unknown [9.160.122.108]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 21 Apr 2022 15:05:03 +0000 (GMT) Message-ID: <9ae565aae4c412d51d6ad3e7158eab443df8febf.camel@vnet.ibm.com> Subject: Re: [PATCH] Fix for gdb.base/solib-search.exp test. From: will schmidt To: Carl Love , dje@google.com, gdb-patches@sourceware.org Cc: Rogerio Alves Date: Thu, 21 Apr 2022 10:05:03 -0500 In-Reply-To: <8fe6f3bee129c0a3159d3ef57c942b9473255d8d.camel@us.ibm.com> References: <8fe6f3bee129c0a3159d3ef57c942b9473255d8d.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 9eZwQ7Ukq2pbjsMf4SPON1tIbNjT016H X-Proofpoint-ORIG-GUID: JDEuc6kxaDmTTsuk-OINuOcvdvYeZ5hv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-21_02,2022-04-21_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 impostorscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204210078 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2022 15:05:10 -0000 On Tue, 2022-03-22 at 14:49 -0700, Carl Love wrote: > GDB maintainers: > > The following patch fixes the setting of the variable right_lib_flags > in the solib-search.exp test. With the fix the test now run > correctly > on Powerpc. > > The patch has been tested on a Power 10 system. > > Please let me know if the patch is acceptable for mainline gdb. > Thanks. > > Carl Love > > --------------------------------------------------- > Fix for gdb.base/solib-search.exp test. > > The variable right_lib_flags is not being set correctly to define > RIGHT. > The value RIGHT is needed to force the address of the library > functions > lib1_func3 and lib2_func4 to occur at different address in the wrong > and > right libraries. > > With RIGHT defined correctly, functions lib1_func3 and lib2_func4 > occur > at different addresses the test runs correctly on Powerpc. > --- > gdb/testsuite/gdb.base/solib-search.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/solib-search.exp > b/gdb/testsuite/gdb.base/solib-search.exp > index eaabe508bf0..202e79d85de 100644 > --- a/gdb/testsuite/gdb.base/solib-search.exp > +++ b/gdb/testsuite/gdb.base/solib-search.exp > @@ -54,7 +54,7 @@ set binfile2_lib [standard_output_file > ${libname2}.so] > > set lib_flags [list debug ldflags=-Wl,-Bsymbolic] > set wrong_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=1" > -set right_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=8192 > -DRIGHT" > +set right_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=8192 > additional_flags=-DRIGHT" > This change seems reasonable. Presumably the DARRAY_SIZE change introduced enough delta such that the test passed on other archs, and PowerPC was simply unlucky to catch the error. This change may fall under "obvious" , since it's a fix to the arguments used for the test, and post-fix now matches the style used in other tests with more than one argument. Particularly in comparison with the existing vsx-vsr-float28.exp test. Maybe an informal chat in the GDB IRC chat to confirm the guidelines for obvious. :-) Thanks -Will > # Binary file. > standard_testfile .c