Re: [PINGv4][PATCH v4 0/5] Smart pointer wrapper for frame_info

[Bruno Larsen <blarsen@redhat.com>]

On 10/10/2022 12:46, Tom de Vries wrote:
> On 10/10/22 09:55, Bruno Larsen via Gdb-patches wrote:
>> On 07/10/2022 21:35, Tom Tromey wrote:
>>>>>>>> "Bruno" == Bruno Larsen via Gdb-patches 
>>>>>>>> <gdb-patches@sourceware.org> writes:
>>> Bruno> ping!
>>>
>>> I had a couple minor nits on patch #5, but you can just fix those and
>>> push it all without re-sending.  Thank you for doing this.
>> Thanks! I'll rebase it and push the series in a second
>>
>
> I'm seeing a build breaker on x86_64-linux:
> ...
> /home/vries/gdb_versions/devel/src/gdb/guile/scm-frame.c: In function 
> ‘int frscm_eq_frame_smob(const void*, const void*)’:
> /home/vries/gdb_versions/devel/src/gdb/guile/scm-frame.c:137:11: 
> error: ‘frame_id_eq’ was not declared in this scope
>    return (frame_id_eq (a->frame_id, b->frame_id)
>            ^~~~~~~~~~~
>
I'm looking into this. The problem is that guile uses longjumps for 
exceptions, so I tried to avoid frame_info_ptr at all in guile code, and 
this (and other issues) is what happened. The patch will not be trivial, 
unfortunately, but I'll get it on the mailing list as soon as I can.

Cheers,
Bruno

> ...
>
> Thanks,
> - Tom
>