From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 862963858D37 for ; Mon, 10 Oct 2022 12:04:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 862963858D37 Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-517-3aEQDeRAOyOfU0AomMcbrA-1; Mon, 10 Oct 2022 08:04:52 -0400 X-MC-Unique: 3aEQDeRAOyOfU0AomMcbrA-1 Received: by mail-ua1-f71.google.com with SMTP id o43-20020ab0596e000000b0038421e4c7deso4432652uad.19 for ; Mon, 10 Oct 2022 05:04:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=suog3sJMxQRP9nt7u0CSKsiZ075RKLSdTX16EJdaxmk=; b=FYKjz03D7UjIinrS+EicMFMVQcrdW8ULTwNjsprgVFh3bT407DzDPlPRaTKEbNRNqg kBBfFlSpiJ+A3favlsFPyjQ5r/94N3QpAtncen+q6zgp9SeMHM1C3ujecc+J+iCaQb9R ks3rKvZ88IXyrDG2mv0d4axEydrUp834GlwHTsXddlJcY6DLdklHCWMBirSjZ7DWMSiA IQynUYWMV1MzgiclWMZp/jM7ojODpqTaR7OO1XvQ07Bvu9/wBAK02Fov8YkPox+MkV8J dQY+XHifIagci2Le4XsCtqZ7uNnFv/a8JGgkqstObGhcVUn+dAVH2CourMeIwjDCeNEq 6SDg== X-Gm-Message-State: ACrzQf37qMWslnbk+T7uwYcejezA2sDqpFRVRR9VnWY68fZDPHEybeis UoMm8RCLA16bEyJPxanTP5IJQ9SakgfECo/TZw4QcOqeTPfip3gsF0LZfHN/1eqkjIZkbG3VVRi uozC8ange/2sVzr2IatDixQ== X-Received: by 2002:a05:6214:1c85:b0:4af:7393:3d91 with SMTP id ib5-20020a0562141c8500b004af73933d91mr14519433qvb.74.1665403480640; Mon, 10 Oct 2022 05:04:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5mDRbjE0uqPd98Z7twwNE6414nblGtuFLjXQQ1M0J+YBdUjZxv6PLLxbvol2Ap8DYz/dkd7A== X-Received: by 2002:a05:6214:1c85:b0:4af:7393:3d91 with SMTP id ib5-20020a0562141c8500b004af73933d91mr14519400qvb.74.1665403480358; Mon, 10 Oct 2022 05:04:40 -0700 (PDT) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id u1-20020a05620a0c4100b006cfc4744589sm10139235qki.128.2022.10.10.05.04.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 05:04:39 -0700 (PDT) Message-ID: <9b75a9ca-5bca-cc42-4938-fc15ab1ab40b@redhat.com> Date: Mon, 10 Oct 2022 14:04:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PINGv4][PATCH v4 0/5] Smart pointer wrapper for frame_info To: Tom de Vries , Tom Tromey , Bruno Larsen via Gdb-patches References: <20220830100837.926692-1-blarsen@redhat.com> <2c1d8266-e990-3f20-4982-81baca607d23@redhat.com> <7342727b-3947-c97a-f380-28b0252f3389@redhat.com> <2048ae6a-07e8-8743-2030-82c7f0fee4d2@redhat.com> <87sfjzs9zd.fsf@tromey.com> <472ae014-5764-51f5-caf7-352fa543a530@redhat.com> From: Bruno Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2022 12:05:00 -0000 On 10/10/2022 12:46, Tom de Vries wrote: > On 10/10/22 09:55, Bruno Larsen via Gdb-patches wrote: >> On 07/10/2022 21:35, Tom Tromey wrote: >>>>>>>> "Bruno" == Bruno Larsen via Gdb-patches >>>>>>>> writes: >>> Bruno> ping! >>> >>> I had a couple minor nits on patch #5, but you can just fix those and >>> push it all without re-sending.  Thank you for doing this. >> Thanks! I'll rebase it and push the series in a second >> > > I'm seeing a build breaker on x86_64-linux: > ... > /home/vries/gdb_versions/devel/src/gdb/guile/scm-frame.c: In function > ‘int frscm_eq_frame_smob(const void*, const void*)’: > /home/vries/gdb_versions/devel/src/gdb/guile/scm-frame.c:137:11: > error: ‘frame_id_eq’ was not declared in this scope >    return (frame_id_eq (a->frame_id, b->frame_id) >            ^~~~~~~~~~~ > I'm looking into this. The problem is that guile uses longjumps for exceptions, so I tried to avoid frame_info_ptr at all in guile code, and this (and other issues) is what happened. The patch will not be trivial, unfortunately, but I'll get it on the mailing list as soon as I can. Cheers, Bruno > ... > > Thanks, > - Tom >