From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B75793858D28 for ; Fri, 11 Aug 2023 17:14:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B75793858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37BHCNwY022211; Fri, 11 Aug 2023 17:14:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding : subject; s=pp1; bh=4rN8UiGRgbKZluj6AQI/esGTOzYIw0ltQalkf7RdMa0=; b=cCCp8e9f+0daN9cx/Tjb5evmwDHQyhGmRAHyOwip9cgoh/iLP9YCt1gF8CwnPwkiuPiM oGEj51+i2ABXryd2+4ZCP9qAG3soj899+PG0IHLUN6aYMxwQMvq0xI4aBfwB3wT3SSK9 zKvD8tqdvBOo0G++T78ofSWqMmlRvPhxfA3ckF2scpLzF5YxZ15uY4vGeTDHNrsUvpZE t0hSF0OsGv3cg+OrVK8S4Ma4EHb4hMm/qsyUakYHBgAiEah4vO63u2pUDAnCol1SAcZB 12873cPchtoPef156x4CRaCeze0ifZ6WhlB3khVJ9vnGAZ0rzYj4n3KOV1uBwFaDxETz uw== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3sds6981g7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Aug 2023 17:14:27 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 37BGi1vK006666; Fri, 11 Aug 2023 17:14:26 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3sa0rtw16d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Aug 2023 17:14:26 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 37BHEPs361211110 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 Aug 2023 17:14:25 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B86E58060; Fri, 11 Aug 2023 17:14:25 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B0CA458056; Fri, 11 Aug 2023 17:14:24 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.61.62.89]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 11 Aug 2023 17:14:24 +0000 (GMT) Message-ID: <9ba870d323b0d30ec36d4c3865ed937770d268ba.camel@us.ibm.com> From: Carl Love To: Tom Tromey , Carl Love via Gdb-patches Cc: Ulrich.Weigand@de.ibm.com, cel@us.ibm.com Date: Fri, 11 Aug 2023 10:14:24 -0700 In-Reply-To: <87fs4p1tes.fsf@tromey.com> References: <87fs4p1tes.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: v5kcOsTbeHgj7caaUJY0HpOhhI_Hus8L X-Proofpoint-ORIG-GUID: v5kcOsTbeHgj7caaUJY0HpOhhI_Hus8L Subject: RE: [PATCH] gdb.ada/mi_var_access.exp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-11_09,2023-08-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxscore=0 bulkscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=772 suspectscore=0 priorityscore=1501 adultscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308110156 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom: On Fri, 2023-08-11 at 09:38 -0600, Tom Tromey wrote: > > > > > > "Carl" == Carl Love via Gdb-patches < > > > > > > gdb-patches@sourceware.org> writes: > > Carl> The following patch fixes two failures on PowerPC. The test > expects > Carl> the value of NUMCHILD to always be 1 but on PowerPC it is 2. > > What is the extra child? > Seeing the MI output here might be informative. > I see I have a typo above. The test is expecting 1, but it is 0 on PowerPC, not 2 as stated above. (gdb) Expecting: ^(-var-create A_String_Access \* A_String_Access[^M ]+)?((\^done,name="A_String_Access",numchild="1",.*|\^error,msg="Value out of range.".*)[ ]+[(]gdb[)] [ ]*) -var-create A_String_Access * A_String_Access ^done,name="A_String_Access",numchild="0",value="0x0",type="pck.string_access",thread-id="1",has_more="0" (gdb) FAIL: gdb.ada/mi_var_access.exp: Create varobj (unexpected output) I have looked thru the log file for other places where numchild is printed. There is one other place which is after the second test failure that the patch fixes. In this case we get the expected value of numchild: (gdb) Expecting: ^(-var-update A_String_Access[ ]+)?(\^done,changelist=\[\{name="A_String_Access",in_scope="true",type_changed="false",has_more="0"\}\][ ]+[(]gdb[)] [ ]*) -var-update A_String_Access ^done,changelist=[{name="A_String_Access",in_scope="true",type_changed="true",new_type="pck.string_access",new_num_children="1",has_more="0"}] (gdb) FAIL: gdb.ada/mi_var_access.exp: update at stop 2 (unexpected output) Expecting: ^(-var-list-children A_String_Access[]+)?(\^done,numchild="1",children=\[child=\{name="A_String_Access\.A_String_Access\.all",exp="A_String_Access\.all",numchild="3",type="array \(3 \.\. 5\) of character",thread-id="1"\}\],has_more="0"[ ]+[(]gdb[)] [ ]*) -var-list-children A_String_Access ^done,numchild="1",children=[child={name="A_String_Access.A_String_Access.all",exp="A_String_Access.all",numchild="3",type="array (3 .. 5) of character",thread-id="1"}],has_more="0" (gdb) PASS: gdb.ada/mi_var_access.exp: list children at stop 2 In this case, the numchild value argrees with the expected output. Carl