From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E16903858D32 for ; Mon, 18 Sep 2023 00:45:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E16903858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 38I0jrHs007752 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 17 Sep 2023 20:45:58 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 38I0jrHs007752 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1694997958; bh=GwQJmIUaKbc0DPBKzgwH0vi6H86pqBfJh4gi174IxOU=; h=Date:Subject:To:References:From:In-Reply-To:From; b=ouYajvjMKqCd+cIBvsHjUroCa8SDRDwVwSZMwmAEzLz/Xjn/zy7sM59D6gp4smLq0 Cjpr190yTCfPddtnc5drkH9wY0RBjz7cti8e8dvy8CPlN/YIaMqhOfnAgjG+Ob8PPN 4ddN54OrGOkTQqNob4nY0TE7cCYWr3IK1ooqfDwQ= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BB2CC1E092; Sun, 17 Sep 2023 20:45:53 -0400 (EDT) Message-ID: <9baa9a6e-7bc9-47d9-affe-d0d7c84ba101@polymtl.ca> Date: Sun, 17 Sep 2023 20:45:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Use checked_static_cast for breakpoint casts Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230915-watchpoint-casts-v1-0-a4ff35c9644e@adacore.com> From: Simon Marchi In-Reply-To: <20230915-watchpoint-casts-v1-0-a4ff35c9644e@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 18 Sep 2023 00:45:54 +0000 X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-09-15 14:36, Tom Tromey via Gdb-patches wrote: > While reviewing a patch, I noticed some unchecked casts to watchpoint. > This series replaces all the unchecked breakpoint casts I could find > with checked casts. > > Regression tested on x86-64 Fedora 36. I sent a minor comment on patch 1. Getting rid of the struct keyword when possible might allow avoid line wrapping in a bunch of places. But otherwise: Approved-By: Simon Marchi Simon