From: Pedro Alves <palves@redhat.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH] Removal of uses of MAX_REGISTER_SIZE
Date: Wed, 01 Feb 2017 15:49:00 -0000 [thread overview]
Message-ID: <9bf11853-462e-1950-aab4-19fa376faf4e@redhat.com> (raw)
In-Reply-To: <DF6DC192-18EE-4F7D-AB56-2521F4EA93F8@arm.com>
On 01/27/2017 04:46 PM, Alan Hayward wrote:
> --- a/gdb/xtensa-tdep.c
> +++ b/gdb/xtensa-tdep.c
> @@ -370,7 +370,10 @@ static void
> xtensa_register_write_masked (struct regcache *regcache,
> xtensa_register_t *reg, const gdb_byte *buffer)
> {
> - unsigned int value[(MAX_REGISTER_SIZE + 3) / 4];
> + struct gdbarch *gdbarch = get_regcache_arch (regcache);
> + unsigned int *value = (unsigned int *) alloca (max_register_size (gdbarch)
> + + 1);
I don't think I understand this +1.
AFAICS, the previous code was creating an array of ints
such that sizeof(value) is as big as MAX_REGISTER_SIZE, rounded up
to sizeof int. Seems like a replacement would be:
alloca (align_up (max_register_size (gdbarch), 4));
or better:
alloca (align_up (max_register_size (gdbarch), sizeof (int)));
?
> +
> const xtensa_mask_t *mask = reg->mask;
>
> int shift = 0; /* Shift for next mask (mod 32). */
> @@ -454,7 +457,9 @@ static enum register_status
> xtensa_register_read_masked (struct regcache *regcache,
> xtensa_register_t *reg, gdb_byte *buffer)
> {
> - unsigned int value[(MAX_REGISTER_SIZE + 3) / 4];
> + struct gdbarch *gdbarch = get_regcache_arch (regcache);
> + unsigned int *value = (unsigned int *) alloca (max_register_size (gdbarch)
> + + 1);
Ditto.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-02-01 15:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 10:31 Alan Hayward
2017-01-27 11:49 ` Pedro Alves
2017-01-27 12:11 ` Pedro Alves
2017-01-27 16:46 ` Alan Hayward
2017-02-01 15:49 ` Pedro Alves [this message]
2017-02-01 12:45 ` Yao Qi
2017-02-01 15:48 ` Pedro Alves
2017-02-02 9:40 ` Joel Brobecker
2017-02-03 9:59 ` Alan Hayward
2017-02-03 10:28 ` Yao Qi
2017-02-03 11:00 ` Pedro Alves
2017-02-03 11:25 ` Alan Hayward
2017-02-03 16:50 ` Yao Qi
2017-02-06 9:33 ` Alan Hayward
[not found] ` <20170206152635.GE11916@E107787-LIN>
2017-02-07 16:33 ` Alan Hayward
2017-02-08 10:47 ` Yao Qi
2017-02-08 14:17 ` Alan Hayward
2017-02-08 12:06 ` Yao Qi
2017-02-08 12:24 ` Yao Qi
2017-02-08 14:44 ` Alan Hayward
2017-02-18 23:19 ` Yao Qi
2017-02-20 11:19 ` Alan Hayward
2017-02-08 15:32 ` Yao Qi
2017-02-08 17:10 ` Yao Qi
2017-02-09 13:26 ` Alan Hayward
2017-02-14 11:24 ` Alan Hayward
2017-02-08 17:36 ` Yao Qi
2017-02-13 11:59 ` Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bf11853-462e-1950-aab4-19fa376faf4e@redhat.com \
--to=palves@redhat.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).