From: Pedro Alves <pedro@palves.net>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Tom Tromey <tromey@adacore.com>,
Andrew Burgess <aburgess@redhat.com>
Cc: Ulrich Weigand <ulrich.weigand@de.ibm.com>,
Andreas Arnez <arnez@linux.ibm.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v4] gdb: Do not add empty sections to the section map
Date: Thu, 2 Jun 2022 12:30:29 +0100 [thread overview]
Message-ID: <9c12eb66-db3b-1d76-cb89-fe9e9e8c3517@palves.net> (raw)
In-Reply-To: <20220601170744.2884144-1-iii@linux.ibm.com>
On 2022-06-01 18:07, Ilya Leoshkevich wrote:
> From: Ulrich Weigand <ulrich.weigand@de.ibm.com>
>
> build_objfile_section_table () creates four synthetic sections per
> objfile, which are collected by update_section_map () and passed to
> std::sort (). When there are a lot of objfiles, for example, when
> debugging JITs, the presence of these sections slows down the sorting
> significantly.
>
> The output of update_section_map () is used by find_pc_section (),
> which can never return any of these sections: their size is 0, so they
> cannot be accepted by bsearch_cmp ().
>
> Filter them (and all the other empty sections) out in
> insert_section_p (), which is used only by update_section_map ().
> ---
>
> v3: https://sourceware.org/pipermail/gdb-patches/2022-June/189692.html
> v3 -> v4: Use whether a section is empty or not as the filtering
> criteria (Pedro).
Thanks. This LGTM.
prev parent reply other threads:[~2022-06-02 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 17:07 Ilya Leoshkevich
2022-06-02 11:30 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c12eb66-db3b-1d76-cb89-fe9e9e8c3517@palves.net \
--to=pedro@palves.net \
--cc=aburgess@redhat.com \
--cc=arnez@linux.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=iii@linux.ibm.com \
--cc=tromey@adacore.com \
--cc=ulrich.weigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).