From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 87A643857408 for ; Thu, 19 Aug 2021 18:33:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87A643857408 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17JIXm0a005493 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Aug 2021 14:33:53 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17JIXm0a005493 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5952A1E79C; Thu, 19 Aug 2021 14:33:48 -0400 (EDT) Subject: Re: [PATCH 1/6] gdb: use bool instead of int in struct internal_problem To: Andrew Burgess , gdb-patches@sourceware.org References: <2f8d9b07e5d548eedc58bd73594cafb135b46963.1629366146.git.andrew.burgess@embecosm.com> From: Simon Marchi Message-ID: <9c261eb6-0271-4c1e-f71c-8453ebe389d2@polymtl.ca> Date: Thu, 19 Aug 2021 14:33:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <2f8d9b07e5d548eedc58bd73594cafb135b46963.1629366146.git.andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 19 Aug 2021 18:33:48 +0000 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2021 18:34:04 -0000 On 2021-08-19 5:49 a.m., Andrew Burgess wrote: > Change struct internal_problem (gdb/utils.c) to use bool instead of > int, update the 3 static instances of this structure that we create to > use true/false instead of 1/0. > > I've also updated the comments on struct internal_problem as the > existing comment doesn't seem to be referring to the structure, it > talks about returning something, which doesn't make sense in this > context. > > There should be no user visible changes after this commit. That LGTM on its own. Simon