From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by sourceware.org (Postfix) with ESMTPS id E01C638618C3 for ; Wed, 3 Mar 2021 18:33:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E01C638618C3 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 123IOqBP172828; Wed, 3 Mar 2021 18:31:09 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 3726v7a13g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Mar 2021 18:31:09 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 123IP24O175934; Wed, 3 Mar 2021 18:31:08 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by userp3030.oracle.com with ESMTP id 37000yt1bq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Mar 2021 18:31:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vy8nDvIsWDQ/r/2bg7T57634+VfR1WZiik1+o9ta/rWL4kR5GU4Z1V1uXleYjmn8ukkxZLy3P9ia3oRizJD4Jwv5RJYQ1N9oLk6iMwQzzqH5umr5pQAqSZ5CTcf//S++SqH0CQ5+ZkWbswbvkBLRoMbD2a/1MS8PD3vpiFef0+OBEG5qD8SJbrc4Hy3KvOvXiz6tLaJXTtfPPjX8as7BWk4snz2K0GPuzYSlHLVN4vdF9fLWXLKpc0BzV6x77EF4fwW9sZ6BG9f5At0ljVo60rT4ALWzKogbvn+Nw/r8MTZaf3Ab4xpd03viwfdMKDSyOYnXrrBklJfzZonAnwzvQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YHYO9bwCGQi5hxduC5htINc+vTnruqZ++NWT31wZElQ=; b=Sgv474g8NzFckmM8jcGclvrEjei95YkpLhhoBhe1nCYVWwXyCCoQZnGZvLC8TZjWhvyheItL6xn9uUSPyWycgPhOW1lbROo5Pf6RWiIFzaEjjufhRn2e9f7m8ougPKHwstdLiXmRVKVDP7Jve8ISvnegTmooGdhOiOV7RWXo6NQND1rbuydBD6cwJU52RzcdjZfkG8eUsX60PDGUinukgKh+93Oo9wbt6Ee4hEJAqysYdyPgqhcSbXQqn5sOc4Itar2pyyJ2GvKw89U33y1I6nJRd0T1F+4B+IkUFhUbpVTM5JV/cDdc9QUsUxBYJwgLL4N844BXOlVuUAaqVS8B5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BN6PR10MB1748.namprd10.prod.outlook.com (2603:10b6:405:9::16) by BN0PR10MB4902.namprd10.prod.outlook.com (2603:10b6:408:12a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19; Wed, 3 Mar 2021 18:31:06 +0000 Received: from BN6PR10MB1748.namprd10.prod.outlook.com ([fe80::1163:f828:25bb:2538]) by BN6PR10MB1748.namprd10.prod.outlook.com ([fe80::1163:f828:25bb:2538%7]) with mapi id 15.20.3890.030; Wed, 3 Mar 2021 18:31:06 +0000 Subject: Re: [PATCH,V2 5/5] CTF: multi-CU and archive support To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <1614650018-9135-1-git-send-email-weimin.pan@oracle.com> <1614650018-9135-2-git-send-email-weimin.pan@oracle.com> <1614650018-9135-3-git-send-email-weimin.pan@oracle.com> <1614650018-9135-4-git-send-email-weimin.pan@oracle.com> <1614650018-9135-5-git-send-email-weimin.pan@oracle.com> <1614650018-9135-6-git-send-email-weimin.pan@oracle.com> From: Weimin Pan Message-ID: <9c83da80-a3fd-d48e-1f39-9ed4d6fbd2ba@oracle.com> Date: Wed, 3 Mar 2021 10:31:06 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [108.88.88.153] X-ClientProxiedBy: SJ0PR03CA0128.namprd03.prod.outlook.com (2603:10b6:a03:33c::13) To BN6PR10MB1748.namprd10.prod.outlook.com (2603:10b6:405:9::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [172.27.35.125] (108.88.88.153) by SJ0PR03CA0128.namprd03.prod.outlook.com (2603:10b6:a03:33c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 18:31:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 093224b5-de74-4f8b-08dd-08d8de728208 X-MS-TrafficTypeDiagnostic: BN0PR10MB4902: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2XhoGzknSwMdhe2jG7Ck32d7o2f3gQv7SEeFDUr4QcvA24zwlagQelC6JKUba9stA4KqotFPVQwbDiRa4anyTNjOFFWIQt0iTkrfRRiLBS3oURKG5MurUTZl4Szl5+e4g8ILeJ/hDlw8Usej7ui3e1JBMmzUrssFmqkTzvgHJEQlwSn2wXCW2Wx4Fi2XwbHoLXlnZQrQqNdmPzO+074F4edFjuI3LY1e4tO0zR0o+zbI/oiYfnWxFPBC0YjOa7a7swJGcf9W+sNeJ85lxKXF1lGc3cEIOMHZROrusPdfQ/prHdm5p9wukAynocH0Nzi33WmcawSZ1vXNacaY8dUCTY6MksTi1I6IOi7+WC0B6QlzilmcCknl12Klzo9514EtD3dbC1tIvkyfJ7QYdyckRf8jfhuB/4We72wxCefET/heKk6BCiAu8TDT88KT69V9GZLRMn0lw6wDDlg4Aldt5hhE38m7D6an0RpWTLbLAQnbZ9Rtd+IAcalt126FJ+u8gjoKIfPp8Wc0E0QOxIANXSbEeoHImbVBOFQUrOYKOcjFvQVtKzeyKvo6RrXBxRy752WJdFW/w3eiKl3xBHHJJFvuGqxQz7rl0yq6BjdbldU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR10MB1748.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(39860400002)(346002)(396003)(136003)(16526019)(8936002)(2616005)(16576012)(31686004)(6486002)(44832011)(8676002)(36756003)(52116002)(956004)(2906002)(6916009)(53546011)(26005)(4326008)(186003)(86362001)(316002)(478600001)(4744005)(5660300002)(66476007)(66556008)(66946007)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?VkFxOEc4MTFNblJjaDA2Mkh6ZS91RjZLZm5VSXdTWVA3WkRaUlZDdDRQN2dx?= =?utf-8?B?KzRDVkczU1R2QjBGa3pEWHllYzE3Vm5NTS9KN2J0bUFDeTVhY0NwWXdBVXA2?= =?utf-8?B?aGZpM2RTbFozK1MwVHNubGpnZExJVXJFaEtqbGpEbHV0dDEvTWM3Q2FxQk42?= =?utf-8?B?WURDQmZvNnFETWl5RWZ0SVZ6alBwVFRzTUI1MXN3WUFuQnJiNURZOCtxS2Vv?= =?utf-8?B?TXRaNWV3SkxZUm5XYmFxUG1UNExsRitPdXFmOXZwa1FqbDVwUzNqVFN6dXJN?= =?utf-8?B?dEJ1Ti9KTm5CeHI2ZFYrczI2cWRmaFlYSnJZNnhlTm1iSmUxUDFCNitkR3A4?= =?utf-8?B?b3RzQzVhZVlZM0JFWjRPeENEcEJrQnAxb2lpcVhSQVlxRXd1VXZKY3NsMWs3?= =?utf-8?B?V3cvdDJnazdIaStnZmp3QjhlS2pJckNqNGsyWWlseWg5enFIamczR1Jaa1pD?= =?utf-8?B?WWZOY3llWGpFT3VPQklKR1FrNkdNajllN2Q5dHdyUUQ2MDZWc01xb05sTUtU?= =?utf-8?B?WGVzTGtPYXVocGY1M2ZLR3lSUnBsT2lURm5nTTYzVXAraDV0S3JTY0R1eEt0?= =?utf-8?B?bVVYWTlkVDI0QkRhYm5CV04yVFNSdW43M1ZHcXpZeWFQdE8velNSMGtvQ2p4?= =?utf-8?B?bzdTY0svZ3BlYUlsQVcxR0JwQU03YXRkR0hZY1JXOFJBRlZ3WlIwUGZ6eU96?= =?utf-8?B?ejV5WG9tc3lZaExNSWVabDV5cWJkamJ0TXdMNFpPRUJGdG9xejZ3QUJKTUFC?= =?utf-8?B?T1ZFTDhJanRtOFNxZUI1cnpydjUyNjlBRzFpK0lRbjVsdk5IQUVuZlR4cFR5?= =?utf-8?B?S1RvdWNrWXp2Y3NaSmErWnltVjNWNWV6bVQwUHlIeGsyY3NRbFdMQld1RUU2?= =?utf-8?B?NjRTcnVxK0h0d2huaTcwdHFZaGxrbGFveU9IZlJkVm5ZM0puMUtxdVRIRDFq?= =?utf-8?B?UHY0ZGo4KzlFcWVuVEV2L01sSzVUV1dla1U4U00zVXRxaU5IenljTlVHMWsy?= =?utf-8?B?Nk9oTzVGTE0vZkNUZ2dHaFBobnQrVkV5R0JkR1R4TDQrZlhYbzZENHdZbnE2?= =?utf-8?B?RC9EL0tDd0hLM1JXM0FnYzM0dmlqN1ZNSCtHMXRFQk1JdHVLUUdSbUtSa1JQ?= =?utf-8?B?Qk5EQ2xXM01jRkxSUitFRmxtR0lhclR3YTRXbG1KNUFXSUllWmg4bWVFS3pn?= =?utf-8?B?YklBaWlsekQ2K2JzWndmako1RUhhZURHZE5uWVFKYW11cW1FVC9wc0J6bGF4?= =?utf-8?B?UmlLK0ZRUE1TVHhIVWlrRDJneXBRYjVpcTlSRzlqaU5teWpmRU5zRzFsWFpz?= =?utf-8?B?TCthbGJORkE3eWZwYUtYZllxYWNnQVNkWWFWNnRDekFkS012V2VEQjVGVDYz?= =?utf-8?B?MG9mVFY5dFU5ck1GSjh2VyswM3RGNVpyNE9LWWY2WUZjcDA5ZzJuVTA1V2Jh?= =?utf-8?B?aVNtTkhsVkU1cExhODdEd2VUQlA4RjlJTGpSUzlwaHBRN3liS3lacERxK0tY?= =?utf-8?B?QlVEZm1lQnZTR0dhbTQ3a25neTI4c25mSGJrbTBNR3NHMUJ2ckZZN2ZPTmp1?= =?utf-8?B?emxTR1pGZ3FyT3RONk53cE9pdjRRcDZoallYZEF0dlFLTW1maHk2NjF3N2w4?= =?utf-8?B?SGhLdU10L1BLTkoxTjljTk1RR2JtRGtJRENEeFhVUkVaak9kUmdJbXZONUdx?= =?utf-8?B?bW11c2t3d0ltVGVRSDJFdVM3MTRhb3VaUjlFcVdUZmN5R1B1dlVGQVBNd2tV?= =?utf-8?Q?qC+13Kr/v5gMIKllH2C1Ql6lxyPQYCZs0cUT0wa?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 093224b5-de74-4f8b-08dd-08d8de728208 X-MS-Exchange-CrossTenant-AuthSource: BN6PR10MB1748.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 18:31:06.6695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iEwFY7UTJyag0JL6dNwcIsxPOxGgGRebMR/p51LZhpzNzz+dTxpajRcq6WUu+AFCQBR9SDmYg4jFkKGp7162NA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4902 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103030129 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9912 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 phishscore=0 mlxscore=0 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103030129 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 18:33:17 -0000 On 3/3/2021 9:37 AM, Lancelot SIX wrote: >>>> +static int >>>> +build_ctf_archive_member (ctf_dict_t *ctf, const char *name, void *arg) >>> I do not see the advantage of having arg passed as a void *. It is >>> casted unconditionally to a struct ctf_per_tu_data * and dereferenced >>> just after that. >>> >>> Why not just pass the argument as a struct ctf_per_tu_data * directly? >> build_ctf_archive_member is the callback function of ctf_archive_iter and is >> of >> type ctf_member_f which is defined in ctf-api.h: >> >> typedef int ctf_member_f (const char *name, ctf_id_t membtype, >>                           unsigned long offset, void *arg); >> >> and the last argument "pcu" of type struct ctf_per_tu_data * is being passed >> in call: >> >>         if (ctf_archive_iter (arc, build_ctf_archive_member, &pcu) < 0) >> >> The conversion is necessary. >> > Indeed. I went too fast when reading where this function is used. Sorry > for the noise. No problem. I really appreciate your comments. > Thanks, > Lancelot.