From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] dtrace-probe: Put semicolon after while on its own line
Date: Sun, 25 Jun 2017 10:48:00 -0000 [thread overview]
Message-ID: <9cada962c73394285f820d1304db9608@polymtl.ca> (raw)
In-Reply-To: <2ea4d9d1-5434-6b87-91d0-924ef6e0fb90@redhat.com>
On 2017-06-21 23:36, Pedro Alves wrote:
> On 06/21/2017 09:15 PM, Simon Marchi wrote:
>> /* Use strtab_size as a sentinel. */
>> - while (*p++ != '\0' && p - strtab < strtab_size);
>> + while (*p++ != '\0' && p - strtab < strtab_size)
>> + ; /* Silence clang's -Wempty-body warning. */
>
> I'd must put the ; on its own line (there's probably something
> in the coding conventions about this already), and without the
> comment. It's quite common to write for/while loop like that,
> see e.g.,:
>
> $ grep "^[ |\t]*;[ |\t]*$" *.c -C 2
>
> Sure the comment makes sense in the context of the patch,
> but when reading the code without considering the patch's context,
> it just looks like noise to me.
Ok, since that's already a common practice in our codebase, I added it
to our wiki (I didn't find anything related to that in the GNU
standards):
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#preview
I am pushing without the comment.
Thanks,
Simon
next prev parent reply other threads:[~2017-06-25 10:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 20:15 [PATCH 0/4] Get rid of some more warnings given by clang Simon Marchi
2017-06-21 20:15 ` [PATCH 1/4] environ-selftests: Ignore -Wself-move warning Simon Marchi
2017-06-21 20:29 ` Sergio Durigan Junior
2017-06-21 21:05 ` Simon Marchi
2017-06-21 21:12 ` Sergio Durigan Junior
2017-06-21 21:28 ` Pedro Alves
2017-06-21 21:32 ` Sergio Durigan Junior
2017-06-22 7:44 ` Simon Marchi
2017-06-22 9:34 ` Pedro Alves
2017-06-21 21:16 ` Simon Marchi
2017-06-21 21:30 ` Sergio Durigan Junior
2017-06-22 8:31 ` [PATCH v2] " Simon Marchi
2017-06-22 9:51 ` Pedro Alves
2017-06-22 10:52 ` Pedro Alves
2017-06-22 10:57 ` Simon Marchi
2017-06-22 11:43 ` Pedro Alves
2017-06-21 20:15 ` [PATCH 2/4] x86-dregs: Print debug registers one per line Simon Marchi
2017-06-21 20:31 ` Sergio Durigan Junior
2017-06-21 21:06 ` Simon Marchi
2017-06-25 10:58 ` Simon Marchi
2017-06-21 20:15 ` [PATCH 4/4] main: Don't add int to string Simon Marchi
2017-06-21 20:35 ` Sergio Durigan Junior
2017-06-25 10:58 ` Simon Marchi
2017-06-21 20:15 ` [PATCH 3/4] dtrace-probe: Put semicolon after while on its own line Simon Marchi
2017-06-21 20:34 ` Sergio Durigan Junior
2017-06-21 21:08 ` Simon Marchi
2017-06-21 21:36 ` Pedro Alves
2017-06-25 10:48 ` Simon Marchi [this message]
2017-06-25 10:57 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cada962c73394285f820d1304db9608@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).