From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124269 invoked by alias); 25 Oct 2016 12:54:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123660 invoked by uid 89); 25 Oct 2016 12:54:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 12:54:26 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5502064387; Tue, 25 Oct 2016 12:54:25 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9PCsOWe019058; Tue, 25 Oct 2016 08:54:24 -0400 Subject: [pushed] common/common-defs.h: Define __STDC_FORMAT_MACROS as well (Re: GDB AIX build broken) To: David Edelsohn References: <01ba546d-060d-8591-9c5a-84d4bda2af22@redhat.com> <9a7ac4b5-2f5c-916c-a52e-c94e64d6f4f0@redhat.com> <12052de4-a0dd-8d23-2f46-57e91059cfa5@redhat.com> <8fd35f0e-3a7e-25fb-f2ee-2fa50c35beff@redhat.com> Cc: GDB Patches From: Pedro Alves Message-ID: <9cb8f94e-7276-7351-081a-71640379dbc6@redhat.com> Date: Tue, 25 Oct 2016 12:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00696.txt.bz2 On 10/25/2016 01:48 PM, Pedro Alves wrote: > On 10/25/2016 01:41 PM, David Edelsohn wrote: >> Thanks, however... >> >> The missing macro is __STDC_FORMAT_MACROS. The macros that you >> re-added were not causing problems on AIX and don't enable the printf >> format macros in C++. > > Indeed, missed. Will add that too shortly. Done now. Let me know how it goes. >From b30f354acb39f63bf3213673a0584119e63538b9 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 25 Oct 2016 13:50:20 +0100 Subject: [PATCH] common/common-defs.h: Define __STDC_FORMAT_MACROS as well Ref: https://sourceware.org/ml/gdb-patches/2016-10/msg00694.html gdb/ChangeLog: 2016-10-25 Pedro Alves * common/common-defs.h (__STDC_FORMAT_MACROS): Define. --- gdb/ChangeLog | 4 ++++ gdb/common/common-defs.h | 12 ++++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c2a8579..1f58821 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2016-10-25 Pedro Alves + * common/common-defs.h (__STDC_FORMAT_MACROS): Define. + +2016-10-25 Pedro Alves + * common/new-op.c: Add comment about -fsanitize=address. 2016-10-25 Pedro Alves diff --git a/gdb/common/common-defs.h b/gdb/common/common-defs.h index 3d5ff18..8fbb4bf 100644 --- a/gdb/common/common-defs.h +++ b/gdb/common/common-defs.h @@ -35,10 +35,18 @@ macros such as INTMAX_C, and one must define __STDC_LIMIT_MACROS to make visible the definitions of limit macros such as INTMAX_MAX.". - Must do this before including any system header, since system - headers may include stdint.h. */ + And: + https://www.gnu.org/software/gnulib/manual/html_node/inttypes_002eh.html + + "On some hosts that predate C++11, when using C++ one must define + __STDC_FORMAT_MACROS to make visible the declarations of format + macros such as PRIdMAX." + + Must do this before including any system header, since other system + headers may include stdint.h/inttypes.h. */ #define __STDC_CONSTANT_MACROS 1 #define __STDC_LIMIT_MACROS 1 +#define __STDC_FORMAT_MACROS 1 #include #include -- 2.5.5