public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Fix reverse nexting over recursions
@ 2022-08-31 12:07 Bruno Larsen
  2022-08-31 12:07 ` [PATCH v3 1/2] Change calculation of frame_id by amd64 epilogue unwinder Bruno Larsen
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Bruno Larsen @ 2022-08-31 12:07 UTC (permalink / raw)
  To: gdb-patches; +Cc: pedro, aburgess, Bruno Larsen

This patch series fixes gdb record/16678, GDB being unable to
reverse-next over a recursive function.  However, the simple way to fix
it hit a snag when I discovered that the amd64 epilogue unwinder would
give a different frame id than the dwarf2 unwinder would in the rest of
the function.  This patch series first change this discrepancy, then
fixes the bug.

Changelog for v3:
    * fix some comments on the amd64_epilogue_unwinder
    * fix style for the step-reverse test

Changelog for v2:
    * Implemented Pedro Alves's suggestion to simplify the fix
    * Added the first patch to fix a regression that the simple fix
      would introduce.

Bruno Larsen (2):
  Change calculation of frame_id by amd64 epilogue unwinder
  gdb/reverse: Fix stepping over recursive functions

 gdb/amd64-tdep.c                              |  10 +-
 gdb/infrun.c                                  |   2 +-
 .../gdb.base/unwind-on-each-insn-foo.c        |  22 +++
 gdb/testsuite/gdb.base/unwind-on-each-insn.c  |  25 +++
 .../gdb.base/unwind-on-each-insn.exp          | 154 ++++++++++++++++++
 gdb/testsuite/gdb.reverse/step-precsave.exp   |   6 +-
 gdb/testsuite/gdb.reverse/step-reverse.c      |  18 +-
 gdb/testsuite/gdb.reverse/step-reverse.exp    |  58 ++++++-
 8 files changed, 282 insertions(+), 13 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn-foo.c
 create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn.c
 create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn.exp

-- 
2.37.2


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-10-04 16:40 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-31 12:07 [PATCH v3 0/2] Fix reverse nexting over recursions Bruno Larsen
2022-08-31 12:07 ` [PATCH v3 1/2] Change calculation of frame_id by amd64 epilogue unwinder Bruno Larsen
2022-08-31 12:07 ` [PATCH v3 2/2] gdb/reverse: Fix stepping over recursive functions Bruno Larsen
2022-09-30 18:28   ` Pedro Alves
2022-10-04 16:40     ` Bruno Larsen
2022-09-14 13:16 ` [Ping][PATCH v3 0/2] Fix reverse nexting over recursions Bruno Larsen
2022-09-22 14:13   ` [PINGv2][PATCH " Bruno Larsen
2022-09-29  7:02     ` [PINGv3][PATCH " Bruno Larsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).