From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id B8588384AB58 for ; Sat, 4 May 2024 07:48:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8588384AB58 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B8588384AB58 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714808887; cv=none; b=UfZ0na+XFEJSs/Zd1BTL5GCLF4J3AwThJQ3B37rJgfpQkmKIpWejBe2p45PDJdGmhSyPN8NobTzmaU4Nt9OYJrQ9BYaTD1NislP19kLVQtdmqi8jCVFyIXUEdYETgJbrLc0u2jFtP5Te2C5txtTSac+IAR+OU4D3+x+LyfoCuC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714808887; c=relaxed/simple; bh=NxvTuxi43QkXLQT9+ccrhVD8/mRinNL6vZ5iVml139M=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=O8dRncfaag8UztTFqFH2WWImJ5ugU7Grs3VWY2izcX6IDeloXhuG0yuRwrYZPd/O6shoxtB3Rdk+HQdGCc+VqiL2iWB+VcDRLOlDYycorDojR4LXnIbZk2VRbkbvFBGkJzQvxnPdyyXTjXD3d7yFliczxCKvTFLvX416Gjduy9E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 76B6534245; Sat, 4 May 2024 07:48:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714808884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4TEZF3nG20xVa+aoOkv2l1sU3M5zOs1Z3iEQPeMTek=; b=btzzPDkztdp+3GyI4jf/Cog1McV9DkdCvtPD2YlAu7X0t/njrhA1446c8HT/m/Ufjmnbt7 scob4VRvDX1uJSa6Oy3WCSGPS/VHbQQOyStSECJk+/3y+ZCLpEPuGPqCF4Jo+UciMtcJ6w hcmFQTbWmwMIzm4D4verOk2WBxfAzCQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714808884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4TEZF3nG20xVa+aoOkv2l1sU3M5zOs1Z3iEQPeMTek=; b=aBuJlIbGX2eh7npFEiPlpaburtTO7ehmtI1lb8s/u0E5AFoL5l0unmBqGsXonJ1CXkxMwx PHg/aPi/y4cVDSDg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=btzzPDkz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aBuJlIbG DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714808884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4TEZF3nG20xVa+aoOkv2l1sU3M5zOs1Z3iEQPeMTek=; b=btzzPDkztdp+3GyI4jf/Cog1McV9DkdCvtPD2YlAu7X0t/njrhA1446c8HT/m/Ufjmnbt7 scob4VRvDX1uJSa6Oy3WCSGPS/VHbQQOyStSECJk+/3y+ZCLpEPuGPqCF4Jo+UciMtcJ6w hcmFQTbWmwMIzm4D4verOk2WBxfAzCQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714808884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4TEZF3nG20xVa+aoOkv2l1sU3M5zOs1Z3iEQPeMTek=; b=aBuJlIbGX2eh7npFEiPlpaburtTO7ehmtI1lb8s/u0E5AFoL5l0unmBqGsXonJ1CXkxMwx PHg/aPi/y4cVDSDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5BBED139DE; Sat, 4 May 2024 07:48:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YGR6FDToNWZDJQAAD6G6ig (envelope-from ); Sat, 04 May 2024 07:48:04 +0000 Message-ID: <9cdcd951-fc44-48fd-afb7-f9445c1b67da@suse.de> Date: Sat, 4 May 2024 09:48:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] [gdb/testsuite] Use unique portnum in parallel testing (check//% case) To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240415155627.22108-1-tdevries@suse.de> <20240415155627.22108-7-tdevries@suse.de> <87bk5mbpuq.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87bk5mbpuq.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spamd-Result: default: False [-4.49 / 50.00]; BAYES_HAM(-2.99)[99.96%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email,opensuse.org:url]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Queue-Id: 76B6534245 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Score: -4.49 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/3/24 22:30, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Fix this by: > Tom> - creating a common lockdir build/gdb/testsuite.lockdir for make target > Tom> check//%, > Tom> - passing this down to the runtests invocations using variable GDB_LOCK_DIR, > Tom> and > Tom> - using GDB_LOCK_DIR in lock_dir. > > I think I've never once used check//. > I'm not even sure I was aware of its existence. > I know it from the suse / opensuse gdb package ( https://build.opensuse.org/projects/devel:gcc/packages/gdb/files/gdb.spec?expand=1 ), which I think inherited it from the fedora gdb package. > Tom> proc lock_dir {} { > Tom> + if { [info exists ::GDB_LOCK_DIR] } { > Tom> + # When using check//. > Tom> + return $::GDB_LOCK_DIR > Tom> + } > Tom> + > Tom> return [make_gdb_parallel_path cache] > Tom> } > > I guess this approach of not always requiring GDB_LOCK_DIR is handy when > running runtest by hand... I was thinking it might be better to unify > all the scenarios here, but really this doesn't seem so complicated. > > Approved-By: Tom Tromey > Thanks for the review, I'll commit after a round of retesting. Thanks, - Tom