From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 1429E385773A for ; Fri, 21 Apr 2023 15:41:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1429E385773A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4D61E21A42; Fri, 21 Apr 2023 15:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682091693; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uO5OGJEJ4G+xTbgZRIvAop6ighZsBoTDV4lOqhuoNN4=; b=XSNRL2r61VUmNQkNCpG731ag8+w7xCjyf2BV7RmOkvUpS8BzHZhAaYBFVIjTsz+Mh3iRDY 57e1eKv4xX9gxtEZrV9Smwc24hi9fidslj0aaRslwOHdRc82HiifbSuZAJrbHWDp5RHH1O IrqjMxcPbMH0ZuwWKFMnRtVUyZMOwpo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682091693; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uO5OGJEJ4G+xTbgZRIvAop6ighZsBoTDV4lOqhuoNN4=; b=B3RsC0GsCwnQZRAGnKbm/uw4JxODS9QDhf7/fCCTiuSuFszgppGndEms+S0kTKD+uG2DfQ U+DdlB2c8o6Cx4BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 359061390E; Fri, 21 Apr 2023 15:41:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id h4LZC62uQmRfJQAAMHmgww (envelope-from ); Fri, 21 Apr 2023 15:41:33 +0000 Message-ID: <9cdddfac-c645-b7db-ea08-a94bc0170a9d@suse.de> Date: Fri, 21 Apr 2023 17:41:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/1] [gdb/contrib] Add make-check-all.sh Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: Andrew Burgess References: <20230403150957.28921-1-tdevries@suse.de> <20230403150957.28921-2-tdevries@suse.de> <87wn2rc22u.fsf@redhat.com> <97c65614-e1a5-a9cb-b5a3-36020e8ed259@suse.de> <2eef24aa-bbe4-478a-c965-82783d3dea9f@simark.ca> <999c220d-dd64-d6fb-b5ef-912150a4cfd6@suse.de> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/20/23 16:30, Simon Marchi wrote: > On 4/20/23 07:43, Tom de Vries wrote: >> You say you don't understand the comment, but to me it seems you do so I'm not sure I understand what your concern is. Should the comment be improved, or do you want a change in functionality? > > I just wasn't sure which username I was expected to pass to those > options, I wanted to confirm with you that the intent is to have > dedicated systems users for that. So the comment could say that: > > It is recommended to create users on the local system that will act as > "remote host" and "remote target", for the boards that use them. > Pass their usernames to --host-user and --target-user. This helps > because: > > - remote host/target boards will use $HOME and leave (potentially > lots of) files behind > - it enables more strict checking of build/host/target file > manipulations. > - it prevents a command running on one "machine" to kill or send a > signal to a process on another machine > Ack, I've copied that and added a Co-Authored-By tag. >> I've tried adding a bit more comments, updated version attached. > > Thanks, that LGTM. Committed now. Thanks, - Tom