From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119157 invoked by alias); 25 Mar 2019 17:58:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119145 invoked by uid 89); 25 Mar 2019 17:58:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.7 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1332, our X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Mar 2019 17:58:24 +0000 Received: from [172.16.0.89] (192-222-157-41.qc.cable.ebox.net [192.222.157.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B76281E182; Mon, 25 Mar 2019 13:58:21 -0400 (EDT) Subject: Re: GDB version as convenience variable To: Eli Zaretskii , gdb-patches@sourceware.org, Joel Brobecker References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2brhw8k.fsf@gnu.org> <87h8cmh1wg.fsf@tromey.com> <83va12gz8j.fsf@gnu.org> <87mumeb935.fsf@tromey.com> <83d0n8eyzw.fsf@gnu.org> <87d0n6adk2.fsf@tromey.com> <83imwyee29.fsf@gnu.org> <87d0n67d29.fsf@tromey.com> <83imwwc7pj.fsf@gnu.org> <83k1gts5it.fsf@gnu.org> <83r2aun9mk.fsf@gnu.org> From: Simon Marchi Message-ID: <9d445bd2-28dd-be84-5414-510e061e4db1@simark.ca> Date: Mon, 25 Mar 2019 17:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <83r2aun9mk.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00556.txt.bz2 On 2019-03-25 1:31 p.m., Eli Zaretskii wrote: > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -11211,6 +11211,17 @@ > @item $_gthread > The global number of the current thread. @xref{global thread numbers}. > > +@item $_gdb_major > +@itemx $_gdb_minor > +@vindex $_gdb_major@{, convenience variable} > +@vindex $_gdb_minor@{, convenience variable} > +The major and minor version numbers of the running @value{GDBN}. > +Development snapshots and pretest versions have their minor version > +incremented by one; thus, @value{GDBN} pretest 9.11.90 will produce > +the value 12 for @code{$_gdb_minor}. These variables allow you to > +write scripts that work with different versions of @value{GDBN} > +without errors caused by features unavailable in some of those > +versions. > @end table I get this error when trying to "make html": /home/smarchi/src/binutils-gdb/gdb/doc/gdb.texinfo:11216: misplaced } /home/smarchi/src/binutils-gdb/gdb/doc/gdb.texinfo:11217: misplaced } Is it worth having a test for that? If we check that they have the expected value, it would be something to change when a new GDB branch is created, probably (as the master branch will now represent the next version). Maybe our release manager should have a say in this :). Otherwise, this LGTM. Simon