From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2087.outbound.protection.outlook.com [40.107.212.87]) by sourceware.org (Postfix) with ESMTPS id C0B2B385E454 for ; Thu, 29 Apr 2021 15:55:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C0B2B385E454 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HL8zSJqSBLVAkZ94y2wbkFCRRBNdLm1fZP4R6pKkVRu73k06717AjqFmbC0F1j36aP4cACxwGt8Tn4nMkbhPncyhhcUphDN+IiRsUdXyirBDAd/WZRx4DBr8oCZWpO/gZBwnQgEegU8kpdIaXgFSIoeBGL0gZE83Tff97lJbtfg64yOiVaaQzKCYAzWn2SV+W0u6ZkJ98uIdU2NJ0VP/csxIGyGpzcUlRHVAkvDWYJieidgYg1G1103cJ/9RLocISOx9tgmPUznwvFjg87x82QY5rRf9cZ86zKyQf+QJd8hv8o52GE6yMgHM0fesGX3Vm3jzvi6WFvmYo+Q7enMO9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JrjAIwf8VZYfwUK6kZHlkcc1isB4U/614Jq1kjiVzd4=; b=ntKSoHowaJ9x5KY5gOY1Ub5L4VFFZKFMQkn7x/wpvyA+VBnkAik+AaReF6KiDoR5ejDQ9ukonVZMw4y0Nj++fO24UFh+KEpoXmKee7xtSP3yitiJA1cIx9pUJMS28QTtHV5DeamnFfQRgQ+NaBy4pKDYBmKhJ9dSFu06P7lLlOjNLU4R/mwt6QFJ2sVhNj1PpHd/L8/IUkFhagTJLsZX5LFWqsDo6FjCIhWABMwe1fC1WjNwBjTmTlKRlqz8Yoz3sEEeGta4nGgNxkTrLJi/j0yucUIFvDLUwrx6WxBW66Ke9UK16LWGD+EhXX9fEKhpL+BxBcqQy4QuCfL1F0YNIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM6PR12MB2667.namprd12.prod.outlook.com (2603:10b6:5:42::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25; Thu, 29 Apr 2021 15:55:58 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5%7]) with mapi id 15.20.4065.023; Thu, 29 Apr 2021 15:55:58 +0000 Subject: Re: [PATCH 16/43] Simplify dwarf_expr_context class interface To: Simon Marchi , gdb-patches@sourceware.org References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-17-Zoran.Zaric@amd.com> <54bf15e8-eeef-47f7-20ac-c4db23506546@polymtl.ca> From: Zoran Zaric Message-ID: <9d6bfb21-349a-44ca-a5f7-5b74ac898253@amd.com> Date: Thu, 29 Apr 2021 16:55:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 In-Reply-To: <54bf15e8-eeef-47f7-20ac-c4db23506546@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:a49e:1de9:d447:8e06] X-ClientProxiedBy: LO4P123CA0455.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::10) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:a49e:1de9:d447:8e06] (2a00:23c7:5a85:6801:a49e:1de9:d447:8e06) by LO4P123CA0455.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25 via Frontend Transport; Thu, 29 Apr 2021 15:55:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7df1412-25f9-4ef8-932b-08d90b2747a6 X-MS-TrafficTypeDiagnostic: DM6PR12MB2667: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KFc1Bh3ELfhsCaJzfwTSAzx2VwiI2P+dPi5autbjkfKI1Q57XygOjwGcImtxVm1gMcg5v3Nr4XgVEaYmNNWCJo0N3jfQKecLxh3Uoa8VoBdJqHzud01Q5qgqM/VK8Nrmz/J142XIyjP5T1TVGbzQcIN2swAFp6h3Inn2W/PJ0PDFt8fT9YD1F4+v3vosLQwbNlG78TcfNnnnbFVOIChYxUwcOGUkoevELIYkm2Hf2erX68omJ7pd3h78GckAxTj3gLq/Tly4j3lzfp8oCW/khGASOC3ElAQrucUfJsawqmaxsBg64Ie/h0NGRmJC+dQY3T7wqboDQBcNoQ/OtVnb+Z08DNTIU7mKcz+mZMIyyw7Yzh8McSbEtDwGpZnsyaDX6qSqvpi76vwV/bNoAtQOoXuitSJvjm22zKML7FqTHBSksm9Cy7pnW/ofu3H3JKcv/rJ04vV46NCyvUyR+Sc0tl0XyDz3VLhk6EiJgdYbs3iXlx1IneKXQbtACiAhyLZRegAHIAPXkhbEKILJ2Q7rhBeDQBb0l1kWRmBiH8O2hY5Ayz9Mr2wFqCw37NA4HWkSvg8LDlpwsBpXwkD+qXBCZ0X5U7xLlX+VUtcQWbVDFFC9NUyV/ntaoiMLFtISUn7W2ejo/gqFUBhUG9pk+MdlilMcVU24DxULFbMWSsTvJL8pkTzDqDpZeXLN1zrxLEx5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(396003)(39860400002)(346002)(66556008)(2616005)(66476007)(31696002)(86362001)(66946007)(316002)(16526019)(5660300002)(186003)(6486002)(31686004)(52116002)(8936002)(478600001)(2906002)(6666004)(38100700002)(8676002)(53546011)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?aVgyTXhrTGxkUS90U280RDZjWDRrZm5QeEN3TjEyeHdhYUxxQ3MxQTJvVng1?= =?utf-8?B?SlYyOXJ0dmNBUjN5anpGYXhNSUVqc0crNmRaK2h3aFQ4VjZpM0dVTzdZNVg4?= =?utf-8?B?dEFrWXY3NCtrY1ZtcnlBbWVFaVZhWlphUHoxRlk1RnErVGhieDVaTUlFWnBC?= =?utf-8?B?WEl0MEFRZTFzNmtyTnp2RFdkN0tFQjFXUGhRclIraVZqQXo2Q3MyUGxaSVZG?= =?utf-8?B?dVJrcGFxNXhMcVlLR2RVa3NyVFdTd20yWTlkQ3RCdkcrVk9BZXRmL1ZQMmhj?= =?utf-8?B?N04rckNsRi80VzhjRDRJTWptRmljUVBBcFYvQWlXS1VzeUo1QmpOWWxuQXFY?= =?utf-8?B?UXhCaG55ZHV6b3RmS2tYSmh4c05ZSDFYOUJUYmFsUFR0SG1VbzlDcXVuenFi?= =?utf-8?B?akg0VWp1d1E4U0hibGpEQUFIb0pSQXpKVG5oOUtObUswTHhkRHJtbzRtWDNQ?= =?utf-8?B?VytrdUFaNEtwY0RlZUYrUjY2d2RZUzZaaHIyMlY4SldVb1pnRVRpWUpaR283?= =?utf-8?B?aml2dkdkcXJDSS9SNWh1R3Bzdzl4VlQ1eDhIYmJKaUtNWVpielVPc0graUtI?= =?utf-8?B?Z2JXSmVnaWROalkzL2ZDdlJyMVNYWDBackw0b2lSVC8yVldOVFRDOVAzUnYz?= =?utf-8?B?WmZGeUE4d24rcE9JaFQraHF3VG9xQ3FVY0ZYM2w3MktQVGlHOUJHTWpqeVN2?= =?utf-8?B?aTY1cGNQNWNUR0pmSGpkYTJrVUFLdkRSYktzZnBzV2t2RTByQkVVdXZESmZK?= =?utf-8?B?Nm1HZ1pxblROQmt6ZkpQZllJeDlzTzkwNk14R0p2dVp6azJOUnd3MFE0MWxI?= =?utf-8?B?Y1hxV2Rpb3lLUWFhaFJWaVJaRWVGN1Zyb1hjNUprWEt1M2RDN3ByRlFhZ29o?= =?utf-8?B?aXRieEhBUDgrdXZwQkYvdGZKNk5Hd0Nvd0JyNkd1NE1pZ0tSMDhLUWJBNHRB?= =?utf-8?B?aHRYWXhBSkxvanZCWS9LSG93WjJxVWNhS29TYkhHK2FJQ0tiNnU3ZEpRQTZB?= =?utf-8?B?Qmd3MGVWMEh0MTFaWnB4MHZqR0cyaXo5bzJ4T1IvSkhTUmxPMy9qYmdHVkZw?= =?utf-8?B?alpoa2UwaXltRmlUdnNBZDUrR0puSHQ1VjlZTE55ZzhoaWdUeXVCZTNKV1JV?= =?utf-8?B?bkljR2wxakZoYlhLUHZVOEF6aUkrV2pVNXFianAyeXZucTZNSDJtemFJYTQz?= =?utf-8?B?THpsVU5NUWFqMTl3YnZHNDJNMlpiZzdONlBvd2JKUkpBNmNSM2lHTUlvWUlz?= =?utf-8?B?NnllbWFBajVzSUhvQVd5eWNydEhUMmw2a3FJL2dOMjV2STdxazNxZkpBaXRR?= =?utf-8?B?VVZUbnRWMmsyT2s0dXlETUlpU1orSEgxVTRWZ0s5ZzZxNTZKVzVSd0J5STRw?= =?utf-8?B?MktVYWlJU3J3eGhiNVp3S0JpOXFyR2RuVXVsN2E4cUpTeHFlNVNvNW5xVThz?= =?utf-8?B?VEpjS0hoSXQ0WVpCWjNpWUVzY24zc2NSK2dJaEJwK3R5YW9KeEt5M2Q4TmRK?= =?utf-8?B?cFFsU0JiYW8yZCsxakxIYm1QSXF5MWRQYjAzYW9kc1E2SG95TEdmQTVLcGEz?= =?utf-8?B?d0ZrQk5ObnNNRVNQWmVBMXhBQnRaMGY3WjNQYlVDVFJwSndlUXRnMkNyc2M0?= =?utf-8?B?cWdHYkFpWWZqWUpGSXNHd1N5VmJZMVVCNHNzbEF2bkpTKzBtSGZ1YkVENlFH?= =?utf-8?B?MUhFUU1ES21jU2gzN3NiQkdCa0tITWUvcnNDUUJKaVR3K0FxTzN4VkdhVGpi?= =?utf-8?B?T002bHlvbEM1ODd5WGVKdEtWTGhNdTBSY3EwMUd6S2V1YVBUTGM1NUxwWXky?= =?utf-8?B?OTZJUHQzcUFyT0NkSHJQc3pLMWZXRTlHc25XRDRZc2E4SWd4ZDZncm9CNERB?= =?utf-8?Q?ttIjoAuNSG40n?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7df1412-25f9-4ef8-932b-08d90b2747a6 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 15:55:58.4504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rgD/R6Z7QSF3fQo5Gb22IlvtlJCF7/mSLXKk8tuP3kCYo6wBRtsseaMf8nr+eZdtzVqJfZ44bAVuX35Fo6mZvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2667 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Apr 2021 15:56:01 -0000 On 4/29/21 4:49 PM, Simon Marchi wrote: > [CAUTION: External Email] > > On 2021-04-28 9:15 a.m., Zoran Zaric wrote: >> >>>> /* Create a new context for the expression evaluator. */ >>>> >>>> -dwarf_expr_context::dwarf_expr_context (dwarf2_per_objfile *per_objfile) >>>> -: per_objfile (per_objfile) >>>> +dwarf_expr_context::dwarf_expr_context (dwarf2_per_objfile *per_objfile, >>>> + int addr_size) >>>> +: gdbarch (per_objfile->objfile->arch ()), >>> >>> If gdbarch is always obtained from the objfile, we could maybe avoid >>> storing it. >> >> Sure, but it is used so many times (often as a few times per operation) so we currently cut off two indirection per each use. >> >> I think having one pointer as a class member that cuts through all that is worth it. > But there's no need to store it in a member of the class AFAIK, it > could be fetched once at the top of the "evaluate" method. > > Simon > Well it is used by other methods as well, but maybe those are not called too many times so I could grab it on top of each one. I don't mind doing that way really. Zoran