From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 38F6E3858D28 for ; Sat, 16 Dec 2023 08:33:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38F6E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38F6E3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702715616; cv=none; b=uURRnBAx6UO4QtGMjweSxVwcyeDRQ18eHuTGZtAmHhVgkHeD/h+/gGQu5VlzazIxkriUgrVR2Fs9KmyuNIkmX5P1Nw4eDDSp4/b0pGNILFdQtwBvZTX5ike1faxrvUjWpSMvZ7iLNgdcBGUzN6cEW0cKZlz82sSS2KAct/QMYfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702715616; c=relaxed/simple; bh=4xFznso3U3tIUXbV/0IW4fG1gGUt9hq1Hv9N6YYDUHg=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=eb+OoDjw7t0rrwucTVhGGlVXtG/2rzF59uzTCu/2IJI4ID5LIxhk1JLfYulNIvAID5JmVCe13N7ptFhXfmEpSgJtm6qcukEdYmeygcE0B1Un30143GdvfF0UE7fbnxc9pn9c91cm5vZS573mgtlWbfpYJPByNGM1WMKasZ/YCmk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B0F9D1FB67; Sat, 16 Dec 2023 08:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702715613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KwCOYO1ttTSwEnhP1glUAJBpprifGF8dIQgrZFNX+KM=; b=HCsF+mmwgMAR4QcuB8zusCVcUFYK3dOJLTPwDITpYt7lERf/HNQTLat7kdB6QHD5gRsjNA lZ3M0cEQORkAYs/GdQNtujVdj75AA1KnYVDCCQ5lLciG8ZWyRyZU/JL1G15HhxpqC1SMwr NgnI5SGdCRaeRjY63DIDYUb2ZLDE2uQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702715613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KwCOYO1ttTSwEnhP1glUAJBpprifGF8dIQgrZFNX+KM=; b=93Ijg8qt0cnHm4T5teT19VPDlS9dU1IsS3wF4BRaNZTrDhUhwsFnh9CjnKzTArsDyBrJIE crQOFtClaNTsmtDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702715613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KwCOYO1ttTSwEnhP1glUAJBpprifGF8dIQgrZFNX+KM=; b=HCsF+mmwgMAR4QcuB8zusCVcUFYK3dOJLTPwDITpYt7lERf/HNQTLat7kdB6QHD5gRsjNA lZ3M0cEQORkAYs/GdQNtujVdj75AA1KnYVDCCQ5lLciG8ZWyRyZU/JL1G15HhxpqC1SMwr NgnI5SGdCRaeRjY63DIDYUb2ZLDE2uQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702715613; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KwCOYO1ttTSwEnhP1glUAJBpprifGF8dIQgrZFNX+KM=; b=93Ijg8qt0cnHm4T5teT19VPDlS9dU1IsS3wF4BRaNZTrDhUhwsFnh9CjnKzTArsDyBrJIE crQOFtClaNTsmtDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 933821368D; Sat, 16 Dec 2023 08:33:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eukDIt1gfWXhXQAAD6G6ig (envelope-from ); Sat, 16 Dec 2023 08:33:33 +0000 Message-ID: <9d79f40b-816b-470c-8f30-5096f08cbe21@suse.de> Date: Sat, 16 Dec 2023 09:34:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/tui] Show regs when switching to regs layout Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231126075250.31557-1-tdevries@suse.de> <87y1e4hfvv.fsf@tromey.com> <87edfm6i20.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87edfm6i20.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spamd-Result: default: False [-4.47 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.17)[96.02%]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=HCsF+mmw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=93Ijg8qt X-Spam-Score: -4.47 X-Rspamd-Queue-Id: B0F9D1FB67 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/16/23 02:40, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> How about this approach? > > Tom> Rather than adding global state, it adds a function parameter. > > Tom> It's currently called toplevel, though I've also consider "active". > > This is fine by me. > > Really I suspect the register window refresh code can be untangled and > not need any of this, but it's fine to just fix the bug and move on. > I suspect that as well, but unfortunately I don't understand how yet. > Approved-By: Tom Tromey Thanks for the review, pushed. - Tom