From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 9045E3858C60 for ; Wed, 26 Jul 2023 20:04:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9045E3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 36QK4Vvp022310 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Jul 2023 16:04:35 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 36QK4Vvp022310 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1690401875; bh=X50t5MEwr411a4hrWH2eimwdSlFm+MVjoS0ljuwWZ5k=; h=Date:Subject:To:References:From:In-Reply-To:From; b=O1Scaa3B5xEGYpBTHVjdhxdMSW2xA9vKNEwYcZEsu5uWytz7AtIhPiVCpa7YCuf3j GVKYddC8NbtztmQaqnMIuAoa23zsEfGTon90oxOem637kfIW9paug0cKny/EGRSj4Y ATEKTIrlXj/J49OJXUzkJLC0D20CNxpq/XVJ/O10= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E85B11E00F; Wed, 26 Jul 2023 16:04:30 -0400 (EDT) Message-ID: <9d887f0b-b973-569f-8f9c-305e7d9ed7f9@polymtl.ca> Date: Wed, 26 Jul 2023 16:04:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 06/15] gdb: Update x86 FreeBSD architectures to support XSAVE layouts. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20230714155151.21723-1-jhb@FreeBSD.org> <20230714155151.21723-7-jhb@FreeBSD.org> From: Simon Marchi In-Reply-To: <20230714155151.21723-7-jhb@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 26 Jul 2023 20:04:31 +0000 X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > @@ -241,43 +241,49 @@ static const struct tramp_frame i386_fbsd64_sigframe = > i386_fbsd_sigframe_init > }; > > -/* Get XSAVE extended state xcr0 from core dump. */ > +/* See i386-fbsd-tdep.h. */ > > uint64_t > -i386fbsd_core_read_xcr0 (bfd *abfd) > +i386_fbsd_core_read_xsave_info (bfd *abfd, x86_xsave_layout &layout) > { > asection *xstate = bfd_get_section_by_name (abfd, ".reg-xstate"); > - uint64_t xcr0; > + if (xstate == nullptr) > + return X86_XSTATE_SSE_MASK; > > - if (xstate) > + /* Check extended state size. */ > + size_t size = bfd_section_size (xstate); > + if (size < X86_XSTATE_AVX_SIZE) > + return X86_XSTATE_SSE_MASK; > + > + char contents[8]; > + if (! bfd_get_section_contents (abfd, xstate, contents, > + I386_FBSD_XSAVE_XCR0_OFFSET, 8)) > { > - size_t size = bfd_section_size (xstate); > - > - /* Check extended state size. */ > - if (size < X86_XSTATE_AVX_SIZE) > - xcr0 = X86_XSTATE_SSE_MASK; > - else > - { > - char contents[8]; > - > - if (! bfd_get_section_contents (abfd, xstate, contents, > - I386_FBSD_XSAVE_XCR0_OFFSET, > - 8)) > - { > - warning (_("Couldn't read `xcr0' bytes from " > - "`.reg-xstate' section in core file.")); > - return X86_XSTATE_SSE_MASK; > - } > - > - xcr0 = bfd_get_64 (abfd, contents); > - } > + warning (_("Couldn't read `xcr0' bytes from " > + "`.reg-xstate' section in core file.")); > + return X86_XSTATE_SSE_MASK; > } > - else > - xcr0 = X86_XSTATE_SSE_MASK; > + > + uint64_t xcr0 = bfd_get_64 (abfd, contents); > + > + if (!i387_set_xsave_layout (xcr0, size, layout)) > + return X86_XSTATE_SSE_MASK; > > return xcr0; > } > > +/* Implement the core_read_x86_xsave_layout gdbarch method. */ Should be: /* See i386-fbsd-tdep.h. */ > + > +bool > +i386_fbsd_core_read_x86_xsave_layout (struct gdbarch *gdbarch, > + x86_xsave_layout &layout) > +{ > + if (i386_fbsd_core_read_xsave_info (core_bfd, layout) == X86_XSTATE_SSE_MASK) > + return false; > + > + return true; > +} Rewrite as return i386_fbsd_core_read_xsave_info (core_bfd, layout) != X86_XSTATE_SSE_MASK; ? Otherwise: Approved-By: Simon Marchi Simon