From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 89304 invoked by alias); 25 Feb 2018 23:33:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89295 invoked by uid 89); 25 Feb 2018 23:33:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 25 Feb 2018 23:33:50 +0000 Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D11961E584; Sun, 25 Feb 2018 18:33:48 -0500 (EST) Subject: Re: [PATCH 2/7] Don't check abbrev is NULL in read_partial_die To: Yao Qi , gdb-patches@sourceware.org References: <1519313796-2397-1-git-send-email-yao.qi@linaro.org> <1519313796-2397-3-git-send-email-yao.qi@linaro.org> From: Simon Marchi Message-ID: <9da7cbc8-4a37-96e0-fafa-828a62dfda5e@simark.ca> Date: Sun, 25 Feb 2018 23:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519313796-2397-3-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00369.txt.bz2 On 2018-02-22 10:36 AM, Yao Qi wrote: > 'abbrev' won't be NULL, so don't check it. > > gdb: I would suggest changing abbrev type to a const reference then. Simon