From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113585 invoked by alias); 6 Jul 2018 20:10:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113569 invoked by uid 89); 6 Jul 2018 20:10:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=newstyle, new-style, peeked, offer X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 06 Jul 2018 20:10:17 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 087311555C; Fri, 6 Jul 2018 20:10:15 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC7FF6817B; Fri, 6 Jul 2018 20:10:14 +0000 (UTC) Subject: Re: [RFA 40/42] Convert the DWARF reader to new-style buildysm To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-41-tom@tromey.com> From: Keith Seitz Message-ID: <9e5973b7-ab0a-abad-a18e-d9a840d11ce0@redhat.com> Date: Fri, 06 Jul 2018 20:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-41-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00154.txt.bz2 On 05/22/2018 09:58 PM, Tom Tromey wrote: > This converts the DWARF reader to use the new-style buildsym API. A > new buildsym_compunit is created for each CU and is used to construct > the symbol table. In some cases the CU must be passed to functions > which previously did not accept it. FWIW I tend to think that most > methods in the DWARF reader ought to be methods on the dwarf2_cu > object. That's a really nice improvement! IANAM, but I've now peeked at every patch in this series and have nothing but the minor nits to offer along the way. Well done, Keith