From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71]) by sourceware.org (Postfix) with ESMTPS id CF59B3858D1E for ; Tue, 7 May 2024 11:56:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF59B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF59B3858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.20.71 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1715082969; cv=pass; b=eGAmG7V7kdUcFfKT3WE1rpmRNY4uT0yGN2LsPpLRIUnwjnw+K27OKfw+afkTzhverhlkeb3zXxDqgsObRfRzJ2I5CsY6ja6/rQw+HLKUXhaJiA8bTTtFY9hTHAT5pbvHRe9jQEmYQgafJ6UE9iupYyY0GLpKucoSiekjFEMTORA= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1715082969; c=relaxed/simple; bh=Uqp0Q4jmKx5a6mU35clGo12Z6cX7KlZ28g2iHKlQieE=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=iihtpmMT9+oDidVhdpS3gjbg/v3PtTh1MiS9jNzPzoMmNKnvX3/VQmbCDwA3WIGMD3npwXU82XupltEDrIwOP7xF4X5dj1aiX6OIRZSRiv/vbPrVJWFfTq9p97Ptqr5GQhO3P/oqy2THeyfJ59gcha6NeAz9vseYHRbxermZcZQ= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=em5KEZILjeaqa1U46VC5WK3KdrlD2IQ3xCtLYlel2Rto7NCaBP7GR9lSHhneExANeYnxUGQKjQCxb5ZcEeeHhKm7LhxMzzr9sUNG/pRa00tDWhBkZ4i6bcXLqDa3fj3dnRIqYLPKQOIFzQUqFUglb7xAyomptkEcuM3u2DWpDgkj2eTaqqb+VAJKvoemVoPxQUsgnvLoiheRXFi9k2R4vnBd/BJA36y8Zd9oc8odRlc+aJIGS1JiBCeem/tuCDttvRWP6ZNjkzK3xxvTQVHdnTvIzvQXm5qXOdel6pkUhrowifMsVWAlbMYNOjXc4L89C8JWQj09YkXOePh8uRDr1Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u6XKrkrp0lRpbFOnqc49GAGI9dOKTo/jgVhjzeuY8kE=; b=WjHI3jxs92k5/afuigXqgaRfxXwbKGoTiSlhV0Cwa85lYU+valwJQn8nF5IRRmHSe2z8FZZ5yPuzzHMTwLpA6oo0J7GieZRYWZZ+L7jCmG4pzAmnFqLkDu5BYigvyCL+9Jrn5t15+EqkJKdlM0xRHALW3Uj9yjA1cxtDA/7kpAHoPxt8noROgyzuoUIv5zgU1rWzSMo+z051nldi/0o+CoItjg6akUABfjb+KKOv1RXwPa8ER363sbXCJK451FoUlG2nM1zyZ9TM98VYiVeJCocS4gRS3EPX9DONoWj/pPasY42k/i7Hoh2tz+Pnteh2HKnyWPzDgbV7X9NGx+ffcQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u6XKrkrp0lRpbFOnqc49GAGI9dOKTo/jgVhjzeuY8kE=; b=NE+yVZaXKwxJZOElQg+NLikyhXOBHjoOY1W7I1U6s07Qanx/l2Lg0Aa4qHSu/PtfM8O/hJjHJoAjCjecFVaCPCUPYFr1j2+j07pThzUcM108SuZQbjAQibSCnSAT66P+tVJKTp8h860fCbbgBa6v5smvgmVYCSkm1s1zctO2xvY= Received: from DUZP191CA0001.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:4f9::24) by AS2PR08MB9000.eurprd08.prod.outlook.com (2603:10a6:20b:5fd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May 2024 11:55:55 +0000 Received: from DB3PEPF0000885D.eurprd02.prod.outlook.com (2603:10a6:10:4f9:cafe::7e) by DUZP191CA0001.outlook.office365.com (2603:10a6:10:4f9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41 via Frontend Transport; Tue, 7 May 2024 11:55:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB3PEPF0000885D.mail.protection.outlook.com (10.167.242.8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 11:55:54 +0000 Received: ("Tessian outbound ba75727f6dca:v315"); Tue, 07 May 2024 11:55:54 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0e8e2820ea94dd28 X-CR-MTA-TID: 64aa7808 Received: from 9ffaefc111d8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 19110084-E921-4400-BE02-34E718EDF973.1; Tue, 07 May 2024 11:55:48 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9ffaefc111d8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 May 2024 11:55:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FeWwXcDVMmeWy36kjQjGBG9FvOqzR1sm2TE7ZQEITWYipyo+0ZuEesPOI83hzTPHoGjSjzdUQ2x7s52vHOCWwcSiI2JxzS1JnB+oheF/zR72wXoOtOUJ5aWnx8OwWO06ZlcFdQuyphLgdkIEoet3qpnV7mMLgZmjxfucpn6arR3v1stN/1Il4sF1QCvBoylhW6tyYt4KtveXRMppF1xZTQkJlRPYgngV229Y/uqeuMeEXq/k5duRKTjsqBWRE/JU0ThDPbdAKLOo7JEhEjpvaNTyve3wA2vsbtvpov46sl+dNmi/XlJFZxU+ZiGSfPEcsDvZ7mmhDv0tvh3INVwoCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u6XKrkrp0lRpbFOnqc49GAGI9dOKTo/jgVhjzeuY8kE=; b=gUiH27tG8+eI3ApR6vN7habLO1eoJilHNy5LaK5FyoqLqSinKfyaBnQULGmZ/Enc9QCKOO9zZxDVwc4vT9XA6q0aNn8XBWaqpvnd0tj4L2PfFjREROKpn4fDEOSJQgYADrDOJtu0hKrwM9Ed2vI/6boYMxDJjX5OzqrhmReAt3u+3XsRUbaSiph3we+b6Hcr83ipFAcEFChrZT3vfCAKS8vUWN23G8q1Q5pS6rXnI/yMvuCVjqyUl6WZ1Q2ZWFyKJKLC5cTxEXPZf0Kj+TPMWETrC4canN0NV0sgB2hZ9iF+P9fBbpTvwwUFECnxbp3FWYcJoBi/7utBJJgTykDvdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u6XKrkrp0lRpbFOnqc49GAGI9dOKTo/jgVhjzeuY8kE=; b=NE+yVZaXKwxJZOElQg+NLikyhXOBHjoOY1W7I1U6s07Qanx/l2Lg0Aa4qHSu/PtfM8O/hJjHJoAjCjecFVaCPCUPYFr1j2+j07pThzUcM108SuZQbjAQibSCnSAT66P+tVJKTp8h860fCbbgBa6v5smvgmVYCSkm1s1zctO2xvY= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DBBPR08MB5930.eurprd08.prod.outlook.com (2603:10a6:10:200::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.30; Tue, 7 May 2024 11:55:45 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::77d4:d040:b19d:6472%4]) with mapi id 15.20.7544.041; Tue, 7 May 2024 11:55:43 +0000 Message-ID: <9e95c677-b640-43af-903b-b01a48d5ac67@arm.com> Date: Tue, 7 May 2024 12:55:39 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv5 05/11] gdbserver/x86: move no-xml code earlier in x86_linux_read_description To: "Willgerodt, Felix" , Andrew Burgess , "gdb-patches@sourceware.org" Cc: John Baldwin References: <6e7440d3bb04135432f9f18e0630ee1bca23e4d6.1714143669.git.aburgess@redhat.com> Content-Language: en-US From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0417.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::8) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DBBPR08MB5930:EE_|DB3PEPF0000885D:EE_|AS2PR08MB9000:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a090866-a05c-4ee7-f4e8-08dc6e8ca696 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230031|376005|366007|1800799015; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?MkR1YS9CUzlXV0x3M2d0cEl6NlBoSWlaTDMxak9OLzVoWkVmeEY4dDNnY0h5?= =?utf-8?B?Y2J2L09QRjR6TGdYYjdGWU5pYVNpSkZCRE5TbG83L2VWcXpmQVRjSS9tN3dJ?= =?utf-8?B?UTZqSGc2WmZHTmE1L3h1QXVidGt4OXJEdXNHcjFUTmJpRys0dDBkdTVtTHMv?= =?utf-8?B?MWFzOUhnbUc5MWVSUm5WdGlodERKNWR1SEl2TkdjZnpBR1ozZEVNY2lGSExI?= =?utf-8?B?eFA5V1pKak1ndm9iTjJpaVBuVHBsaUtoODQ4SXhSOUdoaWUrN1VuaENXSTE3?= =?utf-8?B?MktoekhHQlBWeDY5YUk3bEgyVUNyWDVSRHdNRzBhZFdXOVVNQlg0dDcvNUJw?= =?utf-8?B?OFA5M3AxK0VIb0hWVDdJNVpCT21tNE40UG1VcVErcDFoUTR1eXlseDJRYmR0?= =?utf-8?B?UnczTW5NMWM3WmZMcmhpRGhyTFl6K2R6bG1kL05uS0ZnTldXQ2g2ZnJXUTdo?= =?utf-8?B?bHczZFp2bDZrUFpLd0dpWkRmcUxjOUtkMzY2M2hCU3lMQ3ppMjlNN3J3Tm1k?= =?utf-8?B?TWl0UTk2aW9mYVFMZEF2Tng5R0lvdmNzQjBic09UT2l0MDM0RnZhRTlRMk5I?= =?utf-8?B?d0MvY1F1a2V3U0x0a2Rwd0VPbnByaE8yUmVwWk9rNVZzdWpjSThDK2Q0VWw1?= =?utf-8?B?Zk1lSHM5YVlXaFZEOHhEQnpWTE9kWmNqa21Ed1hxZ3BWaEF2UURpWkNwam16?= =?utf-8?B?UTdJMWs1SHkwL3ZRUFA1VTRqeTdNVDlUd2tRQWgyMVovUzVYcTV0dVZOb0pS?= =?utf-8?B?a3prck9SUTE5cFR1RjFpNXBBQ2dOV0R0Mk0wMnNtc1htb1RNK3p0OWtzc0Vx?= =?utf-8?B?K3Q3YVJxbXVNV3ZaRE1ZUkM2cWlaNmFSVnU3aGpxVUUrbVZCUEs5VGtUcU1y?= =?utf-8?B?dkpTcGQvUWFFaWI1dmVSZElMM2xrZmVIZFZpNmFXRDdsWjQ1YlNsS05ETlBL?= =?utf-8?B?UlNnNUM5ZW1FbjlPRTdXR0x6aHkyOVBacm1ZY2pjSENlSDBrOGNEQVdwRjNT?= =?utf-8?B?cm95b25ZbFdjbHYvR0ZwRVZOUnBkVk5IM3N6L3BTK3MzUmczRWJKZlNVSjB3?= =?utf-8?B?eW9rSFkwSXpCSngxeGxQMlV3V2tseW1UVkhSaDlOV0RuMklHUnZianZSdVE4?= =?utf-8?B?RGJJa0dsb1JDdzZLN080S3k4Zk5oZFNlSUxHWVIwMW5GNjJ4R05uMW9GYSt4?= =?utf-8?B?OUp1SXF5cXJJU3pGbXpvaGFhVzlqVGk2cElWKy9PZjNnM0xoWWFyMmJBdnNX?= =?utf-8?B?Szg2bFNwdWNBODc5WkdsMmlLL1ZnamgwMG1lUkdYb0xHWUZYQ1RwcFBhejRI?= =?utf-8?B?UWlJeUhQSmR2VHBCT0l3WFpXRW01OFlpb01NOGZGVWhVVGtGUUtWbEgyM3hn?= =?utf-8?B?YnpMSmpQWTZMcmFKYXVvQ0JtMzRVTXh4Wmphem1FcTBPckF4SlZna0N2bzRJ?= =?utf-8?B?ZUd2Q3JGbDVZMSsydzBiMmVNMGppd0dMQ3drSnh0T2IwU3Y4bEFIUXc0U0ph?= =?utf-8?B?enByVTUxS1hwcTh2T1B3U0E2N1FadVZzZVhyaU1kVXVlU21JT0tyMjJZY0s2?= =?utf-8?B?MjRKc09ZcXltRlNiaVlQWW9Hb1ZFWVVDUktFdVBGcEtvYnA3T2tOc0NRVWti?= =?utf-8?B?bGM3L3JDMEcxZGpQVkhKbU4wbXU0d2psbU5ReEU3WTNVT28xaysveHlhdlVs?= =?utf-8?B?NTBRYzh4U2VnQVJycHJMeVZRVWdNK3BpYmp1cGcvaFBPeGg5VC9Ga213PT0=?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5930 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB3PEPF0000885D.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e05c4b5e-37ad-41ac-9301-08dc6e8c9f9b X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|82310400017|1800799015|35042699013|36860700004; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VnEvUE5Nb20rck9GZlM0dktzckhuN2Z3VVJEQ1IxNlpXSHcyWkErMzdjZHlQ?= =?utf-8?B?c2pYd01UcERSUGFzWkZpcENaSnZCU1d6N1hBb0hDK2MzTnBUOGZGbFFoT1lu?= =?utf-8?B?TDhRZ3l4QThJc0JwSzd2WTNWTGM4N0dpYTM0ODdqUUFpZ0tIallsb2Q2Qm9n?= =?utf-8?B?WDBBbE14L0NWdXNLQzhSVmQxb3JlalRyM2JsVzZzdXBWNDNZTVdkYkd1bC9T?= =?utf-8?B?Z3B0THZDTTIzVUtPRThHS2tRdHJCQW1zZkFxc1ByQ2RMbUp3L3Qxay9Kcm5W?= =?utf-8?B?cTNZODBvOWZoVnpVTlRHM1ZCS0Y3UGNhY29QQXpRc2xrQkxVclJWS2p6N3A3?= =?utf-8?B?alhBdVB5RDFRWlNzaE9WNkdtOExwcEtEd2xpeHZwSC9QblA1QW5KbFNvQjhC?= =?utf-8?B?cTI5N1RNRndYc2dIZG4wN2ZacTJDVDdNejNtZ2krOW1sejRWQXdGdllBTVI3?= =?utf-8?B?aU5TTWlEeXNPZWl4VzFGZGFka3pPSmJuZEZXY2ZyeC9xa3pINUN4K2lrOHJU?= =?utf-8?B?dGlEaWRHSHNSMlY1NWowajlCbnFMc3lzb2R0QnRMVnZDMHpMSnU0Zno1Q21s?= =?utf-8?B?QThmRm02MWFqVzRJS0dnamlVdHIwbHhNU1RWZkRoN2ZzdkJzckdCd1FlbDRz?= =?utf-8?B?dTIzaUJ1L29CTEVLTWR0UE9rWHgyYVgxWjB6bjd0YWY4Ykx6VDF0VUZSck9J?= =?utf-8?B?TzJZNTA1SmZuU1hMbjdrTytwM285aVU2V3hqYlQ0TnJ2ZnEwbk0rWndTeVc5?= =?utf-8?B?NTM3S1VvaHZWV2cwTG5FUG8vRmhpaFRXcG5qamdXSDFlSk5TZ2NxMkptZmU2?= =?utf-8?B?ZXh5bWZyNzVNeXVQZlNKRWR0UENlU3hnQzZra3FCb3gwOExzK1RCc21Ga2Zs?= =?utf-8?B?VzBTVjNGZWtidFpNbytqYWdiaEJuSUttLzB3VHRvcy9GMzh4OXlncUUzUVlS?= =?utf-8?B?MWZzWjZjVnF0U1I3TllMSVpYY0tzbVFJaGpuY1FxVTZvcDQrVGVtejBTT1c3?= =?utf-8?B?Uk1CSWk2L3BZTTE2V3lMTkZIbzh6Uk5oS2lRVGdEUENVLzcyMlBxV3AyblpF?= =?utf-8?B?Qm1idHQ4MEg2eE53VUc1cmd1a1pFcDNjTFVHUGZnV2FCZTZ4RmR1M3VML0k5?= =?utf-8?B?NzVnVHVFZXUzNFVEV1NoRFk0M21UUVQxRk4rNjNibkJCYXpoTHJONEhsdkdi?= =?utf-8?B?MFFqTSt3NkZDTVZSbU13YllIN3FicTUydE1uSW0vMGlJZVpCTU15TVpua3FV?= =?utf-8?B?RGZHNjBRemZSNlFLOUp4dnpKc0hocHkzdWlBS1JMYVBmN2xQc3FMZmNXek1k?= =?utf-8?B?TndvYWMzTWZFdWdxVmNXdy9Kb2xvUXVMSStUWFdBc2V5V1dQeDJCY0tmaVY1?= =?utf-8?B?YXozSzVjRUw0SHFCUnhKeXByZ3Bqa0tNK2NGTFl4V1AyeVppYkNmNWFWdFl4?= =?utf-8?B?SW80Q0lKRXRSWXhCNjNDVnQ3VEVBazg0UHhValVlZTczM3hxTWRxQ01kQlFs?= =?utf-8?B?S0lLUk5YVjdmODdHN3VKY2N2NE5aM2hNSzlDaEQ3UFp6NjRoNmYwcVM3b2Qx?= =?utf-8?B?SGh2VkZadkc0eEFqTzl1T2dyWWRSakVOZStLbUtDK1UxbFVSb1hvOEd2UnFh?= =?utf-8?B?akxzYVBjbFEwVmJFY3BzQnVDZk8xT1Bya29zcG1xNUtUWW44VGdGTXppYUp5?= =?utf-8?B?Z3JBWkgxZFJEZXF0WkJibEY2YnVxRXFUUUUvbXh5dTI3dWh0N0VQOUJOZDlW?= =?utf-8?B?aVQ5NUErUGQ3VUlFZWlOakYxNWZqU2kxVXdxUlBuOHNSU0QveXp4eUNiQkNY?= =?utf-8?B?dEkzOEVzTk9sTjZNMkNpMS9wTzNWL0YwMEVtalZuQmJkUXAyMzEveG9kSi9K?= =?utf-8?Q?VbKqVBDOih1/7?= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(376005)(82310400017)(1800799015)(35042699013)(36860700004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 11:55:54.9155 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a090866-a05c-4ee7-f4e8-08dc6e8ca696 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB3PEPF0000885D.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9000 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/29/24 15:34, Willgerodt, Felix wrote: >> -----Original Message----- >> From: Andrew Burgess >> Sent: Freitag, 26. April 2024 17:02 >> To: gdb-patches@sourceware.org >> Cc: Andrew Burgess ; Willgerodt, Felix >> ; John Baldwin >> Subject: [PATCHv5 05/11] gdbserver/x86: move no-xml code earlier in >> x86_linux_read_description >> >> This commit is part of a series that aims to share more of the x86 >> target description reading/generation code between GDB and gdbserver. >> >> There are a huge number of similarities between the code in >> gdbserver's x86_linux_read_description function and GDB's >> x86_linux_nat_target::read_description function, and it is this >> similarity that I plan, in a later commit, to share between GDB and >> gdbserver. >> >> However, one thing that is different in x86_linux_read_description is >> the code inside the '!use_xml' block. This is the code that handles >> the case where gdbserver is not allowed to send an XML target >> description back to GDB. In this case gdbserver uses some predefined, >> fixed, target descriptions. >> >> First, it's worth noting that I suspect this code is not tested any >> more. I couldn't find anything in the testsuite that tries to disable >> XML target description support. And the idea of having a single >> "fixed" target description really doesn't work well when we think >> about all the various x86 extensions that exist. Part of me would >> like to rip out the no-xml support in gdbserver (at least for x86), >> and if a GDB connects that doesn't support XML target descriptions, >> gdbserver can just give an error and drop the connection. GDB has >> supported XML target descriptions for 16 years now, I think it would >> be reasonable for our shipped gdbserver to drop support for the old >> way of doing things. > > Interesting. I for one would +1 this. Slightly related: > I wonder if anyone really builds GDB without libexpat anymore and > if we couldn't even think of making it mandatory. (Which doesn't > mean dropping the ball on supporting stubs without XML.) I'd support making xml descriptions mandatory for some targets. AArch64 and 32-bit Arm both rely heavily on xml description for feature discovery. Off the top of my head, I think very old probes and the Linux Kernel's kgdb don't support xml. I'm not sure how often kgdb gets used though, but falling back to a default description should work for AArch64 and 32-bit Arm.