public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Jan Beulich <JBeulich@suse.com>,
	Markus T Metzger	<markus.t.metzger@intel.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
	Pedro Alves <palves@redhat.com>,	GDB <gdb-patches@sourceware.org>
Subject: Re: Ping: [PATCH v2] x86-64: fix ZMM register state tracking
Date: Wed, 07 Nov 2018 14:18:00 -0000	[thread overview]
Message-ID: <9ec1e2b3-3905-adf7-de93-1400b4d6fc6b@ericsson.com> (raw)
In-Reply-To: <5BE2E7E002000078001F91C6@prv1-mh.provo.novell.com>

On 2018-11-07 8:25 a.m., Jan Beulich wrote:
>>> So can I translate this into an ack for me to commit the change?
>>> Or else, who would be the one to give the go-ahead?
>>
>> Simon can approve your patch.

If Markus is happy with the comments, it's all fine with me, please push (I see
you are listed in MAINTAINERS, so I assume you have push access).

>>
>> IIRC Pedro had a question regarding gdbserver.  From a first look, it seems to get the
>> feature bits right but does not distinguish 32-bit and 64-bit mode regarding the number
>> of available registers.
> 
> If there was a problem there, it was my understanding that this can
> (and should) be fixed in a separate patch, by someone able to test
> this.

Well, you are able to test it (see commands below) :).  But indeed, I think we
should push this patch, which already improves GDB.  It would be nice to at least
get an idea of the status of the test when ran with gdbserver.  Since access to
this hardware is quite limited, it would be appreciated if you could give it a
quick shot and report the results.

>> Did you run the new test you added also in remote configuration?
> 
> No, and I also have no idea how I would go about doing so.

Run:

$ make check TESTS="gdb.arch/i386-avx512.exp" RUNTESTFLAGS="--target_board=native-gdbserver"
$ make check TESTS="gdb.arch/i386-avx512.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"

in the gdb/ build directory.

Thanks,

Simon

  reply	other threads:[~2018-11-07 14:18 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 13:23 [PATCH] " Jan Beulich
2018-09-07 23:13 ` Simon Marchi
2018-09-10  6:25   ` Jan Beulich
2018-09-10 13:01     ` Simon Marchi
2018-09-18 13:38       ` Jan Beulich
2018-09-25  3:29         ` Simon Marchi
2018-09-25 15:04           ` Jan Beulich
2018-10-02 19:20             ` Simon Marchi
2018-10-03 14:30               ` Jan Beulich
2018-10-03 14:41                 ` Simon Marchi
2018-09-11 10:34 ` Pedro Alves
2018-09-11 11:34   ` Jan Beulich
2018-09-24 17:19 ` Metzger, Markus T
2018-09-25  7:47   ` Jan Beulich
2018-10-10 15:12 ` [PATCH v2] " Jan Beulich
2018-10-29 10:31 ` Ping: " Jan Beulich
2018-10-31 14:00   ` Simon Marchi
2018-11-07  9:07     ` Metzger, Markus T
2018-11-07  9:12       ` Jan Beulich
2018-11-07 13:18         ` Metzger, Markus T
2018-11-07 13:25           ` Jan Beulich
2018-11-07 14:18             ` Simon Marchi [this message]
2018-11-08 11:16               ` Jan Beulich
2018-11-08 16:24                 ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ec1e2b3-3905-adf7-de93-1400b4d6fc6b@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=JBeulich@suse.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    --cc=palves@redhat.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).