From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH OBV] Add nowarnings in gdb.base/fileio.exp
Date: Thu, 18 May 2017 11:06:00 -0000 [thread overview]
Message-ID: <9eedfbd7-9f36-2fe4-7a13-00e0b2261629@redhat.com> (raw)
In-Reply-To: <86fug28sxu.fsf@gmail.com>
On 05/18/2017 09:34 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> FWIW, I think that wrapping the offending code with
>>
>> #pragma diagnostics push
>> #pragma diagnostics ignored "-Wnonnull"
>> ... stat (NULL, ...);
>> #pragma diagnostics pop
>>
>> would be appropriate in this case. This testcase is checking that the syscalls
>> on the target map back to host I/O on the gdb side, and some targets have
>> slightly non-POSIX-like system calls APIs; IMHO, it's better to see warnings
>> due to such mismatches instead of potentially silently miscompiling.
>
> The diagnostic was added in gcc 4.6. Do we require gcc 4.6 to run
> testsuite? I am OK with this requirement.
I don't think so. I think that'd be the equivalent of saying that we
don't support debugging target code built with gcc versions earlier
than 4.6. That's a totally different discussion from the discussion
about requirements for building gdb.
How about an even simpler fix: pass a global pointer variable that
happens to be NULL to stat, instead of a NULL literal. The compiler can't
prove (without LTO) that the variable may still be NULL, so it doesn't
warn. Works on all compilers I tried it on: gcc 3.4/5.3/7, clang 3.7.
Let me send a mini series in reply to this email, which does that,
and also fixes a few other warnings that compiling the fileio.c with
-Wall exposes.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-05-18 11:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 13:46 Yao Qi
2017-05-17 14:17 ` Pedro Alves
2017-05-18 8:34 ` Yao Qi
2017-05-18 11:06 ` Pedro Alves [this message]
2017-05-18 11:09 ` [PATCH 3/3] gdb.base/fileio.c: Fix several -Wmaybe-uninitialized warnings Pedro Alves
2017-05-18 11:09 ` [PATCH 2/3] gdb.base/fileio.c: Fix several -Wreturn-type warnings Pedro Alves
2017-05-18 11:09 ` [PATCH 1/3] gdb.base/fileio.exp: Remove nowarnings Pedro Alves
2017-05-18 11:30 ` [PATCH OBV] Add nowarnings in gdb.base/fileio.exp Yao Qi
2017-05-18 11:51 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eedfbd7-9f36-2fe4-7a13-00e0b2261629@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).