From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E449C3857C51 for ; Fri, 18 Nov 2022 16:09:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E449C3857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 448B71E0CB; Fri, 18 Nov 2022 11:09:37 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1668787777; bh=mKFT9xjDTM9T71jIyJLJsSn+Um0aahHMoQgzPBdxZnc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=D/NrQfd/4IDnSRgHZjwQwACfNwi0xLzJ+/6e5gXEOk6jkekBG82hILcZ0LvvpAaU8 MFHYxy9qdR2ALoD3joRkf2TwwSz9Ef8ek1pe2YXJbS0R+cjVfWFeAJnkPUZX9i94Ah g1fpqxPMUh8u4FRR6LAvNPIXRNlj431x7OJDfWQU= Message-ID: <9ef62b37-c480-864b-9626-e3721f81eec2@simark.ca> Date: Fri, 18 Nov 2022 11:09:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 4/8] gdbserver/linux: take condition out of callback in find_lwp_pid Content-Language: en-US To: Andrew Burgess , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20221117194241.1776125-1-simon.marchi@efficios.com> <20221117194241.1776125-5-simon.marchi@efficios.com> <87h6yw8ptr.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87h6yw8ptr.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/22 06:28, Andrew Burgess via Gdb-patches wrote: > Simon Marchi via Gdb-patches writes: > >> Just a small optimization, it's not necessary to recompute lwp at each >> iteration. >> >> While at it, change the variable type to long, as ptid_t::lwp returns a >> long. >> >> Change-Id: I181670ce1f90b59cb09ea4899367750be2ad9105 > > LGTM. > > Reviewed-By: Andrew Burgess Thanks, I pushed this patch. Simon