From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id ACA3A3858030
 for <gdb-patches@sourceware.org>; Fri,  5 Nov 2021 19:51:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACA3A3858030
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca
Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net
 [192.222.180.24])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 493271ECEB;
 Fri,  5 Nov 2021 15:51:11 -0400 (EDT)
Subject: Re: [PATCH v2 04/32] Refactor dwarf2_get_pc_bounds
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20211104180907.2360627-1-tom@tromey.com>
 <20211104180907.2360627-5-tom@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <9efe554c-69e7-1904-91d7-503a390b0bfb@simark.ca>
Date: Fri, 5 Nov 2021 15:51:10 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20211104180907.2360627-5-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Nov 2021 19:51:13 -0000

> @@ -14036,10 +14044,9 @@ dwarf2_ranges_process (unsigned offset, struct dwarf2_cu *cu, dwarf_tag tag,
>  static int
>  dwarf2_ranges_read (unsigned offset, CORE_ADDR *low_return,
>  		    CORE_ADDR *high_return, struct dwarf2_cu *cu,
> -		    dwarf2_psymtab *ranges_pst, dwarf_tag tag)
> +		    addrmap *map, void *datum, dwarf_tag tag)

Perhaps it's code that is going to be deleted anyway, but the comment
above this would need to be updated.