From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2110.outbound.protection.outlook.com [40.107.115.110]) by sourceware.org (Postfix) with ESMTPS id 32B46384AB70 for ; Tue, 23 Apr 2024 14:40:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32B46384AB70 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 32B46384AB70 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.110 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713883262; cv=pass; b=BpcHKpp36uVfTGghSWpTgRyq74TAklWDBnUWMbwUTfkb83jEq+yATd3XrV1wxRRYQHCysPniAuv4yBfOlGKXUK7jyYTR/edyXUdp5oHRVcKNlslF762GnTCHH/ecnbScxyLHvO0FBjJgjL+OKsjx4cGsfg2/8ienILcr6Bcawlw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713883262; c=relaxed/simple; bh=1b5NXZBaJalrrugvmwFd8WjkL0tn9cr+MmHsXQXMMu8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=GYWw/uPc+gOvi6yam6XTyo9PsHy5EXSwTI0U8hQnp/omVoz0wDKXNC8LmiYbY3GY1eNCIm9XAxfH6ps8k/k465/sURw6LMwohx7n5pzreE3uVv+0YPiM7cKGG3UdzgfvoQn748LWEHMPMx5ohV6E+owY8fGM6D8n1bChBJRaens= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OPfuCDL95QpSneCRRthjP2HgREN3GaVWUIL7X/9lvNteQQqGAld5WNVBgHmApAsOXuQozAEt62PJv15+r/D3o/usE6PW4LgihKSVkbSeDPkYV9FqwrdGbijnw02D6n7wANCUQdABDVOXn2Llp1XZAokKHTDvrVzkhs/a7fTezdiBp7StcdRf8dpKpqB7x5RU4Y1PxS2vvFd4KTLPvpUpWAiOcUu6fNDMRRwPef8X2RbzthQEXD53d9b3Bc2lYj5PyMrB0BMpe7QxqntPXY6BNUPdZv1c8LrnS+iU0ZDwrecBSIAqQYXvgttFRSQ8ZLHhdzPw/QLZn+RGAzCh2t6T+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5eUdnJB7CG4mRdB38cLHu+8heBE9YJiiXrumvaEGUJ4=; b=la1bRfMK4huJcx8x7Iqa+5fmYN5lJHFJv1hoLZqnf15Qu9EgDbjSV2KIpT62L10IqGGR8G/hpLaE791ePFJL4ClUQ0xoFpYVBS5e5lhFOeQrR+fQGmGoZUJiYmL57iyldPxucPIFY7FIUzk5+8ofUtNbotrNOYLWyyTotzQDI78DyjnpELVFK93A8TNLi7rDeoKILova5crFWTVlfLvyPlCtKNVL4v/0vX0Nc0Eus4Vyh5tVLwNyZYnL7RvQqgK8QTlW8wXa92xNjxDBw/ht7oVr2qHssltixqu//ehIVv+hEOwULM1xR+MSjZ5PhiMrFZo3Wr9Y3TyyN2D1O1TT0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5eUdnJB7CG4mRdB38cLHu+8heBE9YJiiXrumvaEGUJ4=; b=PN7B9didED/zAwPCLjXQJ3ojPZ7F1wC2CbbDFjSjKK/0GeMVLnK5IImh5FK6J67Kx9LsPJV+sKM8MjUcQdYkBkRWWV9PPqiQAJAi5kVFAmCI1hkcZXQiT9vPShx5/KHv5lDmVoakGRmZmKe8waKpYAJPz1PBZM+9Z9LrEfG+q7GOv1o2SXZ7YgyCtfoyjudwW3huRgJChvrtthR7HDYy6rGpMgRXDAQ7CDMWefTlOnBOKo2MxuAnXN3IDndlwg8qh35EodBz8gmEsLHftEC0ry/v1xoE3NjAdLNYezWGNLj/iqNwXkqQbp7A9kXwXu7Rj/RRVDNajWQA5L28aU2Www== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) by YT3PR01MB6613.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:70::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.21; Tue, 23 Apr 2024 14:40:57 +0000 Received: from YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1]) by YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM ([fe80::3f0e:8077:5724:81b1%5]) with mapi id 15.20.7519.021; Tue, 23 Apr 2024 14:40:57 +0000 Message-ID: <9f079c8c-d5c0-4725-a080-a80956ddebce@efficios.com> Date: Tue, 23 Apr 2024 10:40:55 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf2/read.c: remove pessimizing std::move To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240422190139.36506-1-simon.marchi@efficios.com> <87o7a0qh23.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87o7a0qh23.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0078.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:84::12) To YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2e::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5520:EE_|YT3PR01MB6613:EE_ X-MS-Office365-Filtering-Correlation-Id: 3431a4da-32dc-4c5d-1036-08dc63a362c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|1800799015|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U1NkK0tlVXBsTkcwSUI2Y0hVNW5KN1RlaVA0SWYrZ3h3SG1mWTJzaWtJOWNS?= =?utf-8?B?QVg4V04xUk9kU0NTdEhsUkdlZzZTM0NmNjE4VWNYYTRqbndna0Y3K3g3aWp6?= =?utf-8?B?TG1XRDFxanU3ajBkaXE1YWFCQjU0Q3VzZTluRSswQzhkN0xYbC8vUFVjRmVT?= =?utf-8?B?NVViZDRrMVdjdmh0czVHVjdaRzlGNkp0dWFIbnZXbHhxMGo3bURldUpORGZ6?= =?utf-8?B?M1lrTDk1NzJIcUpUdjBqV1ZYZkpRTXorTStTdDBrVGduaVpkRkUrYVFsc2k1?= =?utf-8?B?anBDcU9yVUlRd05ocGk2VjFiOVhyN1o0bEx1MytyZDRsVFlRVjNDdGxweFls?= =?utf-8?B?WkN3Zlp3cmRXYjMvc1RQTVhoZFE3d1FHVXZBcUZKa0R4OWVlMmtwQW53VVIz?= =?utf-8?B?bng0cUM1RVdNcFNJVFNWQWpvc1ZkQmh0OTNiZ25YYVpDZUk2dDZmbldsemtY?= =?utf-8?B?azdIaVhQSHpLOXFId3pVN0E1WXZ6aU9zbXBFTkpzai9LTGFkSzZ4bDhpSSta?= =?utf-8?B?L3RJWmNOVEFGZlEzdVhJUHRhU0t3OVNIR1VYY0xNQmFYSHg3Nlo4NkM1WERY?= =?utf-8?B?RFZFd29KTW1qTklqNk1HamZnZ00zVzVVZWlNL052REVKZ01MU0Y3NE1KOXA0?= =?utf-8?B?RnJNUC8vMmYvSnJ3a0xvQjJjY3pxb0gxMjd2UUJ0a0IvelRScFNiejdoR242?= =?utf-8?B?MEZkZVhERE1IREp2T1RDK2xWa0Y1SlFSbXVERFVvZ0p3NDlaZGdzSWNHbUo4?= =?utf-8?B?dGZaMkdVU21SZGc0b21YUHJYSUF5cTcvS25qVDlBbjhYYW94algwdGZ4Umk4?= =?utf-8?B?cVRZTTVXclVwNmNZb1cyV2FLdnVJd214TEhqd29seTFESHRPL0Q0UDNYOThG?= =?utf-8?B?OEVNWGYrZHNWMzNHSHMvME9JZHFLZE5IZ0dXQWpEMFVzajFLbHByczhrRml3?= =?utf-8?B?S2U5SVYwS2pmdldpNy92N05qWElaTk5HTkJuRVVvVXhkbmFiVVJuaEtPNi9h?= =?utf-8?B?NnMycHFpNnVWRTBDSjNGaUZsOTNHZUNmZ1F4cmMvVGVsMFNWMVBmWm0xWVNG?= =?utf-8?B?eHdlUi9FRW1CRDRnVGJrNGNlWGpyZUpaQWhqaG9rZlFLR2R3Rm5PUHFNWEs5?= =?utf-8?B?c1E5elY0SlE4OGpObTVHQW85eDRmQTJuTDNnYmdlNS9GbGQ4UzBDWnF2MHBY?= =?utf-8?B?R3pNUXNEeW1iNnJVYTJSem1uQzUwVDJTdU4xdXFwcmtybXl5REk5MGN0REdS?= =?utf-8?B?OGZ6UWtjTHZ3MXBmLzlDOEN2c3EvTnAzbWQweHAyL0p5akpkN1UxZzFPZ3RE?= =?utf-8?B?Y0pGRDZPSEVFTGh5MjJaTXBPc3Y5TE9hMm9QeFRtMU1GNkdGL2cwT25lVnlW?= =?utf-8?B?b3lja3JGVHlaaUZocVNDeFZjN3k0cWZ4QVdyNDZhM3EzZUp4eFFraTFKRWhB?= =?utf-8?B?RVdFa3J2aU9zTmpyeC9TSXB4TGE3NHQ1NW9BUUFHTGNqWkNpdXNtNXdTRXJI?= =?utf-8?B?RklDM09jUTdIMVBnWjhpNWV5cVR2ZnZXM05kVURoVG00MU9wYVMrWWg2Tm9Z?= =?utf-8?B?MmovdWVRamN6d293dVVhWEpNK08wblcrMGk2RVZ2NWNNRmRYUjRSNWpBL1Zr?= =?utf-8?B?SVJveGhVZ2tiQlpKRWVvMEV4cENvc3ZFZ1UxQUQxZm1WSGgwUy9NeGdMcGJS?= =?utf-8?B?aGp5aGw2d3d1ZHFVVU1tTnp3eWdGQnpnUUQvUWJiVXlDVFNCYmhkY1p3PT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(366007)(1800799015)(376005);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2lJQmorcXZqbmJtWk5qT2JtR3JaTVo1NCtpY1p6RlF0YWk0L0JLR0ZrRVhK?= =?utf-8?B?MUpFVXNKc2RlRkJCQkwrbzdEVHU5ZEpCL1NFQXQza3Jab3ZidG5rY1BoY3BF?= =?utf-8?B?WTBmci9aZFhwb29ZQXcyV0Ira251M25yRHp3bzJpbm5nMzhzTURPRjRCSUVM?= =?utf-8?B?MWFDVHk3dmZ0KzlhT0RNbU55QkZuUXF6eWs2MFdick00SEYybjhhRFo3YjhC?= =?utf-8?B?NFp5RnF1ZE9WcnZkZGJOOHNBZDZVWWwzMEpoTnhwc2J3Q0l6RjdJWXQ0cmY5?= =?utf-8?B?a2lIb09TQkxFci9KajVBTndZQTFUT0J1OEZaYWZjWWJLVGZvK3l4OHNuZG9o?= =?utf-8?B?VXVsTXJUbWFsL0RVY01vZkhkM0daUUMvRTdqR3A3d2Z5cE9nMVpLQVFzMERk?= =?utf-8?B?eGhwanZDSzMrTXRoOEQwa0hoUTUzWDE0SjRpZjhacFZrcDhvOGFNeklNcC9E?= =?utf-8?B?bVNNMWhwbXBVT0RqbytBbGhWWDJVekI0WE9mZ2FVVTlUSy96NnVFbnFFRkxi?= =?utf-8?B?YzdwZkNvSlQvb210MHJmRGhDTEdJUDd3akVjVEphaDAwcVJZeW1OYW91SzJD?= =?utf-8?B?RHZrV0E2OFJIZ21lTEI5VkY4eFR0V3BRay9aY0NZS2J5ZUlnQ3I5N3ZPdits?= =?utf-8?B?MDRRS3Z1WHl6YklDY2VBSUp0YlpXOWF1K0RmbTF6RHJjMUM1aXlhbldseFZW?= =?utf-8?B?TVBtdEVGRXlnSW1vb0MyNDBVSDVxUkk3Qk9mUkZHQ2l0TWhpdmRUbUVIZCtT?= =?utf-8?B?OWpRdDZjS0Z4Nm1hQ3I0Mm5tZy9XbnpIendvYkc0bCt2WU11NjErZjl0YVlt?= =?utf-8?B?QWEyL0RaS04xOW1OQlRvNTd4dG5VblQvY05NL0k1RzU5cHZ4aXc1R0o4TG1u?= =?utf-8?B?UWhVRWI2T2VOZkdZbHN6M0JobUlaOGFrZ2VheHZMdENsMEZzbnA4OWVncUN6?= =?utf-8?B?cFJxZHI2NXdka050MkNoRitQalZzYkMvaHhPbEdtSXpHKzI5dmRVY2lFM29T?= =?utf-8?B?RXNTWHdlS3Qxak80T1c5NzVJZ0pZMVhDSEt4bTZzSWxKMUlIamYxYStPeGdY?= =?utf-8?B?cGQvYU96QmJ1SjJxYkJJZmVPNzlWN29UeGJTeFJZc0pMbWF6WFo1THNtc1B6?= =?utf-8?B?a3dVWnYvby9tOEFqQnlHeDJXUTY5SjBYalo3czViSFd5V0E2VC80bzNHUmx2?= =?utf-8?B?bFFHV1IyK2RKWkdzcjdjaHBrTTdhbUhQejcxT0RqWDFHK3lxSTFRZ1VuTmVI?= =?utf-8?B?MFBtRWJ4VTRrY21lMGlJOWpoeHhCNHhzeS9wOFBaakRkMFlPckdjbENHVWVt?= =?utf-8?B?S1hpSFpnZytSUXRRWXUvQ25iM3RhYndmcnN0SXA2RE0ydTRDMFZRWmt0bHQ4?= =?utf-8?B?aTZqZWk4alRMVkVISXdRUVN0MjBHRWFTd2FCSWtwZW93NGxrTno3VkJlcXJ6?= =?utf-8?B?SVhORTR3SGtWZEpmVHlWcEFVVEE3SFdRdjZINWEzVnRYNlZJUmFBa1NhMS9Q?= =?utf-8?B?Mm5nWjNsRkRnM09EWVdKOXhVLzIvMG5WR2laS0JNc2pCZTBicEhvYUp4ZGNr?= =?utf-8?B?ZG1YWW5KSTMvcVErZFpWRlVoV0Mvb2FkeGJuWnNaQmRqa3FNN2kycWN1ZUxt?= =?utf-8?B?TSs3dnNYRmVmaGxZd0ZHLytIaEZILzFIUDZ4RzBXVUtqaHBwZWNqVEZ1QnB4?= =?utf-8?B?ZlIySEVRODkxaFVhRVB1ejFmOVRQNUlFTlU5aTFLcGsweUJLVkRjc0t4WWtK?= =?utf-8?B?dmNiMUl5akR5WVdYV3lGMXAzRG1OZkpYMnV4YllYUmh0MVNjTmJSdWFGcWdG?= =?utf-8?B?RzJiZThrazl1NjBWZjI4K3dENW9GUHNkdFlhRW4yYjZVdXpUbHJRTklrSUZ3?= =?utf-8?B?eTNNRThEWlhCQ3d1cTFNRzFpUkNRZ2hBOHFxN001dVZvZW5lWkVjemxJTHha?= =?utf-8?B?Y2xsekhPcG0ydTZIdEhmMFNoTmk5RDM4WEQwM2JCczZvR3YwWjVJejNuWkh0?= =?utf-8?B?THEyRVRWZ0ZXWVpBeVM1QnpwZVN6K0FxYXo4cWZOMDFwTW42N2VtYy9PckFP?= =?utf-8?B?U3hGVTU0clNONlByYllJRFJ2U0U0a1gvMDkwM1h6YUUrWUdqT1hCNjF0Z0x3?= =?utf-8?Q?r4PTdvA3gCIExgfIR3e0PpFZs?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3431a4da-32dc-4c5d-1036-08dc63a362c1 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5520.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 14:40:56.8665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0V+w39b0PxjND70UBRmzB5L0YYj1dqy5yNBYJ7xa1GwpGqaTtcoyEzbPEGiUonjVKHc/8BYQCfeUI9t83oYbdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB6613 X-Spam-Status: No, score=-3032.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-23 10:39, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> The compiler seems right, there is not need to std::move the result of > Simon> `release_parent_map ()`, it's already going to be an rvalue. Remove the > Simon> std::move. > > Thanks. > Approved-By: Tom Tromey > > Tom Thanks, pushed. Simon