From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B820E3858D20 for ; Wed, 17 Apr 2024 19:57:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B820E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B820E3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713383865; cv=none; b=VZJogteoCCdaoJjvO4baW7s2na8knUvy3VPuRIhI/HeJAM4kp0PBfNSY2DYCkQIu0M6f74AaJoHd7loDHpfWTWLhBgKKQmyLV5ZXgeKaNKY+vwY6iOSRPNLs0Q+wQRtc2snlt65gmvtyRscU1aT5dRI+ZOuYyZv9AuCFEwHyRb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713383865; c=relaxed/simple; bh=OotcLF78RVHM/731jknp0aYAD90DVKe0xowUvdU06OQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=uhTK1U8G41BVzckwVg42C/1Vcd0uCauVRJQeOSbCoLnoTFYVAu7FasfonDbcg5Bc2NzuZ5wFpbGw7ynTBcCsKnZd9D49QDX3c+Dm4Kz0TrTrKeaXJjNtLpVORgLK9pyy6/v6FmaanBKEPDvoSScAma5b1I7MQk0Q7z9u+7c01Ms= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713383857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cANTQWqO4xTricq8y/zgXJ6MEzwjON1db8PNExfLO/Y=; b=SAitNRe488nuIOFXlG5R/ZaUnp2s+F8Mp1uOjN735vYAioworTeQNl7haAwtz5m+MixuPU 4dFBYToqsI/NwVOHVu6L7xk7nMq6S4q8xKYQbrjKNK3yQE235W/G/QuMSu3zCnJ3HkVHD7 oV7jeEItnQDyk7lLMTRQip2DSlfxtqA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-4uL1Y9y9Pm2AHzb9S4AYOQ-1; Wed, 17 Apr 2024 15:57:36 -0400 X-MC-Unique: 4uL1Y9y9Pm2AHzb9S4AYOQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-69937a7ea21so1686366d6.3 for ; Wed, 17 Apr 2024 12:57:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713383855; x=1713988655; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cANTQWqO4xTricq8y/zgXJ6MEzwjON1db8PNExfLO/Y=; b=gJ7+h8Ugqs2HvnI44frxUTnv/iykTloRG/4CRlpwBoJjk2AqHXbzF9PCP5zN/NFOGH TphUOtlq2QdO3yZM+81tMc1qWYAh+oGfTX/QDF2aWJqmnojlwyzIBPbxFf744GryfINE 4Iu7cXUXgNNKwfU+9TTxmkYJ6IAIsmvoZiZFEcYFHr94IyphWAXx0XO4XJQsBHYTlc4l a3Mj54mco4cmkvEVyo3/TyUikwtMinv/keJ3n0fxDrFSDMpAvpNzDHrgMuN1sbTXsS7s tdj0g0CMMHJBq+94ACN2pomITdNuJ5WdZe0E+FtfRDIZRYhRk1IVOMLChcM8xXZWUa78 cy7Q== X-Gm-Message-State: AOJu0Yxk6pxKtuXgmBDNYY6uJegvZjiavFixCwib7ML0R26gLHQhBPn3 HqwFc5kXbvGEEa69qn7MR0paCKtDcIurZQJzVqQDJxnDyYaNeEDtDDPxNZyiULkBIKcLnaJ7vQh EGyfo/sRHnzlg81HcStDvsEcWcrodJsWx/mDH+xoX+f5KkIej3msoDUY129A= X-Received: by 2002:a05:6214:5603:b0:696:a202:5f53 with SMTP id mg3-20020a056214560300b00696a2025f53mr474030qvb.49.1713383855522; Wed, 17 Apr 2024 12:57:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGRNr8c099JVEdNXKBciVLm1F6e+shBHQa7lQqHAuBgtLQEwUZDm70xFvuWWt/Sgz4i7MDXA== X-Received: by 2002:a05:6214:5603:b0:696:a202:5f53 with SMTP id mg3-20020a056214560300b00696a2025f53mr474011qvb.49.1713383855154; Wed, 17 Apr 2024 12:57:35 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id f10-20020a05621400ca00b0069bbcc7f81asm2862107qvs.119.2024.04.17.12.57.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Apr 2024 12:57:34 -0700 (PDT) Message-ID: <9f1813c5-e74b-4f46-9dde-cefcee757a6d@redhat.com> Date: Wed, 17 Apr 2024 16:57:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb: Change "list ." command's error when no debuginfo is available To: Eli Zaretskii Cc: gdb-patches@sourceware.org, simark@simark.ca References: <20240416200058.1300296-2-blarsen@redhat.com> <867cgwi4ji.fsf@gnu.org> <3fea82e9-692a-4544-824e-33614a8eb8d5@redhat.com> <86v84fg59w.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <86v84fg59w.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/17/24 16:26, Eli Zaretskii wrote: >> Date: Wed, 17 Apr 2024 16:20:08 -0300 >> Cc: gdb-patches@sourceware.org, simark@simark.ca >> From: Guinevere Larsen >> >> On 4/17/24 08:58, Eli Zaretskii wrote: >>>> From: Guinevere Larsen >>>> Cc: Simon Marchi >>>> Date: Tue, 16 Apr 2024 17:00:59 -0300 >>>> >>>> From: Simon Marchi >>>> >>>> Currently, when a user tries to list the current location, there are 2 >>>> different error messages that can happen, either: >>>> >>>> (gdb) list . >>>> No symbol table is loaded. Use the "file" command. >>>> or >>>> (gdb) list . >>>> No debug information available to print source lines. >>>> >>>> The difference here is if gdb can find any symtabs at all or not, which >>>> is not something too important for end-users - and isn't informative at >>>> all. This commit changes it so that the error always says that there >>>> isn't debug information available, with these two variants: >>>> >>>> (gdb) list . >>>> No debug information available to print source lines at current PC (0x55555555511d). >>>> or >>>> (gdb) list . >>>> No debug information available to print source lines at default location. >>>> >>>> The difference now is if the inferior has started already, which is >>>> controlled by the user and may be useful. >>> How about this text instead: >>> >>> Insufficient debug info for showing source lines at current PC (0x55555555511d). >>> >> You mean this change only for the error when the inferior has already >> started, or to the prefix of both errors? >> >> Seeing as the errors are for the same root cause, I'd like to keep the >> prefix the same. > I'm afraid I don't understand what is the "prefix" in this case. > Sorry, I meant the start of the sentence. I wasn't sure if you were suggesting the errors should be     Insufficient debug info for showing source lines at current PC (0x55555555511d).     No debug information available to print source lines at default location. Or if you meant that they should both be changed to start with "insufficient debug info (...)". I think I prefer this second option, -- Cheers, Guinevere Larsen She/Her/Hers