* [PATCH, rs6000]: Remove write-only assignment
@ 2017-12-19 12:33 Uros Bizjak
2017-12-20 11:50 ` Yao Qi
0 siblings, 1 reply; 4+ messages in thread
From: Uros Bizjak @ 2017-12-19 12:33 UTC (permalink / raw)
To: gdb-patches; +Cc: kevinb
[-- Attachment #1: Type: text/plain, Size: 159 bytes --]
2017-12-19 Uros Bizjak <ubizjak@gmail.com>
* rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
write-only assignment to "insn" variable.
Uros.
[-- Attachment #2: gdb-rs6000-tdep.diff.txt --]
[-- Type: text/plain, Size: 425 bytes --]
diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index eb784c562f..e8f21a7fc3 100644
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -1225,7 +1225,6 @@ ppc_deal_with_atomic_sequence (struct regcache *regcache)
closing_insn = loc;
loc += PPC_INSN_SIZE;
- insn = read_memory_integer (loc, PPC_INSN_SIZE, byte_order);
/* Insert a breakpoint right after the end of the atomic sequence. */
breaks[0] = loc;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH, rs6000]: Remove write-only assignment
2017-12-19 12:33 [PATCH, rs6000]: Remove write-only assignment Uros Bizjak
@ 2017-12-20 11:50 ` Yao Qi
2017-12-20 11:55 ` Uros Bizjak
0 siblings, 1 reply; 4+ messages in thread
From: Yao Qi @ 2017-12-20 11:50 UTC (permalink / raw)
To: Uros Bizjak; +Cc: gdb-patches, kevinb
Uros Bizjak <ubizjak@gmail.com> writes:
> 2017-12-19 Uros Bizjak <ubizjak@gmail.com>
>
> * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
> write-only assignment to "insn" variable.
Patch is good to me.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, rs6000]: Remove write-only assignment
2017-12-20 11:50 ` Yao Qi
@ 2017-12-20 11:55 ` Uros Bizjak
2017-12-21 1:43 ` Simon Marchi
0 siblings, 1 reply; 4+ messages in thread
From: Uros Bizjak @ 2017-12-20 11:55 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches, kevinb
On Wed, Dec 20, 2017 at 12:50 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> Uros Bizjak <ubizjak@gmail.com> writes:
>
>> 2017-12-19 Uros Bizjak <ubizjak@gmail.com>
>>
>> * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
>> write-only assignment to "insn" variable.
>
> Patch is good to me.
I have no committ rights, can someone please commit the patch for me?
Uros.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH, rs6000]: Remove write-only assignment
2017-12-20 11:55 ` Uros Bizjak
@ 2017-12-21 1:43 ` Simon Marchi
0 siblings, 0 replies; 4+ messages in thread
From: Simon Marchi @ 2017-12-21 1:43 UTC (permalink / raw)
To: Uros Bizjak; +Cc: Yao Qi, gdb-patches, kevinb
On 2017-12-20 06:55, Uros Bizjak wrote:
> On Wed, Dec 20, 2017 at 12:50 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
>> Uros Bizjak <ubizjak@gmail.com> writes:
>>
>>> 2017-12-19 Uros Bizjak <ubizjak@gmail.com>
>>>
>>> * rs6000-tdep.c (ppc_deal_with_atomic_sequence): Remove
>>> write-only assignment to "insn" variable.
>>
>> Patch is good to me.
>
> I have no committ rights, can someone please commit the patch for me?
>
> Uros.
Pushed, thanks for the patch.
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-21 1:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-19 12:33 [PATCH, rs6000]: Remove write-only assignment Uros Bizjak
2017-12-20 11:50 ` Yao Qi
2017-12-20 11:55 ` Uros Bizjak
2017-12-21 1:43 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).