Re: [PATCH 1/6] Use gdb:array_view in call_function_by_hand & friends

[Simon Marchi <simark@simark.ca>]

On 2018-10-15 11:11 a.m., Pedro Alves wrote:
> This replaces a few uses of pointer+length with gdb::array_view, in
> call_function_by_hand and related code.
> 
> Unfortunately, due to -Wnarrowing, there are places where we can't
> brace-initialize an gdb::array_view without an ugly-ish cast.  To
> avoid the cast, this patch introduces a gdb::make_array_view function.
> Unit tests included.
> 
> This patch in isolation may not look so interesting, due to
> gdb::make_array_view uses, but I think it's still worth it.  Some of
> the gdb::make_array_view calls disappear down the series, and others
> could be eliminated with more (non-trivial) gdb::array_view
> detangling/conversion (e.g. code around eval_call).  See this as a "we
> have to start somewhere" patch.

LGTM with two comments:

- The function doc in infcall.h should be updated
- This patch doesn't build for me, probably just one forgotten spot:

  CXX    spu-tdep.o
/home/simark/src/binutils-gdb/gdb/spu-tdep.c: In function ‘void flush_ea_cache()’:
/home/simark/src/binutils-gdb/gdb/spu-tdep.c:2043:69: error: could not convert ‘0’ from ‘int’ to ‘gdb::array_view<value*>’
       call_function_by_hand (value_from_pointer (type, addr), NULL, 0, NULL);
                                                                     ^

Simon