From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 875F9386189D for ; Sat, 2 Dec 2023 10:42:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 875F9386189D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 875F9386189D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701513768; cv=none; b=wIAzgb+Yt1o4plgUHBZh7lgJP8M69sDMMShuRf+01+nl1yl6C22hKLygyw2ZotJ3oBCErCb0/GTxXyhOGrRNuIj9ZPaW1yT749mtsaGB2L5LJCLPhl8ylMg5yxeeosJBOoljTBkeNqnkl8bIZiRcgSsCyqNiCJ8HER2KoIVNHvQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701513768; c=relaxed/simple; bh=/fSSdKFs528Q0S7l647btpz2w4iI9yLuoC3Gy4jl8XE=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=P3dM0c+5WV9NhiuUpXg6D/znqTujdaXP7J4eYoI545XGYYNx3OErUHzz2WDw+CjNE1WzHu2kFnqDNPpBoRbcJJ34wbJeB+KDxEUXiOx4vKRl+PCuv3NU7d8cR9qyxtGp3uOhfpDq7cRHh04NaYh9Rr83nrYC1haoLqp3RdGh6k0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701513767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGZZyMRm4stc/2joIBUcOMMkqu3xZI2hNdlG2ix/3rw=; b=IYjA/KMeXrzMz7T3jgMm4LEYmuMIp2iBo+9UY+RwqYsBrrf6VLudVU7wJ0pYK3P1NmlnuT W91RxW/fJBrE9F4XxvQtmrrFL7rjdyWC3HWTQUTUdEOCPQe0gfl6FcbJm2exkAoY6QzOYX 7QvIYpkDAvm/aXbh4MftZJ37vAa48xc= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-fQgVf7JkMAeZKb18POBuXw-1; Sat, 02 Dec 2023 05:42:46 -0500 X-MC-Unique: fQgVf7JkMAeZKb18POBuXw-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a1a9c98c282so11020966b.1 for ; Sat, 02 Dec 2023 02:42:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701513764; x=1702118564; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XGZZyMRm4stc/2joIBUcOMMkqu3xZI2hNdlG2ix/3rw=; b=PxT9mFkvFuIXfc/+2ocymf5KZ2M/qfdaVUc7fV5yKYAe2pf9iTHIL0DNqXWTBV7B7e HIGUtw/TkmKYi07u7XHZa74GaAR9XrYAh9DadWhlL5xMpA1oeO5fnIknfpVg7vafjtE0 oIUBC2JXbjBs9he62vyViZfKyrH9fc9esiVhkusZwDUchRgwpBk7qFWvj39FUDOETwvr tDP5QYGNCOxadg7CbinRwVRIXFSa5WKn/ZBl6z9JKa3OHCazOTFuflycMyIWoOEhAiV6 KcsppdtsCP9DIAOY/d2dHdsGDevuQ+glQsQoT+mWfQlEIjDo6/jrlvAZymCg1LrVXP+w ALuQ== X-Gm-Message-State: AOJu0YxdZY/rcqMlM4rxh5FfTEBSPOQkj4XXiJtQsP05bNsVUG3aQ07b OZVlIDTEoxX86dcmphffumTlPJWl7FkAHWOSC0Zvdr/e/4Cy5HEby1eN1ObrS611KIuYAjGoQx5 3fu/Q8hvXyVv3hC+8vPy2EawHeYA5WrPj/7GQyhQWmVw5dHstlaOh+Xcsn6j4YY6uZWU1MJ4rGb CODnuVIw== X-Received: by 2002:a50:9f22:0:b0:54c:76bf:eaff with SMTP id b31-20020a509f22000000b0054c76bfeaffmr641636edf.58.1701513764687; Sat, 02 Dec 2023 02:42:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBZWnn2gabIWhSO9aRQaouGXzsGu2fQ+Z7gdeowkubZw0T3lAz5HfIjsLJd1pDq+wEHa14yg== X-Received: by 2002:a50:9f22:0:b0:54c:76bf:eaff with SMTP id b31-20020a509f22000000b0054c76bfeaffmr641632edf.58.1701513764420; Sat, 02 Dec 2023 02:42:44 -0800 (PST) Received: from localhost (92.40.184.5.threembb.co.uk. [92.40.184.5]) by smtp.gmail.com with ESMTPSA id w5-20020a056402268500b0054b25e865f6sm1858172edd.18.2023.12.02.02.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 02:42:44 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCHv6 09/10] gdb: remove tracepoint_probe_create_sals_from_location_spec Date: Sat, 2 Dec 2023 10:42:17 +0000 Message-Id: <9fabfce80e14c91cc36ef510339c0dfb706f2843.1701513410.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The tracepoint_probe_create_sals_from_location_spec function just forwards all its arguments to bkpt_probe_create_sals_from_location_spec, and is only used in one place. Lets delete tracepoint_probe_create_sals_from_location_spec and replace it with bkpt_probe_create_sals_from_location_spec. There should be no user visible changes after this commit. --- gdb/breakpoint.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index 7ca3377150d..7590cd7248c 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -284,9 +284,6 @@ static bool strace_marker_p (struct breakpoint *b); static void bkpt_probe_create_sals_from_location_spec (location_spec *locspec, struct linespec_result *canonical); -static void tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical); const struct breakpoint_ops code_breakpoint_ops = { @@ -301,10 +298,11 @@ static const struct breakpoint_ops bkpt_probe_breakpoint_ops = create_breakpoints_sal, }; -/* Tracepoints set on probes. */ +/* Tracepoints set on probes. We use the same methods as for breakpoints + on probes. */ static const struct breakpoint_ops tracepoint_probe_breakpoint_ops = { - tracepoint_probe_create_sals_from_location_spec, + bkpt_probe_create_sals_from_location_spec, create_breakpoints_sal, }; @@ -12218,17 +12216,6 @@ tracepoint::print_recreate (struct ui_file *fp) const gdb_printf (fp, " passcount %d\n", pass_count); } -/* Virtual table for tracepoints on static probes. */ - -static void -tracepoint_probe_create_sals_from_location_spec - (location_spec *locspec, - struct linespec_result *canonical) -{ - /* We use the same method for breakpoint on probes. */ - bkpt_probe_create_sals_from_location_spec (locspec, canonical); -} - void dprintf_breakpoint::re_set () { -- 2.25.4