From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47625 invoked by alias); 24 Mar 2018 11:42:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47575 invoked by uid 89); 24 Mar 2018 11:42:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 24 Mar 2018 11:42:20 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F3F5ABD9E; Sat, 24 Mar 2018 11:42:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 811F92023234; Sat, 24 Mar 2018 11:42:18 +0000 (UTC) Subject: Re: [RFA v3 00/13] various frame filter fixes and cleanups To: Tom Tromey , gdb-patches@sourceware.org References: <20180323205512.14434-1-tom@tromey.com> From: Pedro Alves Message-ID: <9fc6cba2-eef7-241e-1f53-49d14711ef07@redhat.com> Date: Sat, 24 Mar 2018 11:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180323205512.14434-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00485.txt.bz2 On 03/23/2018 08:54 PM, Tom Tromey wrote: > This is version 3 of a series that I last sent last August: > > https://sourceware.org/ml/gdb-patches/2017-08/msg00277.html > > Most of the patches were already approved, though of course it doesn't > hurt to check again. At least patch #1 needed some reworking in order > to be rebased on top of the changes that have been made since August. > > This version addresses most of the review comments from version 2. > Also, in response to Pedro's feedback about the choice of "elide" as > the option name, I've changed the new command to be "bt hide". I > think this should be unambiguous. > > I have not addressed Phil's comments: > > https://sourceware.org/ml/gdb-patches/2017-08/msg00360.html > https://sourceware.org/ml/gdb-patches/2017-08/msg00359.html > > One reason is that I agree with Pedro's comment here: > > https://sourceware.org/ml/gdb-patches/2017-08/msg00297.html > > Another reason is that I think that the two ideas can live together, > if necessary: I'd still appreciate a way to hide frames from the > command line, overriding whatever individual frame filters think is > appropriate. Similarly, adding this feature to frame filters would > not impact this series -- it can always still be done after this. > > Regression tested by the buildbot. Thanks. This is all fine with me, except the testsuite bit which I sent a separate comment for. Thanks, Pedro Alves