From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id AC704385840F for ; Thu, 17 Mar 2022 11:50:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC704385840F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 22HBo2aQ022454 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Mar 2022 07:50:07 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 22HBo2aQ022454 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C870B1F0D2; Thu, 17 Mar 2022 07:50:01 -0400 (EDT) Message-ID: <9fda8efd-f3e6-2ab7-4d99-59795df20a41@polymtl.ca> Date: Thu, 17 Mar 2022 07:50:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 1/4] gdb: testsuite: remove attach test from can_spawn_for_attach Content-Language: en-US To: Tiezhu Yang , gdb-patches@sourceware.org Cc: Pedro Alves References: <1647492213-21824-1-git-send-email-yangtiezhu@loongson.cn> <1647492213-21824-2-git-send-email-yangtiezhu@loongson.cn> From: Simon Marchi In-Reply-To: <1647492213-21824-2-git-send-email-yangtiezhu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 17 Mar 2022 11:50:02 +0000 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 11:50:17 -0000 > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 08726f7..f508ac6 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -5090,12 +5090,12 @@ proc gdb_exit { } { > # Return true if we can spawn a program on the target and attach to > # it. > > -gdb_caching_proc can_spawn_for_attach { > +proc can_spawn_for_attach { } { > # We use exp_pid to get the inferior's pid, assuming that gives > # back the pid of the program. On remote boards, that would give > # us instead the PID of e.g., the ssh client, etc. > if [is_remote target] then { > - unsupported "skip attach tests (target is remote)" > + verbose -log "skip attach tests (target is remote)" Since we're not actually skipping any tests here, maybe change the actual message to "can't spawn for attach (target is remote)" Same below. LGTM with that fixed. Simon