From: Pedro Alves <palves@redhat.com>
To: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: Eliminate the 'stop_pc' global
Date: Thu, 28 Jun 2018 16:39:00 -0000 [thread overview]
Message-ID: <9fe097e6-3632-2ecb-7a6c-d34b4ef456e2@redhat.com> (raw)
In-Reply-To: <20180621165501.17051-1-palves@redhat.com>
On 06/21/2018 05:55 PM, Pedro Alves wrote:
> In my multi-target work, I need to add a few more
> scoped_restore_current_thread and switch_to_thread calls in some
> places, and in some lower-level places I was fighting against the fact
> that switch_to_thread reads/refreshes the stop_pc global.
>
> Instead of piling on workarounds, let's just finally eliminate the
> stop_pc global. We already have the per-thread
> thread_info->suspend.stop_pc field, so it's mainly a matter of using
> that more/instead.
Thanks guys for the review.
I've pushed it in now.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-06-28 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 16:55 Pedro Alves
2018-06-21 20:10 ` Simon Marchi
2018-06-22 16:56 ` Sergio Durigan Junior
2018-06-28 16:39 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe097e6-3632-2ecb-7a6c-d34b4ef456e2@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).