From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35533 invoked by alias); 28 Jun 2018 16:39:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35518 invoked by uid 89); 28 Jun 2018 16:39:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:630, guys, fighting, piling X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Jun 2018 16:39:18 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8DCC576F9F for ; Thu, 28 Jun 2018 16:39:17 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E2A520389E0 for ; Thu, 28 Jun 2018 16:39:17 +0000 (UTC) Subject: Re: [PATCH] gdb: Eliminate the 'stop_pc' global To: GDB Patches References: <20180621165501.17051-1-palves@redhat.com> From: Pedro Alves Message-ID: <9fe097e6-3632-2ecb-7a6c-d34b4ef456e2@redhat.com> Date: Thu, 28 Jun 2018 16:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180621165501.17051-1-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00692.txt.bz2 On 06/21/2018 05:55 PM, Pedro Alves wrote: > In my multi-target work, I need to add a few more > scoped_restore_current_thread and switch_to_thread calls in some > places, and in some lower-level places I was fighting against the fact > that switch_to_thread reads/refreshes the stop_pc global. > > Instead of piling on workarounds, let's just finally eliminate the > stop_pc global. We already have the per-thread > thread_info->suspend.stop_pc field, so it's mainly a matter of using > that more/instead. Thanks guys for the review. I've pushed it in now. Thanks, Pedro Alves