From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 08/10] More use of std::vector in linespec.c
Date: Mon, 02 Apr 2018 02:35:00 -0000 [thread overview]
Message-ID: <9fe97b40-59da-4b51-fc1c-76fe1619353f@simark.ca> (raw)
In-Reply-To: <20180401163539.15314-9-tom@tromey.com>
On 2018-04-01 12:35 PM, Tom Tromey wrote:
> This changes some spots in linespec.c to take a std::vector. This
> patch spilled out to objc-lang.c a bit as well. This change allows
> for the removal of some cleanups.
>
> 2018-03-31 Tom Tromey <tom@tromey.com>
>
> * utils.c (compare_strings): Remove.
> * utils.h (compare_strings): Remove.
> * objc-lang.h (find_imps): Update.
> * objc-lang.c (find_methods): Take a std::vector.
> (uniquify_strings, find_imps): Likewise.
> * linespec.c (find_methods): Take a std::vector.
> (decode_objc): Use std::vector.
> (add_all_symbol_names_from_pspace, find_superclass_methods): Take
> a std::vector.
> (find_method, find_function_symbols): Use std::vector.
> ---
> gdb/ChangeLog | 13 +++++++++++++
> gdb/linespec.c | 47 ++++++++++++++++++-----------------------------
> gdb/objc-lang.c | 44 ++++++++++++--------------------------------
> gdb/objc-lang.h | 4 ++--
> gdb/utils.c | 11 -----------
> gdb/utils.h | 1 -
> 6 files changed, 45 insertions(+), 75 deletions(-)
>
> diff --git a/gdb/linespec.c b/gdb/linespec.c
> index 48168eaaa6..96a3117293 100644
> --- a/gdb/linespec.c
> +++ b/gdb/linespec.c
> @@ -379,7 +379,7 @@ static void add_matching_symbols_to_info (const char *name,
>
> static void add_all_symbol_names_from_pspace (struct collect_info *info,
> struct program_space *pspace,
> - VEC (const_char_ptr) *names,
> + const std::vector<const char *> &names,
This line is now too long, otherwise LGTM.
Simon
next prev parent reply other threads:[~2018-04-02 2:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-01 16:35 [RFA 00/10] Remove some cleanups from linespec.c Tom Tromey
2018-04-01 16:35 ` [RFA 03/10] Make copy_token_string return unique_xmalloc_ptr Tom Tromey
2018-04-01 16:35 ` [RFA 07/10] Change streq to return bool Tom Tromey
2018-04-02 2:28 ` Simon Marchi
2018-04-01 16:35 ` [RFA 04/10] Return std::string from canonical_to_fullform Tom Tromey
2018-04-02 2:15 ` Simon Marchi
2018-04-01 16:35 ` [RFA 08/10] More use of std::vector in linespec.c Tom Tromey
2018-04-02 2:35 ` Simon Marchi [this message]
2018-04-01 16:35 ` [RFA 10/10] Remove unnecessary include from linespec.h Tom Tromey
2018-04-01 16:35 ` [RFA 01/10] Remove some cleanups from search_minsyms_for_name Tom Tromey
2018-04-02 1:39 ` Simon Marchi
2018-04-01 16:35 ` [RFA 05/10] Have filter_results take a std::vector Tom Tromey
2018-04-01 16:35 ` [RFA 02/10] Fix some indentation in linespec.c Tom Tromey
2018-04-02 1:49 ` Simon Marchi
2018-04-01 16:35 ` [RFA 06/10] Remove a string copy from event_location_to_sals Tom Tromey
2018-04-01 16:35 ` [RFA 09/10] Remove typep and VEC(typep) from linespec.c Tom Tromey
2018-04-02 2:44 ` [RFA 00/10] Remove some cleanups " Simon Marchi
2018-04-03 22:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe97b40-59da-4b51-fc1c-76fe1619353f@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).