From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23447 invoked by alias); 20 Dec 2013 12:54:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23434 invoked by uid 89); 20 Dec 2013 12:54:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2013 12:54:47 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 20 Dec 2013 04:50:55 -0800 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 20 Dec 2013 04:54:35 -0800 Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 20 Dec 2013 12:53:32 +0000 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX151.ger.corp.intel.com ([169.254.4.126]) with mapi id 14.03.0123.003; Fri, 20 Dec 2013 12:53:32 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v9 11/29] record-btrace: optionally indent function call history Date: Fri, 20 Dec 2013 12:54:00 -0000 Message-ID: References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-12-git-send-email-markus.t.metzger@intel.com> <52B339A6.3050205@redhat.com> In-Reply-To: <52B339A6.3050205@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00828.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Thursday, December 19, 2013 7:24 PM > To: Metzger, Markus T > On 12/19/2013 04:44 PM, Markus Metzger wrote: > > Add a new modifier /c to the "record function-call-history" command to > > indent the function name based on its depth in the call stack. > > > > Also reorder the optional fields to have the indentation at the very > beginning. > > Prefix the insn range (/i modifier) with "inst ". >=20 > I was a little surprised the manual didn't get an update for this one, > but I see an /i example is currently lacking. Can one use both > /i and /l at the same time ? Yes. Does this need to be documented explicitly? > > Change the range syntax from "begin-end" to "begin,end" to allow > copy&paste to > > the "record instruction-history" and "list" commands. >=20 > (This bit seems to be missing in NEWS. Not sure it was on purpose.) I'll add it. > > There is one known bug regarding indentation that results from the fact > that we > > have the current instruction already inside the branch trace. When the > current > > instruction is the first (and only) instruction in a function on the ou= termost > > level for which we have not seen the call, the indentation starts at le= vel 1 > > with 2 leading spaces. >=20 > Hmm. Why are we adding known bugs? I'm not sure I understood it, but > from > your description it sounds like the condition should be detectable? Yes, it is detectable. You can't fix it up afterwards, though, so you need= to check this when computing the trace for each instruction. I have not tried to fix it because I think you wouldn't even notice it in practice. The fix is relatively easy, so I added it and updated the tests. Looking b= ack, I can't really say why I haven't just fixed it right away. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052