From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18062 invoked by alias); 20 Dec 2013 13:32:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18053 invoked by uid 89); 20 Dec 2013 13:32:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mga02.intel.com Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2013 13:32:02 +0000 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 20 Dec 2013 05:31:59 -0800 X-ExtLoop1: 1 Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 20 Dec 2013 05:31:58 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX102.ger.corp.intel.com ([169.254.2.114]) with mapi id 14.03.0123.003; Fri, 20 Dec 2013 13:30:59 +0000 From: "Metzger, Markus T" To: Pedro Alves CC: "jan.kratochvil@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v9 21/29] record-btrace: provide xfer_partial target method Date: Fri, 20 Dec 2013 13:32:00 -0000 Message-ID: References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-22-git-send-email-markus.t.metzger@intel.com> <52B34879.4020905@redhat.com> In-Reply-To: <52B34879.4020905@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg00831.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Thursday, December 19, 2013 8:27 PM > To: Metzger, Markus T > Cc: jan.kratochvil@redhat.com; gdb-patches@sourceware.org > Subject: Re: [PATCH v9 21/29] record-btrace: provide xfer_partial target > method >=20 > On 12/19/2013 04:44 PM, Markus Metzger wrote: >=20 > Also, >=20 > > + /* Filter out requests that don't make sense during replay. */ > > + if (!record_btrace_allow_memory_access && > record_btrace_is_replaying ()) > > + { > > + switch (object) > > + { > > + case TARGET_OBJECT_MEMORY: > > + case TARGET_OBJECT_RAW_MEMORY: > > + case TARGET_OBJECT_STACK_MEMORY: > > + { >=20 > I don't think you answered my comment about this in the previous > series. I think you can't ever see TARGET_OBJECT_RAW_MEMORY or > TARGET_OBJECT_STACK_MEMORY here. If we ever end up seeing them, they will simply be forwarded to the target beneath without check. I think it's safer to leave them in. If you'd rather have them removed, I can do that, as well. Regards, Markus. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052